bnx2x: Fix AER semaphore release
PATCH 1/1 bnx2x: Fix AER semaphore release
Commit 7fa6f34 "AER revised" erroneously inserted an error-flow in which a semaphore is released even though the attempt to take it has failed.
Reported-by Dan Carpenter <[email protected]>
Signed-off-by Yuval Mintz <[email protected]>
Signed-off-by Ariel Elior <[email protected]>
---
Hi Dave,
Please accept this to `net-next'.
Thanks,
Yuval
--- drivers/net/ethernet/broadcom/bnx2x/bnx2x_main.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/net/ethernet/broadcom/bnx2x/bnx2x_main.c +1 -1
@@ -10070,8 +10070,8 @@ static int bnx2x_prev_unload(struct bnx2x *bp)/* If Path is marked by EEH, ignore unload status */ aer = !!(bnx2x_prev_path_get_entry (bp) &&bnx2x_prev_path_get_entry (bp)->aer); +up (&bnx2x_prev_sem); } -up (&bnx2x_prev_sem);if (fw ==FW_MSG_CODE_DRV_UNLOAD_COMMON || aer) { rc =bnx2x_prev_unload_common (bp);
Signature · 1 line
1.8.1.227.g44fe835
From: "Yuval Mintz" <[email protected]>
Date: Wed, 27 Mar 2013 11:28:03 +0200
Quoted 7 lines
Commit 7fa6f34 "AER revised" erroneously inserted an error-flow in which a semaphore is released even though the attempt to take it has failed.
Reported-by Dan Carpenter <[email protected]>Signed-off-by Yuval Mintz <[email protected]>Signed-off-by Ariel Elior <[email protected]>
Applied.