net: core: let's use native isxdigit instead of custom
Subsystems (3)
PATCH 1/2 net: core: let's use native isxdigit instead of custom
In kernel we have fast and pretty implementation of the isxdigit() function. Let's use it.
Signed-off-by Andy Shevchenko <[email protected]>
--- net/core/utils.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-)
net/core/utils.c +2 -3
@@ -17,6 +17,7 @@#include <linux/module.h> #include <linux/jiffies.h> #include <linux/kernel.h> +#include <linux/ctype.h> #include <linux/inet.h> #include <linux/mm.h> #include <linux/net.h>
@@ -348,9 +349,7 @@ int mac_pton(const char *s, u8 *mac)/* Don't dirty result unless string is valid MAC. */ for (i =0 ; i <ETH_ALEN ; i++) { -if (!strchr ("0123456789abcdefABCDEF" , s[i *3 ])) -return 0 ; -if (!strchr ("0123456789abcdefABCDEF" , s[i *3 +1 ])) +if (!isxdigit (s[i *3 ]) || !isxdigit (s[i *3 +1 ]))return 0 ;if (i !=ETH_ALEN -1 && s[i *3 +2 ] !=':' )return 0 ;
Signature · 1 line
1.8.2.rc0.22.gb3600c3
PATCH 2/2 ppp: reuse print_hex_dump_bytes
There is a native function to dump hex buffers.
Signed-off-by Andy Shevchenko <[email protected]>
--- drivers/net/ppp/ppp_synctty.c | 53 ++----------------------------------------- 1 file changed, 2 insertions(+), 51 deletions(-)
drivers/net/ppp/ppp_synctty.c +2 -51
@@ -105,64 +105,15 @@ static const struct ppp_channel_ops sync_ops = { };/* -* Utility procedures to print a buffer in hex/ascii +* Utility procedure to print a buffer in hex/ascii */ static void -ppp_print_hex (register__u8 * out,const __u8 * in,int count) -{ - register__u8 next_ch; -static const char hex[] ="0123456789ABCDEF" ; - -while (count-- >0 ) { - next_ch = *in++; - *out++ = hex[(next_ch >>4 ) &0x0F ]; - *out++ = hex[next_ch &0x0F ]; - ++out; - } -} - -static void -ppp_print_char (register__u8 * out,const __u8 * in,int count) -{ - register__u8 next_ch; - -while (count-- >0 ) { - next_ch = *in++; - -if (next_ch <0x20 || next_ch >0x7e ) - *out++ ='.' ; -else { - *out++ = next_ch; -if (next_ch ='%' )/* printk/syslogd has a bug !! */ - *out++ ='%' ; - } - } - *out ='\0' ; -} - -static void ppp_print_buffer (const char *name,const __u8 *buf,int count) { -__u8 line[44 ]; -if (name !=NULL )printk (KERN_DEBUG "ppp_synctty: %s, count = %d\n" , name, count); -while (count >8 ) { -memset (line,32 ,44 ); -ppp_print_hex (line, buf,8 ); -ppp_print_char (&line[8 *3 ], buf,8 ); -printk (KERN_DEBUG "%s\n" , line); - count -=8 ; - buf +=8 ; - } - -if (count >0 ) { -memset (line,32 ,44 ); -ppp_print_hex (line, buf, count); -ppp_print_char (&line[8 *3 ], buf, count); -printk (KERN_DEBUG "%s\n" , line); - } +print_hex_dump_bytes ("" ,DUMP_PREFIX_NONE , buf, count); }
Signature · 1 line
1.8.2.rc0.22.gb3600c3
Re: [PATCH 2/2] ppp: reuse print_hex_dump_bytes
From: Andy Shevchenko <[email protected]>
Date: Wed, 27 Mar 2013 17:54:14 +0200
Quoted 3 lines
There is a native function to dump hex buffers.
Signed-off-by Andy Shevchenko <[email protected]>
Applied.
From: Andy Shevchenko <[email protected]>
Date: Wed, 27 Mar 2013 17:54:13 +0200
Quoted 4 lines
In kernel we have fast and pretty implementation of the
isxdigit()function. Let's use it.Signed-off-by Andy Shevchenko <[email protected]>
Applied.