Skip to contentSkip to conversation

video: exynos: Convert to devm_ioremap_resource()

PATCH In review Andrei Epure 2 participants 2 messages Mar 27, 2013

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 video: exynos: Convert to devm_ioremap_resource()

The new devm_ioremap_resource() provides its own error messages. Patch found using coccinelle.

---
 drivers/video/exynos/exynos_mipi_dsi.c |    7 +++----
 1 file changed, 3 insertions(+), 4 deletions(-)
drivers/video/exynos/exynos_mipi_dsi.c +3 -4
index fac7df6..dd5e5e9 100644
@@ -384,10 +384,9 @@ static int exynos_mipi_dsi_probe(struct platform_device *pdev)
 
 	res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
 
-	dsim->reg_base = devm_request_and_ioremap(&pdev->dev, res);
-	if (!dsim->reg_base) {
-		dev_err(&pdev->dev, "failed to remap io region\n");
-		ret = -ENOMEM;
+	dsim->reg_base = devm_ioremap_resource(&pdev->dev, res);
+	if (IS_ERR(dsim->reg_base)) {
+		ret = PTR_ERR(dsim->reg_base);
 		goto error;
 	}
 
Signature · 1 line
1.7.9.5
#1 lore raw

Hi,

Please refer to the following link.

http://marc.info/?l=linux-fbdev&m5963121130437&w=2

Best regard,
Donghwa Lee

Quoted 26 lines · Andrei Epure

The new devm_ioremap_resource() provides its own error messages. Patch found using coccinelle.

---
  drivers/video/exynos/exynos_mipi_dsi.c |    7 +++----
  1 file changed, 3 insertions(+), 4 deletions(-)
drivers/video/exynos/exynos_mipi_dsi.c +3 -4
index fac7df6..dd5e5e9 100644
@@ -384,10 +384,9 @@ static int exynos_mipi_dsi_probe(struct platform_device *pdev)
 
  	res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
 
-	dsim->reg_base = devm_request_and_ioremap(&pdev->dev, res);
-	if (!dsim->reg_base) {
-		dev_err(&pdev->dev, "failed to remap io region\n");
-		ret = -ENOMEM;
+	dsim->reg_base = devm_ioremap_resource(&pdev->dev, res);
+	if (IS_ERR(dsim->reg_base)) {
+		ret = PTR_ERR(dsim->reg_base);
  		goto error;
  	}