video: exynos: remove useless safety check in list traversal
Subsystems (2)
PATCH 1/1 video: exynos: remove useless safety check in list traversal
list_for_each_entry_safe() does not require safety check. Patch found using coccinelle.
Signed-off-by Andrei Epure <[email protected]>
--- drivers/video/exynos/exynos_mipi_dsi.c | 16 ++++++---------- 1 file changed, 6 insertions(+), 10 deletions(-)
drivers/video/exynos/exynos_mipi_dsi.c +6 -10
@@ -214,8 +214,6 @@ static struct mipi_dsim_ddi *exynos_mipi_dsi_find_lcd_device(mutex_lock (&mipi_dsim_lock);list_for_each_entry_safe (dsim_ddi, next, &dsim_ddi_list, list) { -if (!dsim_ddi) - goto out; lcd_dev = dsim_ddi->dsim_lcd_dev;if (!lcd_dev)
@@ -473,17 +471,15 @@ static int exynos_mipi_dsi_remove(struct platform_device *pdev)clk_disable (dsim->clock);list_for_each_entry_safe (dsim_ddi, next, &dsim_ddi_list, list) { -if (dsim_ddi) { -if (dsim->id != dsim_ddi->bus_id) -continue ; +if (dsim->id != dsim_ddi->bus_id) +continue ; - dsim_lcd_drv = dsim_ddi->dsim_lcd_drv; + dsim_lcd_drv = dsim_ddi->dsim_lcd_drv; -if (dsim_lcd_drv->remove) - dsim_lcd_drv->remove (dsim_ddi->dsim_lcd_dev); +if (dsim_lcd_drv->remove) + dsim_lcd_drv->remove (dsim_ddi->dsim_lcd_dev); -kfree (dsim_ddi); - } +kfree (dsim_ddi); }return 0 ;
Signature · 1 line
1.7.9.5
Hi,
It looks good to me.
Acked-by Donghwa Lee <[email protected]>
Best regard,
Donghwa Lee
Quoted 45 lines · Andrei Epure
list_for_each_entry_safe()does not require safety check. Patch found using coccinelle.Signed-off-by Andrei Epure<[email protected]>--- drivers/video/exynos/exynos_mipi_dsi.c | 16 ++++++---------- 1 file changed, 6 insertions(+), 10 deletions(-)drivers/video/exynos/exynos_mipi_dsi.c +6
-10@@ -214,8 +214,6 @@ static struct mipi_dsim_ddi *exynos_mipi_dsi_find_lcd_device(mutex_lock (&mipi_dsim_lock);list_for_each_entry_safe (dsim_ddi, next, &dsim_ddi_list, list) { -if (!dsim_ddi) - goto out; lcd_dev = dsim_ddi->dsim_lcd_dev;if (!lcd_dev)@@ -473,17 +471,15 @@ static int exynos_mipi_dsi_remove(struct platform_device *pdev)clk_disable (dsim->clock);list_for_each_entry_safe (dsim_ddi, next, &dsim_ddi_list, list) { -if (dsim_ddi) { -if (dsim->id != dsim_ddi->bus_id) -continue ; +if (dsim->id != dsim_ddi->bus_id) +continue ; - dsim_lcd_drv = dsim_ddi->dsim_lcd_drv; + dsim_lcd_drv = dsim_ddi->dsim_lcd_drv; -if (dsim_lcd_drv->remove) - dsim_lcd_drv->remove (dsim_ddi->dsim_lcd_dev); +if (dsim_lcd_drv->remove) + dsim_lcd_drv->remove (dsim_ddi->dsim_lcd_dev); -kfree (dsim_ddi); - } +kfree (dsim_ddi); }return 0 ;