video: fixed missing iounmap coccinelle errors
PATCH 1/1 video: fixed missing iounmap coccinelle errors
Modified or added the necessary goto statements so that the ioremapped regions get unmapped before return.
Signed-off-by Andrei Epure <[email protected]>
--- drivers/video/vt8500lcdfb.c | 7 ++++--- drivers/video/wm8505fb.c | 7 ++++--- 2 files changed, 8 insertions(+), 6 deletions(-)
drivers/video/vt8500lcdfb.c +4 -3
@@ -350,7 +350,7 @@ static int vt8500lcd_probe(struct platform_device *pdev)if (!np) {pr_err ("%s: No display description in Device Tree\n" , __func__); ret = -EINVAL ; - goto failed_free_res; + goto failed_free_io; }/*
@@ -369,7 +369,7 @@ static int vt8500lcd_probe(struct platform_device *pdev) ret |=of_property_read_u32 (np,"bpp" , &bpp);if (ret) {pr_err ("%s: Unable to read display properties\n" , __func__); - goto failed_free_res; + goto failed_free_io; } of_mode.vmode =FB_VMODE_NONINTERLACED ;
@@ -379,7 +379,8 @@ static int vt8500lcd_probe(struct platform_device *pdev) GFP_KERNEL);if (!fb_mem_virt) {pr_err ("%s: Failed to allocate framebuffer\n" , __func__); -return -ENOMEM ; + ret = -ENOMEM ; + goto failed_free_io; }; fbi->fb.fix.smem_start = fb_mem_phys;
drivers/video/wm8505fb.c +4 -3
@@ -332,7 +332,7 @@ static int wm8505fb_probe(struct platform_device *pdev)if (!np) {pr_err ("%s: No display description in Device Tree\n" , __func__); ret = -EINVAL ; - goto failed_free_res; + goto failed_free_io; }/*
@@ -351,7 +351,7 @@ static int wm8505fb_probe(struct platform_device *pdev) ret |=of_property_read_u32 (np,"bpp" , &bpp);if (ret) {pr_err ("%s: Unable to read display properties\n" , __func__); - goto failed_free_res; + goto failed_free_io; } of_mode.vmode =FB_VMODE_NONINTERLACED ;
@@ -369,7 +369,8 @@ static int wm8505fb_probe(struct platform_device *pdev) GFP_KERNEL);if (!fb_mem_virt) {pr_err ("%s: Failed to allocate framebuffer\n" , __func__); -return -ENOMEM ; + ret = -ENOMEM ; + goto failed_free_io; }; fbi->fb.var.xres_virtual = of_mode.xres;
Signature · 1 line
1.7.9.5
Tony Prisk
NAKQuoted 64 lines · Andrei Epure
Modified or added the necessary goto statements so that the ioremapped regions get unmapped before return.
Signed-off-by Andrei Epure <[email protected]>--- drivers/video/vt8500lcdfb.c | 7 ++++--- drivers/video/wm8505fb.c | 7 ++++--- 2 files changed, 8 insertions(+), 6 deletions(-)drivers/video/vt8500lcdfb.c +4
-3@@ -350,7 +350,7 @@ static int vt8500lcd_probe(struct platform_device *pdev)if (!np) {pr_err ("%s: No display description in Device Tree\n" , __func__); ret = -EINVAL ; - goto failed_free_res; + goto failed_free_io; }/* @@ -369,7 +369,7 @@ static int vt8500lcd_probe(struct platform_device *pdev) ret |=of_property_read_u32 (np,"bpp" , &bpp);if (ret) {pr_err ("%s: Unable to read display properties\n" , __func__); - goto failed_free_res; + goto failed_free_io; } of_mode.vmode =FB_VMODE_NONINTERLACED ;@@ -379,7 +379,8 @@ static int vt8500lcd_probe(struct platform_device *pdev) GFP_KERNEL);if (!fb_mem_virt) {pr_err ("%s: Failed to allocate framebuffer\n" , __func__); -return -ENOMEM ; + ret = -ENOMEM ; + goto failed_free_io; }; fbi->fb.fix.smem_start = fb_mem_phys;drivers/video/wm8505fb.c +2
-2@@ -332,7 +332,7 @@ static int wm8505fb_probe(struct platform_device *pdev)if (!np) {pr_err ("%s: No display description in Device Tree\n" , __func__); ret = -EINVAL ; - goto failed_free_res; + goto failed_free_io; }/* @@ -351,7 +351,7 @@ static int wm8505fb_probe(struct platform_device *pdev) ret |=of_property_read_u32 (np,"bpp" , &bpp);if (ret) {pr_err ("%s: Unable to read display properties\n" , __func__); - goto failed_free_res; + goto failed_free_io; } of_mode.vmode =FB_VMODE_NONINTERLACED ;
drivers/video/wm8505fb.c static int wm8505fb_probe(struct platform_device *pdev) · line 376
Quoted 9 lines
drivers/video/wm8505fb.c +2
-1@@ -369,7 +369,8 @@ static int wm8505fb_probe(struct platform_device *pdev) GFP_KERNEL);if (!fb_mem_virt) {pr_err ("%s: Failed to allocate framebuffer\n" , __func__); -return -ENOMEM ; + ret = -ENOMEM ; + goto failed_free_io; }; fbi->fb.var.xres_virtual = of_mode.xres;
NACK
Already have a patch queued up for this from Julia Lawall
Regards
Tony P