video: fix invalid free of devm_ allocated data
PATCH 1/1 video: fix invalid free of devm_ allocated data
The objects allocated by devm_* APIs are managed by devres and are freed when the device is detached. Hence there is no need to use kfree() explicitly. Patch found using coccinelle.
Signed-off-by Andrei Epure <[email protected]>
--- drivers/video/vt8500lcdfb.c | 3 --- drivers/video/wm8505fb.c | 3 --- 2 files changed, 6 deletions(-)
drivers/video/vt8500lcdfb.c +0 -3
@@ -465,7 +465,6 @@ failed_free_res:release_mem_region (res->start,resource_size (res)); failed_fbi:platform_set_drvdata (pdev,NULL ); -kfree (fbi); failed:return ret; }
@@ -494,8 +493,6 @@ static int vt8500lcd_remove(struct platform_device *pdev) res =platform_get_resource (pdev,IORESOURCE_MEM ,0 );release_mem_region (res->start,resource_size (res)); -kfree (fbi); -return 0 ; }
drivers/video/wm8505fb.c +0 -3
@@ -427,7 +427,6 @@ failed_free_res:release_mem_region (res->start,resource_size (res)); failed_fbi:platform_set_drvdata (pdev,NULL ); -kfree (fbi); failed:return ret; }
@@ -451,8 +450,6 @@ static int wm8505fb_remove(struct platform_device *pdev) res =platform_get_resource (pdev,IORESOURCE_MEM ,0 );release_mem_region (res->start,resource_size (res)); -kfree (fbi); -return 0 ; }
Signature · 1 line
1.7.9.5
Tony Prisk
NAKQuoted 44 lines · Andrei Epure
The objects allocated by devm_* APIs are managed by devres and are freed when the device is detached. Hence there is no need to use
kfree()explicitly. Patch found using coccinelle.Signed-off-by Andrei Epure <[email protected]>--- drivers/video/vt8500lcdfb.c | 3 --- drivers/video/wm8505fb.c | 3 --- 2 files changed, 6 deletions(-)drivers/video/vt8500lcdfb.c +0
-3@@ -465,7 +465,6 @@ failed_free_res:release_mem_region (res->start,resource_size (res)); failed_fbi:platform_set_drvdata (pdev,NULL ); -kfree (fbi); failed:return ret; }@@ -494,8 +493,6 @@ static int vt8500lcd_remove(struct platform_device *pdev) res =platform_get_resource (pdev,IORESOURCE_MEM ,0 );release_mem_region (res->start,resource_size (res)); -kfree (fbi); -return 0 ; }drivers/video/wm8505fb.c +0
-1@@ -427,7 +427,6 @@ failed_free_res:release_mem_region (res->start,resource_size (res)); failed_fbi:platform_set_drvdata (pdev,NULL ); -kfree (fbi); failed:return ret; }
drivers/video/wm8505fb.c static int wm8505fb_remove(struct platform_device *pdev) · line 455
Quoted 8 lines
drivers/video/wm8505fb.c +0
-2@@ -451,8 +450,6 @@ static int wm8505fb_remove(struct platform_device *pdev) res =platform_get_resource (pdev,IORESOURCE_MEM ,0 );release_mem_region (res->start,resource_size (res)); -kfree (fbi); -return 0 ; }
NACK
Already have a patch queued up for this from Julia Lawall
Regards
Tony P