Skip to contentSkip to conversation

power: fix invalid free of devm_ allocated data

PATCH In review Andrei Epure 2 participants 2 messages Mar 28, 2013 – Apr 1, 2013

lore
Share & tools
lore
#0 lore raw

PATCH 21/21 power: fix invalid free of devm_ allocated data

The objects allocated by devm_* APIs are managed by devres and are freed when the device is detached. Hence there is no need to use kfree() explicitly. Patch found using coccinelle.

---
 drivers/power/88pm860x_charger.c |    2 --
 1 file changed, 2 deletions(-)
drivers/power/88pm860x_charger.c +0 -2
index 4b37a5a..36fb4b5 100644
@@ -714,7 +714,6 @@ out_irq:
 	while (--i >= 0)
 		free_irq(info->irq[i], info);
 out:
-	kfree(info);
 	return ret;
 }
 
@@ -728,7 +727,6 @@ static int pm860x_charger_remove(struct platform_device *pdev)
 	free_irq(info->irq[0], info);
 	for (i = 0; i < info->irq_nums; i++)
 		free_irq(info->irq[i], info);
-	kfree(info);
 	return 0;
 }
 
Signature · 1 line
1.7.9.5
#1 lore raw
Quoted 6 lines · Andrei Epure

The objects allocated by devm_* APIs are managed by devres and are freed when the device is detached. Hence there is no need to use kfree() explicitly. Patch found using coccinelle.

---

Jingoo Han sent a similar change ealier... but thanks anyway!

Anton