Skip to contentSkip to conversation

memory: reverse the priority when commit

PATCH In review Liu Ping Fan 3 participants 3 messages Mar 28, 2013 – Mar 29, 2013

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 memory: reverse the priority when commit

In theroy, the high priority should commit earlier, it is the same reason as the sequence of "Lower = earlier (during add), later (during del)"

---
 memory.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
memory.c +1 -1
index 75ca281..ecf1df3 100644
@@ -750,7 +750,7 @@ void memory_region_transaction_commit(void)
             address_space_update_topology(as);
         }
 
-        MEMORY_LISTENER_CALL_GLOBAL(commit, Forward);
+        MEMORY_LISTENER_CALL_GLOBAL(commit, Reverse);
     }
 }
 
Signature · 1 line
1.7.4.4
#1 lore raw
Quoted 2 lines · Liu Ping Fan

In theroy, the high priority should commit earlier, it is the same reason as the sequence of "Lower = earlier (during add), later (during del)"

Hi. Could you give a bit more detail about the reason for this change, please? Do any of our existing commit hooks currently care about the order in which they're called (ie is this fixing a bug), or is there some use case that would care in future?

This change may well be right but it's not immediately obvious that begin/commit are a paired set in the same way as (say) add/del and log_start/log_stop, so more rationale would be helpful.

thanks
-- PMM

#2 lore raw
Quoted 9 lines · Peter Maydell
Quoted 2 lines · Liu Ping Fan

In theroy, the high priority should commit earlier, it is the same reason as the sequence of "Lower = earlier (during add), later (during del)"

Hi. Could you give a bit more detail about the reason for this change, please? Do any of our existing commit hooks currently care about the order in which they're called (ie is this fixing a bug), or is there some use case that would care in future?

Quoted 5 lines

This change may well be right but it's not immediately obvious that begin/commit are a paired set in the same way as (say) add/del and log_start/log_stop, so more rationale would be helpful.

Each componet (core, kvm,vhost) should have different priority to see the change of the memory layout, for they are async. But oh, here seems that I make a mistake, the sequence of commit has already make high priority first.

Regards,
Pingfan

Quoted 3 lines

thanks
-- PMM