pinctrl: coh901: Fix error checking in u300_gpio_to_irq
PATCH 1/1 pinctrl: coh901: Fix error checking in u300_gpio_to_irq
The pointer "port" is always not NULL if gpio->port_list is not empty.
Signed-off-by Axel Lin <[email protected]>
--- drivers/pinctrl/pinctrl-coh901.c | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-)
drivers/pinctrl/pinctrl-coh901.c +5 -2
@@ -318,13 +318,16 @@ static int u300_gpio_to_irq(struct gpio_chip *chip, unsigned offset)struct u300_gpio_port *port =NULL ;struct list_head *p;int retirq; +bool found = false;list_for_each (p, &gpio->port_list) { port = list_entry(p, struct u300_gpio_port, node); -if (port->number == portno) +if (port->number == portno) { + found = true;break ; + } } -if (port ==NULL ) { +if (!found) {dev_err (gpio->dev,"could not locate port for GPIO %d IRQ\n" , offset);return -EINVAL ;
Signature · 1 line
1.7.10.4
Quoted 3 lines · Axel Lin
The pointer "port" is always not NULL if
gpio->port_listis not empty.Signed-off-by Axel Lin <[email protected]>
Excellent catch Axel, thanks!!
Patch applied.
Yours,
Linus Walleij