ARM: perf: fix group validation when using enable_on_exec
Subsystems (3)
PATCH 1/1 ARM: perf: fix group validation when using enable_on_exec
Events may be created with attr->disabled == 1 and attr->enable_on_exec == 1, which confuses the group validation code because events with the PERF_EVENT_STATE_OFF are not considered candidates for scheduling, which may lead to failure at group scheduling time.
This patch fixes the validation check for ARM, so that events in the OFF state are still considered when enable_on_exec is true.
Cc Peter Zijlstra <[email protected]>
Cc Arnaldo Carvalho de Melo <[email protected]>
Cc Jiri Olsa <[email protected]>
Reported-by Sudeep KarkadaNagesha <[email protected]>
Signed-off-by Will Deacon <[email protected]>
---
CC'ing some of the core guys here because I think this affects multiple (all?) architectures.
arch/arm/kernel/perf_event.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-)
arch/arm/kernel/perf_event.c +4 -1
@@ -253,7 +253,10 @@ validate_event(struct pmu_hw_events *hw_events,struct arm_pmu *armpmu =to_arm_pmu (event->pmu);struct pmu *leader_pmu = event->group_leader->pmu; -if (event->pmu != leader_pmu || event->state <=PERF_EVENT_STATE_OFF ) +if (event->pmu != leader_pmu || event->state <PERF_EVENT_STATE_OFF ) +return 1 ; + +if (event->state ==PERF_EVENT_STATE_OFF && !event->attr.enable_on_exec)return 1 ;return armpmu->get_event_idx (hw_events, event) >=0 ;
Signature · 1 line
1.8.0