Skip to contentSkip to conversation

Avoid unnecessary calls to sandybridge mce decoder on incompatible platform

PATCH New Khalid Aziz 1 participant 1 message Mar 29, 2013

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 Avoid unnecessary calls to sandybridge mce decoder on incompatible platform

Add MCE decoder to MCE decode chain in probe routine instead of in init routine so that handler is not called unless the driver is indeed running on SandyBridge.

---
 drivers/edac/sb_edac.c |    5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)
drivers/edac/sb_edac.c +2 -3
index 57244f9..6f05ffd 100644
@@ -1724,6 +1724,7 @@ static int sbridge_probe(struct pci_dev *pdev, const struct pci_device_id *id)
 			goto fail1;
 	}
 
+	mce_register_decode_chain(&sbridge_mce_dec);
 	sbridge_printk(KERN_INFO, "Driver loaded.\n");
 
 	mutex_unlock(&sbridge_edac_lock);
@@ -1803,10 +1804,8 @@ static int __init sbridge_init(void)
 
 	pci_rc = pci_register_driver(&sbridge_driver);
 
-	if (pci_rc >= 0) {
-		mce_register_decode_chain(&sbridge_mce_dec);
+	if (pci_rc >= 0)
 		return 0;
-	}
 
 	sbridge_printk(KERN_ERR, "Failed to register device with error %d.\n",
 		      pci_rc);
Signature · 1 line
1.7.10.4