Skip to contentSkip to conversation

pcmciautils: Correct definition of PCMCIAUTILS_VERSION to avoid segmentation fault

PATCH In review Takeshi Hamasaki 2 participants 3 messages Mar 31, 2013 – Apr 1, 2013

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 pcmciautils: Correct definition of PCMCIAUTILS_VERSION to avoid segmentation fault

This is to fix segmentation fault from pccardctl command. -DPCMCIAUTILS_VERSION=\'${PV}\' passes PCMCIAUILTS_VERSION to compiler as a multi-character constant, not a string.

---
 meta/recipes-bsp/pcmciautils/pcmciautils.inc |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
meta/recipes-bsp/pcmciautils/pcmciautils.inc +1 -1
index 80271d6..0651236 100644
@@ -21,7 +21,7 @@ export udevrulesdir = "${nonarch_base_libdir}/udev/rules.d"
 export UDEV = "1"
 LD = "${CC}"
 CFLAGS =+ "-I${S}/src"
-CFLAGS =+ "-DPCMCIAUTILS_VERSION=\'${PV}\'"
+CFLAGS =+ "-DPCMCIAUTILS_VERSION=\\"${PV}\\""
 
 PARALLEL_MAKE = ""
 EXTRA_OEMAKE = "-e 'STRIP=echo' 'LIB_OBJS=-lc -lsysfs' 'LEX=flex'"
Signature · 1 line
1.7.10.4
#1 lore raw
Quoted 3 lines · Takeshi Hamasaki

This is to fix segmentation fault from pccardctl command. -DPCMCIAUTILS_VERSION=\'${PV}\' passes PCMCIAUILTS_VERSION to compiler as a multi-character constant, not a string.

oe-core patches need to go to
[email protected]

please resend

Quoted 26 lines
---
 meta/recipes-bsp/pcmciautils/pcmciautils.inc |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
meta/recipes-bsp/pcmciautils/pcmciautils.inc +1 -1
index 80271d6..0651236 100644
@@ -21,7 +21,7 @@ export udevrulesdir = "${nonarch_base_libdir}/udev/rules.d"
 export UDEV = "1"
 LD = "${CC}"
 CFLAGS =+ "-I${S}/src"
-CFLAGS =+ "-DPCMCIAUTILS_VERSION=\'${PV}\'"
+CFLAGS =+ "-DPCMCIAUTILS_VERSION=\\"${PV}\\""
 
 PARALLEL_MAKE = ""
 EXTRA_OEMAKE = "-e 'STRIP=echo' 'LIB_OBJS=-lc -lsysfs' 'LEX=flex'"
Signature · 7 lines
1.7.10.4


_______________________________________________
Openembedded-devel mailing list
[email protected]
http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-devel
Signature · 1 line
Martin 'JaMa' Jansa     jabber: [email protected]