Skip to contentSkip to conversation

mmc: mxcmmc: DT support

PATCH New Markus Pargmann 4 participants 5 messages Mar 25, 2013 – Apr 12, 2013

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH v2 1/1 mmc: mxcmmc: DT support

Adding devicetree support for imx21-mmc and imx31-mmc. Based on generic gpio helper functions by Guennadi and generic DMA devicetree bindings.

Cc Anatolij Gustschin <[email protected]>

---

Notes:
Changes in v2:
- Documentation fix
- Use dma_request_slave_channel instead of of_*

 .../devicetree/bindings/mmc/fsl-imx-mmc.txt        | 24 +++++++
 drivers/mmc/host/mxcmmc.c                          | 79 +++++++++++++++++-----
 2 files changed, 85 insertions(+), 18 deletions(-)
 create mode 100644 Documentation/devicetree/bindings/mmc/fsl-imx-mmc.txt
Documentation/devicetree/bindings/mmc/fsl-imx-mmc.txt new file +24 -0
new file mode 100644
index 0000000..db44235
@@ -0,0 +1,24 @@
+* Freescale Secure Digital Host Controller for i.MX2/3 series
+
+This file documents differences to the properties defined in mmc.txt.
+
+Required properties:
+- compatible : Should be "fsl,<chip>-mmc", chip can be imx21 or imx31
+
+Optional properties:
+- dmas: One DMA phandle with arguments as defined by the devicetree bindings
+	of the used DMA controller.
+- dma-names: Has to be "rx-tx".
+
+Example:
+
+sdhci1: sdhci at 10014000 {
+	compatible = "fsl,imx27-mmc", "fsl,imx21-mmc";
+	reg = <0x10014000 0x1000>;
+	interrupts = <11>;
+	dmas = <&dma 7>;
+	dma-names = "rx-tx";
+	bus-width = <4>;
+	cd-gpios = <&gpio3 29>;
+	status = "okay";
+};
drivers/mmc/host/mxcmmc.c +61 -18

132 lines not on this page · raw message

Signature · 1 line
1.8.1.5
#1 lore raw

PATCH v3 1/1 mmc: mxcmmc: DT support

From: Markus Pargmann <[email protected]>

Adding devicetree support for imx21-mmc and imx31-mmc. Based on generic gpio helper functions by Guennadi and generic DMA devicetree bindings.

---

Notes:
Changes in v3:
- fix first argument of dma_request_slave_channel(), it should be a pointer to struct device
Changes in v2:
- Documentation fix
- Use dma_request_slave_channel instead of of_*

 .../devicetree/bindings/mmc/fsl-imx-mmc.txt        |   24 ++++++
 drivers/mmc/host/mxcmmc.c                          |   79 +++++++++++++++-----
 2 files changed, 85 insertions(+), 18 deletions(-)
 create mode 100644 Documentation/devicetree/bindings/mmc/fsl-imx-mmc.txt
Documentation/devicetree/bindings/mmc/fsl-imx-mmc.txt new file +24 -0
new file mode 100644
index 0000000..db44235
@@ -0,0 +1,24 @@
+* Freescale Secure Digital Host Controller for i.MX2/3 series
+
+This file documents differences to the properties defined in mmc.txt.
+
+Required properties:
+- compatible : Should be "fsl,<chip>-mmc", chip can be imx21 or imx31
+
+Optional properties:
+- dmas: One DMA phandle with arguments as defined by the devicetree bindings
+	of the used DMA controller.
+- dma-names: Has to be "rx-tx".
+
+Example:
+
+sdhci1: sdhci at 10014000 {
+	compatible = "fsl,imx27-mmc", "fsl,imx21-mmc";
+	reg = <0x10014000 0x1000>;
+	interrupts = <11>;
+	dmas = <&dma 7>;
+	dma-names = "rx-tx";
+	bus-width = <4>;
+	cd-gpios = <&gpio3 29>;
+	status = "okay";
+};
drivers/mmc/host/mxcmmc.c +61 -18

132 lines not on this page · raw message

Signature · 1 line
1.7.5.4
#2 lore raw

PATCH v3 1/1 mmc: mxcmmc: DT support

Hi,

Quoted 7 lines · Anatolij Gustschin

From: Markus Pargmann <[email protected]>

Adding devicetree support for imx21-mmc and imx31-mmc. Based on generic gpio helper functions by Guennadi and generic DMA devicetree bindings.

Sascha, Arnd, perhaps one of you could review this? There's another patchset waiting on it.

Thanks!

- Chris.

Signature · 2 lines
Chris Ball   <[email protected]>   <http://printf.net/>
One Laptop Per Child
#4 lore raw

PATCH v3 1/1 mmc: mxcmmc: DT support

Hi,

Quoted 11 lines · Arnd Bergmann
Quoted 8 lines · Anatolij Gustschin

From: Markus Pargmann <[email protected]>

Adding devicetree support for imx21-mmc and imx31-mmc. Based on generic gpio helper functions by Guennadi and generic DMA devicetree bindings.

Thanks! Pushed to mmc-next for 3.10.

- Chris.

Signature · 2 lines
Chris Ball   <[email protected]>   <http://printf.net/>
One Laptop Per Child