Skip to contentSkip to conversation

Remove obsolete, iSeries specific, Makefile lines

PATCH In review Paul Bolle 2 participants 3 messages Mar 29, 2013 – Apr 1, 2013

Subsystems (2)
lore
Share & tools
lore

Paul Bolle

author
#0 lore raw

PATCH 1/1 Remove obsolete, iSeries specific, Makefile lines

---
0) Entirely untested.

1) See commit 3d066d77cf464ea1e47808f95243301fd2175a7f ("powerpc: remove CONFIG_PPC_ISERIES from the architecture Kconfig files") and commit ba7a4822b48fbc7afd6b567c18e316a03f46684d ("powerpc: Remove some of the legacy iSeries specific device drivers").

 drivers/block/Makefile | 1 -
 drivers/cdrom/Makefile | 1 -
 drivers/char/Makefile  | 1 -
 3 files changed, 3 deletions(-)
drivers/block/Makefile +0 -1
index a3b4023..ebb3a61 100644
@@ -30,7 +30,6 @@ obj-$(CONFIG_BLK_DEV_NBD)	+= nbd.o
 obj-$(CONFIG_BLK_DEV_CRYPTOLOOP) += cryptoloop.o
 obj-$(CONFIG_VIRTIO_BLK)	+= virtio_blk.o
 
-obj-$(CONFIG_VIODASD)		+= viodasd.o
 obj-$(CONFIG_BLK_DEV_SX8)	+= sx8.o
 obj-$(CONFIG_BLK_DEV_HD)	+= hd.o
 
drivers/cdrom/Makefile +0 -1
index ecf85fd..8ffde4f 100644
@@ -10,5 +10,4 @@ obj-$(CONFIG_BLK_DEV_SR)	+=              cdrom.o
 obj-$(CONFIG_PARIDE_PCD)	+=		cdrom.o
 obj-$(CONFIG_CDROM_PKTCDVD)	+=		cdrom.o
 
-obj-$(CONFIG_VIOCD)		+= viocd.o      cdrom.o
 obj-$(CONFIG_GDROM)		+= gdrom.o      cdrom.o
drivers/char/Makefile +0 -1
index 7ff1d0d..290fe5b 100644
@@ -13,7 +13,6 @@ obj-$(CONFIG_MSM_SMD_PKT)	+= msm_smd_pkt.o
 obj-$(CONFIG_MSPEC)		+= mspec.o
 obj-$(CONFIG_MMTIMER)		+= mmtimer.o
 obj-$(CONFIG_UV_MMTIMER)	+= uv_mmtimer.o
-obj-$(CONFIG_VIOTAPE)		+= viotape.o
 obj-$(CONFIG_IBM_BSR)		+= bsr.o
 obj-$(CONFIG_SGI_MBCS)		+= mbcs.o
 obj-$(CONFIG_BFIN_OTP)		+= bfin-otp.o
Signature · 1 line
1.7.11.7
#1 lore raw
Quoted 8 lines · Paul Bolle

---
0) Entirely untested.

1) See commit 3d066d77cf464ea1e47808f95243301fd2175a7f ("powerpc: remove CONFIG_PPC_ISERIES from the architecture Kconfig files") and commit ba7a4822b48fbc7afd6b567c18e316a03f46684d ("powerpc: Remove some of the legacy iSeries specific device drivers").

I believe you could remove all the corresponding major number defines from include/uapi/linux/major.h while you are at it.

Thanks,

Signature · 2 lines
Jiri Kosina
SUSE Labs
author
#2 lore raw
Quoted 2 lines · Jiri Kosina

I believe you could remove all the corresponding major number defines from include/uapi/linux/major.h while you are at it.

0) You seem to mean these:

    $ grep VIO include/uapi/linux/major.h
    #define VIODASD_MAJOR		112
    #define VIOCD_MAJOR		113
    #define VIOTAPE_MAJOR		230

They are indeed unused. But are they safe to be removed? I'm always very cautious with touching magic numbers, and the like (even obsolete).

1) Anyhow, if they really can be removed, I prefer to do that in a separate patch.

Paul Bolle