commands/tftp: use pr_debug for debug output
PATCH 1/1 commands/tftp: use pr_debug for debug output
--- commands/tftp.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
commands/tftp.c +1 -1
@@ -76,7 +76,7 @@ static int do_tftpb(int argc, char *argv[])if (ret) goto err_rmdir; -printk ("%s: %s -> %s\n" , __func__, source, dest); +pr_debug ("%s: %s -> %s\n" , __func__, source, dest); ret =copy_file (source, dest,1 );
Signature · 7 lines
1.8.1.3 _______________________________________________ barebox mailing list [email protected] http://lists.infradead.org/mailman/listinfo/barebox
Quoted 10 lines · Hubert Feurstein
Signed-off-by Hubert Feurstein <[email protected]>--- commands/tftp.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)commands/tftp.c +0
-0
commands/tftp.c static int do_tftpb(int argc, char *argv[]) · line 79
Quoted 5 lines
commands/tftp.c +1
-1@@ -76,7 +76,7 @@ static int do_tftpb(int argc, char *argv[])if (ret) goto err_rmdir; -printk ("%s: %s -> %s\n" , __func__, source, dest); +pr_debug ("%s: %s -> %s\n" , __func__, source, dest);
no pr_ is for device/driver not commands
use debug
Best Regards,
J.
_______________________________________________
barebox mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/barebox
Quoted 14 lines · Jean-Christophe PLAGNIOL-VILLARD
Quoted 13 lines · Hubert Feurstein
Signed-off-by Hubert Feurstein <[email protected]>--- commands/tftp.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)commands/tftp.c +0
-0@@ -76,7 +76,7 @@ static int do_tftpb(int argc, char *argv[])if (ret) goto err_rmdir;
Quoted 3 lines
commands/tftp.c static int do_tftpb(int argc, char *argv[]) · line 79
Quoted 2 lines
commands/tftp.c +1
-1-printk ("%s: %s -> %s\n" , __func__, source, dest); +pr_debug ("%s: %s -> %s\n" , __func__, source, dest);no
pr_is for device/driver not commands
Saying what he should use instead is probably very helpful.
Sascha
Signature · 9 lines
Pengutronix e.K. | | Industrial Linux Solutions | http://www.pengutronix.de/ | Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 | _______________________________________________ barebox mailing list [email protected] http://lists.infradead.org/mailman/listinfo/barebox
Quoted 15 lines · Sascha Hauer
Quoted 14 lines · Jean-Christophe PLAGNIOL-VILLARD
Quoted 13 lines · Hubert Feurstein
Signed-off-by Hubert Feurstein <[email protected]>--- commands/tftp.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)commands/tftp.c +0
-0@@ -76,7 +76,7 @@ static int do_tftpb(int argc, char *argv[])if (ret) goto err_rmdir;
Quoted 5 lines
Quoted 3 lines
commands/tftp.c static int do_tftpb(int argc, char *argv[]) · line 79
Quoted 2 lines
commands/tftp.c +1
-1-printk ("%s: %s -> %s\n" , __func__, source, dest); +pr_debug ("%s: %s -> %s\n" , __func__, source, dest);no
pr_is for device/driver not commandsSaying what he should use instead is probably very helpful.
which I did
use debug
Best Regards,
J.
Quoted 8 lines
Sascha
Signature · 4 lines
Pengutronix e.K. | | Industrial Linux Solutions | http://www.pengutronix.de/ | Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
_______________________________________________
barebox mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/barebox
PATCH v2 1/1 commands/tftp: use debug() for debug output
In reply to Jean-Christophe PLAGNIOL-VILLARD--- commands/tftp.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
commands/tftp.c +1 -1
@@ -76,7 +76,7 @@ static int do_tftpb(int argc, char *argv[])if (ret) goto err_rmdir; -printk ("%s: %s -> %s\n" , __func__, source, dest); +debug ("%s: %s -> %s\n" , __func__, source, dest); ret =copy_file (source, dest,1 );
Signature · 7 lines
1.8.1.3 _______________________________________________ barebox mailing list [email protected] http://lists.infradead.org/mailman/listinfo/barebox
Sascha Hauer
AppliedRe: [PATCH v2] commands/tftp: use debug() for debug output
Quoted 1 line · Hubert Feurstein
Signed-off-by Hubert Feurstein <[email protected]>
Applied, thanks
Sascha
Quoted 26 lines
--- commands/tftp.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)commands/tftp.c +1
-1@@ -76,7 +76,7 @@ static int do_tftpb(int argc, char *argv[])if (ret) goto err_rmdir; -printk ("%s: %s -> %s\n" , __func__, source, dest); +debug ("%s: %s -> %s\n" , __func__, source, dest); ret =copy_file (source, dest,1 );Signature · 7 lines
1.8.1.3 _______________________________________________ barebox mailing list [email protected] http://lists.infradead.org/mailman/listinfo/barebox
Signature · 9 lines
Pengutronix e.K. | | Industrial Linux Solutions | http://www.pengutronix.de/ | Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 | _______________________________________________ barebox mailing list [email protected] http://lists.infradead.org/mailman/listinfo/barebox