ARM: tegra: cpuidle: remove redundant parameters for powered-down mode
Subsystems (3)
PATCH v3 1/1 ARM: tegra: cpuidle: remove redundant parameters for powered-down mode
After the patch series for system suspending support, tegra_idle_lp2_last() no longer uses its parameters cpu_on_time or cpu_off_time, so remove them.
---
V3:
* no change
V2:
* rebased on the top of "ARM: tegra: add clock source for PMC" and "ARM:
tegra: add platform suspend support"
* no physical change from V1
--- arch/arm/mach-tegra/cpuidle-tegra20.c | 6 +----- arch/arm/mach-tegra/cpuidle-tegra30.c | 6 +----- arch/arm/mach-tegra/pm.c | 2 +- arch/arm/mach-tegra/pm.h | 2 +- 4 files changed, 4 insertions(+), 12 deletions(-)
arch/arm/mach-tegra/cpuidle-tegra20.c +1 -5
@@ -130,10 +130,6 @@ static bool tegra20_cpu_cluster_power_down(struct cpuidle_device *dev, struct cpuidle_driver *drv, int index) { -struct cpuidle_state *state = &drv->states[index]; -u32 cpu_on_time = state->exit_latency; -u32 cpu_off_time = state->target_residency - state->exit_latency; - while (tegra20_cpu_is_resettable_soon()) cpu_relax();
@@ -142,7 +138,7 @@ static bool tegra20_cpu_cluster_power_down(struct cpuidle_device *dev,clockevents_notify (CLOCK_EVT_NOTIFY_BROADCAST_ENTER , &dev->cpu); -tegra_idle_lp2_last (cpu_on_time, cpu_off_time); +tegra_idle_lp2_last ();clockevents_notify (CLOCK_EVT_NOTIFY_BROADCAST_EXIT , &dev->cpu);
arch/arm/mach-tegra/cpuidle-tegra30.c +1 -5
@@ -72,10 +72,6 @@ static bool tegra30_cpu_cluster_power_down(struct cpuidle_device *dev,struct cpuidle_driver *drv, int index) { -struct cpuidle_state *state = &drv->states[index]; -u32 cpu_on_time = state->exit_latency; -u32 cpu_off_time = state->target_residency - state->exit_latency; -/* All CPUs entering LP2 is not working. * Don't let CPU0 enter LP2 when any secondary CPU is online. */
@@ -86,7 +82,7 @@ static bool tegra30_cpu_cluster_power_down(struct cpuidle_device *dev,clockevents_notify (CLOCK_EVT_NOTIFY_BROADCAST_ENTER , &dev->cpu); -tegra_idle_lp2_last (cpu_on_time, cpu_off_time); +tegra_idle_lp2_last ();clockevents_notify (CLOCK_EVT_NOTIFY_BROADCAST_EXIT , &dev->cpu);
arch/arm/mach-tegra/pm.c +1 -1
@@ -135,7 +135,7 @@ static int tegra_sleep_cpu(unsigned long v2p)return 0 ; } -void tegra_idle_lp2_last (u32 cpu_on_time,u32 cpu_off_time) +void tegra_idle_lp2_last (void ) {tegra_pmc_pm_set (TEGRA_SUSPEND_LP2 );
arch/arm/mach-tegra/pm.h +1 -1
@@ -31,7 +31,7 @@ void restore_cpu_arch_register(void);void tegra_clear_cpu_in_lp2 (int phy_cpu_id);bool tegra_set_cpu_in_lp2 (int phy_cpu_id); -void tegra_idle_lp2_last (u32 cpu_on_time,u32 cpu_off_time); +void tegra_idle_lp2_last (void );extern void (*tegra_tear_down_cpu)(void );#ifdef CONFIG_PM_SLEEP
Signature · 1 line
1.8.2
PATCH v3 1/1 ARM: tegra: cpuidle: remove redundant parameters for powered-down mode
Quoted 2 lines · Joseph Lo
After the patch series for system suspending support,
tegra_idle_lp2_last()no longer uses its parameterscpu_on_timeorcpu_off_time, so remove them.
This looks fine; I can apply it after I've applied the other two series you posted.
Stephen Warren
AppliedPATCH v3 1/1 ARM: tegra: cpuidle: remove redundant parameters for powered-down mode
In reply to Joseph LoQuoted 2 lines · Joseph Lo
After the patch series for system suspending support,
tegra_idle_lp2_last()no longer uses its parameterscpu_on_timeorcpu_off_time, so remove them.
Applied to Tegra's for-3.10/soc branch.