video: mxsfb: Use of_get_display_gpio_enable()
Subsystems (2)
Fabio Estevam
reviewerPATCH v2 2/2 video: mxsfb: Use of_get_display_gpio_enable()
From: Fabio Estevam <[email protected]>
Use of_get_display_gpio_enable() helper to retrieve the GPIO from devicetree that turns on the display.
This lets the code smaller and cleaner.
Signed-off-by Fabio Estevam <[email protected]>
---
Changes since v1:
- No changes
drivers/video/Kconfig | 1 + drivers/video/mxsfb.c | 21 ++++----------------- 2 files changed, 5 insertions(+), 17 deletions(-)
drivers/video/Kconfig +1 -0
@@ -2445,6 +2445,7 @@ config FB_MXS select FB_CFB_IMAGEBLIT select FB_MODE_HELPERS select OF_VIDEOMODE + select OF_DISPLAY_ENABLE_GPIO help Framebuffer support for the MXS SoC.
drivers/video/mxsfb.c +4 -17
@@ -51,6 +51,7 @@#include <linux/pinctrl/consumer.h> #include <linux/fb.h> #include <video/videomode.h> +#include <video/of_display_gpio.h> #define REG_SET 4#define REG_CLR 8
@@ -859,8 +860,6 @@ static int mxsfb_probe(struct platform_device *pdev)struct fb_info *fb_info;struct fb_modelist *modelist;struct pinctrl *pinctrl; -int panel_enable; -enum of_gpio_flags flags;int ret;if (of_id)
@@ -904,21 +903,9 @@ static int mxsfb_probe(struct platform_device *pdev) goto fb_release; } - panel_enable =of_get_named_gpio_flags (pdev->dev.of_node, -"panel-enable-gpios" ,0 , &flags); -if (gpio_is_valid (panel_enable)) { -unsigned long f =GPIOF_OUT_INIT_HIGH ; -if (flags =OF_GPIO_ACTIVE_LOW ) - f =GPIOF_OUT_INIT_LOW ; - ret =devm_gpio_request_one (&pdev->dev, panel_enable, - f,"panel-enable" ); -if (ret) { -dev_err (&pdev->dev, -"failed to request gpio %d: %d\n" , - panel_enable, ret); - goto fb_release; - } - } + ret =of_get_display_gpio_enable (pdev); +if (ret) + goto fb_release; fb_info->pseudo_palette =devm_kzalloc (&pdev->dev,sizeof (u32) *16 ,GFP_KERNEL );
Signature · 1 line
1.7.9.5
Dear Fabio Estevam,
Quoted 8 lines
From: Fabio Estevam <[email protected]>
Use
of_get_display_gpio_enable()helper to retrieve the GPIO from devicetree that turns on the display.This lets the code smaller and cleaner.
Signed-off-by Fabio Estevam <[email protected]>
Looks ok,
Reviewed-by Marek Vasut <[email protected]>
Best regards,
Marek Vasut