Skip to contentSkip to conversation

poky.conf: Use weaker assignment for PREMIRROR

PATCH In review Khem Raj 2 participants 5 messages Apr 3, 2013

lore
Share & tools
lore

Khem Raj

author
#0 lore raw

PATCH 1/1 poky.conf: Use weaker assignment for PREMIRROR

This is to facilitate distros using poky as reference so that they can use ?= and provide an option for their users to override it if desired

---
 meta-yocto/conf/distro/poky.conf |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
meta-yocto/conf/distro/poky.conf +1 -1
index afe328b..963b3dd 100644
@@ -44,7 +44,7 @@ TCLIBCAPPEND = ""
 QEMU_TARGETS ?= "arm i386 mips mipsel ppc x86_64"
 # Other QEMU_TARGETS "mips64 mips64el sh4"
 
-PREMIRRORS ?= "\
+PREMIRRORS ??= "\
 bzr://.*/.*   http://downloads.yoctoproject.org/mirror/sources/ \n \
 cvs://.*/.*   http://downloads.yoctoproject.org/mirror/sources/ \n \
 git://.*/.*   http://downloads.yoctoproject.org/mirror/sources/ \n \
Signature · 1 line
1.7.9.5
#1 lore raw
Quoted 14 lines · On Tuesday 02 April 2013 22:11:50 Khem Raj wrote:

This is to facilitate distros using poky as reference so that they can use ?= and provide an option for their users to override it if desired

---
 meta-yocto/conf/distro/poky.conf |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
(quoted diff) +0 -0

b/meta-yocto/conf/distro/poky.conf index afe328b..963b3dd 100644

meta-yocto/conf/distro/poky.conf TCLIBCAPPEND = "" · line 50

Quoted 8 lines
meta-yocto/conf/distro/poky.conf +1 -1
@@ -44,7 +44,7 @@ TCLIBCAPPEND = ""
 QEMU_TARGETS ?= "arm i386 mips mipsel ppc x86_64"
 # Other QEMU_TARGETS "mips64 mips64el sh4"
 
-PREMIRRORS ?= "\
+PREMIRRORS ??= "\
 bzr://.*/.*   http://downloads.yoctoproject.org/mirror/sources/ \n \
 cvs://.*/.*   http://downloads.yoctoproject.org/mirror/sources/ \n \
 git://.*/.*   http://downloads.yoctoproject.org/mirror/sources/ \n \

I'm not sure this is a path we should be going down; potentially we could end up having to use ??= for just about everything.

Wouldn't you be better off using your own separate distro config (perhaps copying poky.conf instead of "require"ing it) and then the user can just set it with "=" ?

Cheers,
Paul

Signature · 2 lines
Paul Eggleton
Intel Open Source Technology Centre
author
#2 lore raw
Quoted 3 lines · Paul Eggleton

I'm not sure this is a path we should be going down; potentially we could end up having to use ??= for just about everything.

whats is downside of using ??= instead of ?=

Quoted 3 lines

Wouldn't you be better off using your own separate distro config (perhaps copying poky.conf instead of "require"ing it) and then the user can just set it with "=" ?

yes. however you are then always on lookout for changes happening in poky policies then you need to mimic in your distro config

#3 lore raw
Quoted 1 line · On Tuesday 02 April 2013 23:44:06 Khem Raj wrote:

On Apr 2, 2013, at 11:41 PM, Paul Eggleton <[email protected]>

Quoted 4 lines · wrote:
Quoted 2 lines

I'm not sure this is a path we should be going down; potentially we could end up having to use ??= for just about everything.

whats is downside of using ??= instead of ?=

The volume of changes to the config that this will require, a minor memory usage increase (I suspect), but more importantly it increases the complexity for the end user. Right now ??= is used sparingly.

Quoted 6 lines
Quoted 3 lines

Wouldn't you be better off using your own separate distro config (perhaps copying poky.conf instead of "require"ing it) and then the user can just set it with "=" ?

yes. however you are then always on lookout for changes happening in poky policies then you need to mimic in your distro config

Wouldn't it be the reverse at the moment? We do add new things to the poky distro config when we need to test them and those new things might not be desirable in your configuration.

Distro configs should remain fairly static once initially set. FWIW, we do call out any needed changes between releases in the migration information within the documentation.

Cheers,
Paul

Signature · 2 lines
Paul Eggleton
Intel Open Source Technology Centre
author
#4 lore raw
Quoted 19 lines · Paul Eggleton
Quoted 1 line · On Tuesday 02 April 2013 23:44:06 Khem Raj wrote:

On Apr 2, 2013, at 11:41 PM, Paul Eggleton <[email protected]>

Quoted 4 lines · wrote:
Quoted 2 lines

I'm not sure this is a path we should be going down; potentially we could end up having to use ??= for just about everything.

whats is downside of using ??= instead of ?=

The volume of changes to the config that this will require, a minor memory usage increase (I suspect), but more importantly it increases the complexity for the end user. Right now ??= is used sparingly.

Quoted 4 lines
Quoted 3 lines

Wouldn't you be better off using your own separate distro config (perhaps copying poky.conf instead of "require"ing it) and then the user can just set it with "=" ?

Quoted 7 lines
Quoted 2 lines

yes. however you are then always on lookout for changes happening in poky policies then you need to mimic in your distro config

Wouldn't it be the reverse at the moment? We do add new things to the poky distro config when we need to test them and those new things might not be desirable in your configuration.

no, if one is tracking upstream and wants to remain compatible its lot better to take in all policies and then customize it. and once released the policies are not changed anyway. Its easier to test and customize your distro that way since changes are incremental examples are when new QA checks are enabled you want to fix your own layers quickly and its one less hassle to keep syncing policies when your distro and you can get quicker response to fallouts if any. From personal experience including it has been a better way and indirectly is more integrated.

After all poky is a reference distro policy, whether we should recommend to copy it or include it in custom distros, either ways is fine with good reasons. You sound like supporting the second case, I am impartial to whatever is the recommendation there are good and bad of both approaches.

I am also interested in hearing from other yocto users how are they consuming poky policies

Quoted 1 line

Distro configs should remain fairly static once initially set.

after releases yes but not when you are building next gen which is for active development.

Quoted 3 lines

FWIW, we do call
out any needed changes between releases in the migration information within the documentation.

yes as I said once needs to sync.