lib/pciids: Sync pciid's with kernel commit 9b779ff
PATCH 1/1 lib/pciids: Sync pciid's with kernel commit 9b779ff
From: Shekhar Chauhan <[email protected]>
As per updated Bspec, Sync PCI IDs
Sync with the following kernel commits:
9b779ff ("drm/xe/xe2_hpg: Add PCI IDs for xe2_hpg") 49c6dc7 ("drm/xe/ptl: Update the PTL pci id table")
v1: Sync with kernel commit (Jani/Tejas)
v2: Specify both kernel commits in subject (Tejas)
--- lib/pciids.h | 11 +++++++++-- 1 file changed, 9 insertions(+), 2 deletions(-)
lib/pciids.h +9 -2
@@ -852,8 +852,11 @@ MACRO__(0xE210, ## __VA_ARGS__), \ MACRO__(0xE211, ## __VA_ARGS__), \ MACRO__(0xE212, ## __VA_ARGS__), \ - MACRO__(0xE215, ## __VA_ARGS__), \ - MACRO__(0xE216, ## __VA_ARGS__) + MACRO__(0xE216, ## __VA_ARGS__), \ + MACRO__(0xE220, ## __VA_ARGS__), \ + MACRO__(0xE221, ## __VA_ARGS__), \ + MACRO__(0xE222, ## __VA_ARGS__), \ + MACRO__(0xE223, ## __VA_ARGS__)/* PTL */ #define INTEL_PTL_IDS (MACRO__ , ...) \
@@ -861,6 +864,10 @@ MACRO__(0xB081, ## __VA_ARGS__), \ MACRO__(0xB082, ## __VA_ARGS__), \ MACRO__(0xB083, ## __VA_ARGS__), \ + MACRO__(0xB084, ## __VA_ARGS__), \ + MACRO__(0xB085, ## __VA_ARGS__), \ + MACRO__(0xB086, ## __VA_ARGS__), \ + MACRO__(0xB087, ## __VA_ARGS__), \ MACRO__(0xB08F, ## __VA_ARGS__), \ MACRO__(0xB090, ## __VA_ARGS__), \ MACRO__(0xB0A0, ## __VA_ARGS__), \
Signature · 1 line
2.25.1
Hi Kunal,
On 2025-06-23 at 19:02:57 +0530, Kunal Joshi wrote:
few nits about this for future, as this was merged already.
imho subject could be short, instead of:
[PATCH i-g-t] lib/pciids: Sync pciid's with kernel commit 9b779ff
simple one:
[PATCH i-g-t] lib/pciids: Sync with kernel
or little more explanatory when only few changed:
[PATCH i-g-t] lib/pciids: Update BMG and PTL pci ids
Reason for this short subject is that you will write details in patch description.
Quoted 1 line
From: Shekhar Chauhan <[email protected]>
imho this should be your 'From:' as you are porting this into IGT, especially when there will be more changes from different authors.
Quoted 6 lines
As per updated Bspec, Sync PCI IDs
Sync with the following kernel commits:
9b779ff ("drm/xe/xe2_hpg: Add PCI IDs forxe2_hpg") 49c6dc7 ("drm/xe/ptl: Update the PTL pci id table")
Please use more chars for SHA1 sum, at least 12 for now, as suggested by checkpatch.pl script from Linux kernel source.
Quoted 10 lines
v1: Sync with kernel commit (Jani/Tejas)
v2: Specify both kernel commits in subject (Tejas)Cc Jani Nikula <[email protected]>Cc Tejas Upadhyay <[email protected]>Signed-off-by Shekhar Chauhan <[email protected]>Signed-off-by Dnyaneshwar Bhadane <[email protected]>Signed-off-by Matt Roper <[email protected]>Signed-off-by Matt Atwood <[email protected]>
Where is your s-o-b?
Quoted 2 lines
Nice, thank you for providing links to lore.
Regards,
Kamil
Quoted 37 lines
Reviewed-by Tejas Upadhyay <[email protected]>--- lib/pciids.h | 11 +++++++++-- 1 file changed, 9 insertions(+), 2 deletions(-)lib/pciids.h +9
-2@@ -852,8 +852,11 @@ MACRO__(0xE210, ## __VA_ARGS__), \ MACRO__(0xE211, ## __VA_ARGS__), \ MACRO__(0xE212, ## __VA_ARGS__), \ - MACRO__(0xE215, ## __VA_ARGS__), \ - MACRO__(0xE216, ## __VA_ARGS__) + MACRO__(0xE216, ## __VA_ARGS__), \ + MACRO__(0xE220, ## __VA_ARGS__), \ + MACRO__(0xE221, ## __VA_ARGS__), \ + MACRO__(0xE222, ## __VA_ARGS__), \ + MACRO__(0xE223, ## __VA_ARGS__)/* PTL */ #define INTEL_PTL_IDS (MACRO__ , ...) \@@ -861,6 +864,10 @@ MACRO__(0xB081, ## __VA_ARGS__), \ MACRO__(0xB082, ## __VA_ARGS__), \ MACRO__(0xB083, ## __VA_ARGS__), \ + MACRO__(0xB084, ## __VA_ARGS__), \ + MACRO__(0xB085, ## __VA_ARGS__), \ + MACRO__(0xB086, ## __VA_ARGS__), \ + MACRO__(0xB087, ## __VA_ARGS__), \ MACRO__(0xB08F, ## __VA_ARGS__), \ MACRO__(0xB090, ## __VA_ARGS__), \ MACRO__(0xB0A0, ## __VA_ARGS__), \Signature · 1 line
2.25.1
Hello Kamil,
Quoted 41 lines · Kamil Konieczny
Hi Kunal,
On 2025-06-23 at 19:02:57 +0530, Kunal Joshi wrote:few nits about this for future, as this was merged already.
imho subject could be short, instead of:
[PATCH i-g-t] lib/pciids: Sync pciid's with kernel commit 9b779ff
simple one:
[PATCH i-g-t] lib/pciids: Sync with kernelor little more explanatory when only few changed:
[PATCH i-g-t] lib/pciids: Update BMG and PTL pci ids
Reason for this short subject is that you will write details in patch description.
Quoted 1 line
From: Shekhar Chauhan <[email protected]>
imho this should be your 'From:' as you are porting this into IGT, especially when there will be more changes from different authors.
Quoted 5 lines
As per updated Bspec, Sync PCI IDs
Sync with the following kernel commits:
9b779ff ("drm/xe/xe2_hpg: Add PCI IDs forxe2_hpg") 49c6dc7 ("drm/xe/ptl: Update the PTL pci id table")Please use more chars for SHA1 sum, at least 12 for now, as suggested by checkpatch.pl script from Linux kernel source.
Quoted 9 lines
v1: Sync with kernel commit (Jani/Tejas)
v2: Specify both kernel commits in subject (Tejas)Cc Jani Nikula <[email protected]>Cc Tejas Upadhyay <[email protected]>Signed-off-by Shekhar Chauhan <[email protected]>Signed-off-by Dnyaneshwar Bhadane <[email protected]>Signed-off-by Matt Roper <[email protected]>Signed-off-by Matt Atwood <[email protected]>
Quoted 8 lines
Where is your s-o-b?
Quoted 2 lines
Nice, thank you for providing links to lore.
Regards,
Kamil
Thanks for feedback even after merge,
Have noted all the points will take care from next time.
Thanks and Regards
Kunal Joshi
Quoted 37 lines
Quoted 37 lines
Reviewed-by Tejas Upadhyay <[email protected]>--- lib/pciids.h | 11 +++++++++-- 1 file changed, 9 insertions(+), 2 deletions(-)lib/pciids.h +9
-2@@ -852,8 +852,11 @@ MACRO__(0xE210, ## __VA_ARGS__), \ MACRO__(0xE211, ## __VA_ARGS__), \ MACRO__(0xE212, ## __VA_ARGS__), \ - MACRO__(0xE215, ## __VA_ARGS__), \ - MACRO__(0xE216, ## __VA_ARGS__) + MACRO__(0xE216, ## __VA_ARGS__), \ + MACRO__(0xE220, ## __VA_ARGS__), \ + MACRO__(0xE221, ## __VA_ARGS__), \ + MACRO__(0xE222, ## __VA_ARGS__), \ + MACRO__(0xE223, ## __VA_ARGS__)/* PTL */ #define INTEL_PTL_IDS (MACRO__ , ...) \@@ -861,6 +864,10 @@ MACRO__(0xB081, ## __VA_ARGS__), \ MACRO__(0xB082, ## __VA_ARGS__), \ MACRO__(0xB083, ## __VA_ARGS__), \ + MACRO__(0xB084, ## __VA_ARGS__), \ + MACRO__(0xB085, ## __VA_ARGS__), \ + MACRO__(0xB086, ## __VA_ARGS__), \ + MACRO__(0xB087, ## __VA_ARGS__), \ MACRO__(0xB08F, ## __VA_ARGS__), \ MACRO__(0xB090, ## __VA_ARGS__), \ MACRO__(0xB0A0, ## __VA_ARGS__), \Signature · 1 line
2.25.1
Patchwork
CI✗ Fi.CI.BAT: failure for lib/pciids: Sync pciid's with kernel commit 9b779ff (rev2)
In reply to Kunal Joshi== Series Details ==
== Series Details ==
Series: lib/pciids: Sync pciid's with kernel commit 9b779ff (rev2)
URL : https://patchwork.freedesktop.org/series/150597/
State : failure
== Summary ==
Series 150597 revision 2 was fully merged or fully failed: no git log