clk: mvebu: Fix valid value range checking for cpu_freq_select
Subsystems (2)
PATCH 1/1 clk: mvebu: Fix valid value range checking for cpu_freq_select
cpu_freq_select is used as array subscript, thus the valid value range is 0 ... ARRAY_SIZE() - 1.
Signed-off-by Axel Lin <[email protected]>
--- drivers/clk/mvebu/clk-core.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/clk/mvebu/clk-core.c +2 -2
@@ -156,7 +156,7 @@ static u32 __init armada_370_get_cpu_freq(void __iomem *sar) cpu_freq_select = ((readl (sar) >>SARL_A370_PCLK_FREQ_OPT ) &SARL_A370_PCLK_FREQ_OPT_MASK ); -if (cpu_freq_select >ARRAY_SIZE (armada_370_cpu_frequencies)) { +if (cpu_freq_select >=ARRAY_SIZE (armada_370_cpu_frequencies)) {pr_err ("CPU freq select unsupported %d\n" , cpu_freq_select); cpu_freq =0 ; }else
@@ -278,7 +278,7 @@ static u32 __init armada_xp_get_cpu_freq(void __iomem *sar) cpu_freq_select |= (((readl (sar+4 ) >>SARH_AXP_PCLK_FREQ_OPT ) &SARH_AXP_PCLK_FREQ_OPT_MASK ) <<SARH_AXP_PCLK_FREQ_OPT_SHIFT ); -if (cpu_freq_select >ARRAY_SIZE (armada_xp_cpu_frequencies)) { +if (cpu_freq_select >=ARRAY_SIZE (armada_xp_cpu_frequencies)) {pr_err ("CPU freq select unsupported: %d\n" , cpu_freq_select); cpu_freq =0 ; }else
Signature · 1 line
1.7.10.4