udev: Move udevd back to /sbin

Along with v182 upgrade udevd was moved to ${base_libdir}

making scripts like init-live.sh to fail in finding udevd

Fixes [Yocto #4046]

Signed-off-by Radu Moisan <[email protected]>

---

meta/recipes-core/udev/udev.inc    |    3 ++-
meta/recipes-core/udev/udev_182.bb |    2 +-
2 files changed, 3 insertions(+), 2 deletions(-)

meta/recipes-core/udev/udev.inc +1 -1

index e358d2d..c4d2ce4 100644
@@ -40,7 +40,7 @@ EXTRA_OECONF = "--disable-introspection \
                ac_cv_file__usr_share_hwdata_pci_ids=no \
                ac_cv_file__usr_share_misc_pci_ids=yes \
                --sbindir=${base_sbindir} \
-                --libexecdir=${base_libdir} \
+                --libexecdir=${base_sbindir} \
                --with-rootlibdir=${base_libdir} \
                --with-rootprefix= \
               "

@@ -61,6 +61,7 @@ RRECOMMENDS_${PN} += "udev-utils"

FILES_${PN}-dbg += "${libexecdir}/.debug" FILES_${PN}-dbg += "${base_libdir}/udev/.debug/" FILES_${PN}-dbg += "${base_libdir}/udev/.debug/*" +FILES_${PN}-dbg += "${base_sbindir}/udev/.debug/*" FILES_${PN}-dev = "${datadir}/pkgconfig/udev.pc" FILES_libudev = "${base_libdir}/libudev.so.*" FILES_libudev-dbg = "${base_libdir}/.debug/libudev.so.*"

meta/recipes-core/udev/udev_182.bb +0 -0

index 42b4d08..d66292e 100644
@@ -1,6 +1,6 @@

include udev.inc

meta/recipes-core/udev/udev_182.bb +1 -1

-PR = "r6"
+PR = "r7"

# module-init-tools from kmod_git will provide libkmod runtime
DEPENDS += "module-init-tools"

Signature · 7 lines

1.7.9.5


_______________________________________________
Openembedded-core mailing list
[email protected]
http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core

Op 8 apr. 2013, om 18:29 heeft Radu Moisan <[email protected]> het volgende geschreven:

Quoted 1 line

Along with v182 upgrade udevd was moved to ${base_libdir}

By upstream, yes

Quoted 1 line

making scripts like init-live.sh to fail in finding udevd

So you should fix those scripts, not mess around with udev.

Quoted 3 lines

Fixes [Yocto #4046]

Signed-off-by Radu Moisan <[email protected]>

Quoted 11 lines · Koen Kooi

Op 8 apr. 2013, om 18:29 heeft Radu Moisan <[email protected]> het volgende geschreven:

Quoted 1 line

Along with v182 upgrade udevd was moved to ${base_libdir}

By upstream, yes

Quoted 1 line

making scripts like init-live.sh to fail in finding udevd

So you should fix those scripts, not mess around with udev.

Quoted 3 lines

Quoted 3 lines

Fixes [Yocto #4046]

Signed-off-by Radu Moisan <[email protected]>

This move has been done long time ago so I agree with Koen here: the scripts needs to be fixed. Another thing, it should also be tested with systemd feature enabled as udev will be called systemd-udevd in this case, IIRC.

Along with v182 upgrade udevd was moved to ${base_libdir} making scripts like init-live.sh to fail in finding udevd

Fixes [Yocto #4046]

Signed-off-by Radu Moisan <[email protected]>

---
 meta/recipes-core/udev/udev.inc    |    3 ++-
 meta/recipes-core/udev/udev_182.bb |    2 +-
 2 files changed, 3 insertions(+), 2 deletions(-)

Quoted 10 lines · Radu Moisan

Along with v182 upgrade udevd was moved to ${base_libdir} making scripts like init-live.sh to fail in finding udevd

Fixes [Yocto #4046]

Signed-off-by Radu Moisan <[email protected]>

---
 meta/recipes-core/udev/udev.inc    |    3 ++-
 meta/recipes-core/udev/udev_182.bb |    2 +-
 2 files changed, 3 insertions(+), 2 deletions(-)

We needed a decision on this. I've rewritten the commit message and merged it. Most of the feedback was about the commit message, not the patch itself. There were also no better proposals for how we could actually fix the bugs we were seeing.

Quoted 12 lines · Richard Purdie

Quoted 10 lines · Radu Moisan

Along with v182 upgrade udevd was moved to ${base_libdir} making scripts like init-live.sh to fail in finding udevd

Fixes [Yocto #4046]

Signed-off-by Radu Moisan <[email protected]>

---

meta/recipes-core/udev/udev.inc    |    3 ++-
meta/recipes-core/udev/udev_182.bb |    2 +-
2 files changed, 3 insertions(+), 2 deletions(-)

Quoted 4 lines

We needed a decision on this. I've rewritten the commit message and merged it. Most of the feedback was about the commit message, not the patch itself. There were also no better proposals for how we could actually fix the bugs we were seeing.

If I read the thread right, it had two NACK's. So it wasn't a cosmetic commit log issue.

Op 9 apr. 2013, om 16:36 heeft Otavio Salvador <[email protected]> het volgende geschreven:

Quoted 14 lines

Quoted 12 lines · Richard Purdie

Quoted 10 lines · Radu Moisan

Along with v182 upgrade udevd was moved to ${base_libdir} making scripts like init-live.sh to fail in finding udevd

Fixes [Yocto #4046]

Signed-off-by Radu Moisan <[email protected]>

---

meta/recipes-core/udev/udev.inc    |    3 ++-
meta/recipes-core/udev/udev_182.bb |    2 +-
2 files changed, 3 insertions(+), 2 deletions(-)

Quoted 7 lines

Quoted 4 lines

We needed a decision on this. I've rewritten the commit message and merged it. Most of the feedback was about the commit message, not the patch itself. There were also no better proposals for how we could actually fix the bugs we were seeing.

If I read the thread right, it had two NACK's. So it wasn't a cosmetic commit log issue.

4 replies to the patch:

1) me asking about the commit log
2) me NACK'ing the patch
3) Otavio NACK'ing the ptch
4) RP mentioning other discussions

So 25% of the replies are about cosmetics, how is that "most of the replies"?

Op 9 apr. 2013, om 16:41 heeft Koen Kooi <[email protected]> het volgende geschreven:

Quoted 29 lines

Op 9 apr. 2013, om 16:36 heeft Otavio Salvador <[email protected]> het volgende geschreven:

Quoted 14 lines

Quoted 12 lines · Richard Purdie

Quoted 10 lines · Radu Moisan

Along with v182 upgrade udevd was moved to ${base_libdir} making scripts like init-live.sh to fail in finding udevd

Fixes [Yocto #4046]

Signed-off-by Radu Moisan <[email protected]>

---

meta/recipes-core/udev/udev.inc    |    3 ++-
meta/recipes-core/udev/udev_182.bb |    2 +-
2 files changed, 3 insertions(+), 2 deletions(-)

Quoted 7 lines

Quoted 4 lines

We needed a decision on this. I've rewritten the commit message and merged it. Most of the feedback was about the commit message, not the patch itself. There were also no better proposals for how we could actually fix the bugs we were seeing.

If I read the thread right, it had two NACK's. So it wasn't a cosmetic commit log issue.

4 replies to the patch:

1) me asking about the commit log
2) me NACK'ing the patch

Quoted 1 line

3) Otavio NACK'ing the ptch

Quoted 1 line

4) RP mentioning other discussions

And by the way, does anyone actually bother testing patches to important infrastructure like udev?

[koen@rrMBP udev]$ git log --oneline -1
a866e1e udev: Move udevd back to /sbin

[koen@rrMBP udev]$ git grep /lib/udev/udevd
udev/init:[ -x /lib/udev/udevd ] || exit 1
udev/init: /lib/udev/udevd -d
udev/udev-cache:[ -x /lib/udev/udevd ] || exit 1

So the patch broke the sysvinit script, congratulations!

Quoted 29 lines · Koen Kooi

Op 9 apr. 2013, om 16:41 heeft Koen Kooi <[email protected]> het volgende geschreven:

Quoted 27 lines

Op 9 apr. 2013, om 16:36 heeft Otavio Salvador <[email protected]> het volgende geschreven:

Quoted 14 lines

Quoted 12 lines · Richard Purdie

Quoted 10 lines · Radu Moisan

Along with v182 upgrade udevd was moved to ${base_libdir} making scripts like init-live.sh to fail in finding udevd

Fixes [Yocto #4046]

Signed-off-by Radu Moisan <[email protected]>

---

meta/recipes-core/udev/udev.inc    |    3 ++-
meta/recipes-core/udev/udev_182.bb |    2 +-
2 files changed, 3 insertions(+), 2 deletions(-)

Quoted 7 lines

Quoted 4 lines

We needed a decision on this. I've rewritten the commit message and merged it. Most of the feedback was about the commit message, not the patch itself. There were also no better proposals for how we could actually fix the bugs we were seeing.

If I read the thread right, it had two NACK's. So it wasn't a cosmetic commit log issue.

4 replies to the patch:

Quoted 2 lines

Quoted 2 lines

1) me asking about the commit log
2) me NACK'ing the patch

Without any constructive way of fixing the issues. As I've said, "fixing" the other scripts does not work. Nobody has proposed any reasonable realistic way of unbreaking the multilib support which worked prior to the udev upgrade. Nobody has actually taken the time to even understand what is breaking as far as I can tell.

Quoted 1 line

Quoted 1 line

3) Otavio NACK'ing the ptch

Again, not constructively. People saying "no" just because they dislike it doesn't really work.

Quoted 7 lines

Quoted 1 line

4) RP mentioning other discussions

And by the way, does anyone actually bother testing patches to important infrastructure like udev?

[koen@rrMBP udev]$ git log --oneline -1
a866e1e udev: Move udevd back to /sbin

Quoted 6 lines

[koen@rrMBP udev]$ git grep /lib/udev/udevd
udev/init:[ -x /lib/udev/udevd ] || exit 1
udev/init: /lib/udev/udevd -d
udev/udev-cache:[ -x /lib/udev/udevd ] || exit 1

So the patch broke the sysvinit script, congratulations!

Patch screw up :(. This will get fixed shortly, sorry about that.

Cheers,

Richard

_______________________________________________
Openembedded-core mailing list
[email protected]
http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core

Quoted 43 lines · Richard Purdie

Quoted 39 lines · Koen Kooi

Op 9 apr. 2013, om 16:41 heeft Koen Kooi <[email protected]> het volgende geschreven:

Quoted 35 lines

Op 9 apr. 2013, om 16:36 heeft Otavio Salvador <[email protected]> het volgende geschreven:

Quoted 17 lines

Quoted 15 lines · Richard Purdie

Quoted 11 lines · Radu Moisan

Along with v182 upgrade udevd was moved to ${base_libdir} making scripts like init-live.sh to fail in finding udevd

Fixes [Yocto #4046]

Signed-off-by Radu Moisan <[email protected]>

---

meta/recipes-core/udev/udev.inc    |    3 ++-
meta/recipes-core/udev/udev_182.bb |    2 +-
2 files changed, 3 insertions(+), 2 deletions(-)

Quoted 8 lines

Quoted 4 lines

We needed a decision on this. I've rewritten the commit message and merged it. Most of the feedback was about the commit message, not the patch itself. There were also no better proposals for how we could actually fix the bugs we were seeing.

If I read the thread right, it had two NACK's. So it wasn't a cosmetic commit log issue.

4 replies to the patch:

1) me asking about the commit log
2) me NACK'ing the patch

Quoted 5 lines

Without any constructive way of fixing the issues. As I've said, "fixing" the other scripts does not work. Nobody has proposed any reasonable realistic way of unbreaking the multilib support which worked prior to the udev upgrade. Nobody has actually taken the time to even understand what is breaking as far as I can tell.

Let me task a whack at this. If the binary belongs in /usr/lib/udevd/ (or /lib/udevd/) then that tells me it's being treated as a libexecdir and not a "libdir". So the 64-bit versions of udev should NOT be installing into /usr/lib64/... (nor /usr/lib32/...)

If that is the case, and all multilibs end up in /usr/lib/udevd (or /lib/udevd) then the multilib system should continue to work as expected.

(Note, prefer /lib/udevd myself... but that is a separate issue.)

If this sounds reasonable, I can try to make the changes and test the multilib config. But I am far from a systemd/udev expert!

Quoted 31 lines · Koen Kooi

Op 9 apr. 2013, om 16:41 heeft Koen Kooi <[email protected]> het volgende geschreven:

Quoted 29 lines

Op 9 apr. 2013, om 16:36 heeft Otavio Salvador <[email protected]> het volgende geschreven:

Quoted 14 lines

Quoted 12 lines · Richard Purdie

Quoted 10 lines · Radu Moisan

Along with v182 upgrade udevd was moved to ${base_libdir} making scripts like init-live.sh to fail in finding udevd

Fixes [Yocto #4046]

Signed-off-by Radu Moisan <[email protected]>

---

meta/recipes-core/udev/udev.inc    |    3 ++-
meta/recipes-core/udev/udev_182.bb |    2 +-
2 files changed, 3 insertions(+), 2 deletions(-)

Quoted 7 lines

Quoted 4 lines

We needed a decision on this. I've rewritten the commit message and merged it. Most of the feedback was about the commit message, not the patch itself. There were also no better proposals for how we could actually fix the bugs we were seeing.

If I read the thread right, it had two NACK's. So it wasn't a cosmetic commit log issue.

4 replies to the patch:

1) me asking about the commit log
2) me NACK'ing the patch

Without any constructive way of fixing the issues. As I've said, "fixing" the other scripts does not work. Nobody has proposed any reasonable realistic way of unbreaking the multilib support which worked prior to the udev upgrade. Nobody has actually taken the time to even understand what is breaking as far as I can tell.

Quoted 1 line

Quoted 1 line

3) Otavio NACK'ing the ptch

Again, not constructively. People saying "no" just because they dislike it doesn't really work.

Quoted 7 lines

Quoted 1 line

4) RP mentioning other discussions

And by the way, does anyone actually bother testing patches to important infrastructure like udev?

[koen@rrMBP udev]$ git log --oneline -1
a866e1e udev: Move udevd back to /sbin

Quoted 6 lines

[koen@rrMBP udev]$ git grep /lib/udev/udevd
udev/init:[ -x /lib/udev/udevd ] || exit 1
udev/init: /lib/udev/udevd -d
udev/udev-cache:[ -x /lib/udev/udevd ] || exit 1

So the patch broke the sysvinit script, congratulations!

Patch screw up :(. This will get fixed shortly, sorry about that.