Skip to contentSkip to conversation

mnt: release locks on error path in do_loopback

PATCH Applied Andrey Vagin 2 participants 2 messages Apr 9, 2013 VFS

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 mnt: release locks on error path in do_loopback

do_loopback calls lock_mount(path) and forget to unlock_mount if clone_mnt or copy_mnt fails.

[   77.661566] ================================================
[   77.662939] [ BUG: lock held when returning to user space! ]
[   77.664104] 3.9.0-rc5+ #17 Not tainted
[   77.664982] ------------------------------------------------
[   77.666488] mount/514 is leaving the kernel with locks still held!
[   77.668027] 2 locks held by mount/514:
[   77.668817]  #0:  (&sb->s_type->i_mutex_key#7){+.+.+.}, at: [<ffffffff811cca22>] lock_mount+0x32/0xe0
[   77.671755]  #1:  (&namespace_sem){+++++.}, at: [<ffffffff811cca3a>] lock_mount+0x4a/0xe0
---
 fs/namespace.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
fs/namespace.c +1 -1
index f4fa671e..a81343e 100644
@@ -1704,7 +1704,7 @@ static int do_loopback(struct path *path, const char *old_name,
 
 	if (IS_ERR(mnt)) {
 		err = PTR_ERR(mnt);
-		goto out;
+		goto out2;
 	}
 
 	err = graft_tree(mnt, path);
Signature · 1 line
1.8.1.4
maintainer Applied
#1 lore raw
Quoted 2 lines · Andrey Vagin

do_loopback calls lock_mount(path) and forget to unlock_mount if clone_mnt or copy_mnt fails.

Applied.