Skip to contentSkip to conversation

KVM: PPC: emulate dcbst

PATCH Applied Stuart Yoder 4 participants 4 messages Apr 9, 2013 – Apr 10, 2013

Subsystems (3)
KVM PowerPC KVM PowerPC
lore
Share & tools
lore

Stuart Yoder

author
#0 lore raw

PATCH 1/1 KVM: PPC: emulate dcbst

From: Stuart Yoder <[email protected]>

Signed-off-by Stuart Yoder <[email protected]>
---
 arch/powerpc/kvm/emulate.c |    2 ++
 1 file changed, 2 insertions(+)
arch/powerpc/kvm/emulate.c +2 -0
index 7a73b6f..631a265 100644
@@ -38,6 +38,7 @@
 
 #define OP_31_XOP_TRAP      4
 #define OP_31_XOP_LWZX      23
+#define OP_31_XOP_DCBST     54
 #define OP_31_XOP_TRAP_64   68
 #define OP_31_XOP_DCBF      86
 #define OP_31_XOP_LBZX      87

@@ -370,6 +371,7 @@ int kvmppc_emulate_instruction(struct kvm_run *run, struct kvm_vcpu *vcpu)
 			emulated = kvmppc_emulate_mtspr(vcpu, sprn, rs);
 			break;
 
+		case OP_31_XOP_DCBST:
 		case OP_31_XOP_DCBF:
 		case OP_31_XOP_DCBI:
 			/* Do nothing. The guest is performing dcbi because
Signature · 1 line
1.7.9.7
#1 lore raw
Quoted 11 lines

-----Original Message-----
From: Yoder Stuart-B08248
Sent: Tuesday, April 09, 2013 3:36 PM
To: [email protected]
Cc: [email protected]; [email protected]; Yoder Stuart-B08248
Subject: [PATCH] KVM: PPC: emulate dcbst

From: Stuart Yoder <[email protected]>

Signed-off-by Stuart Yoder <[email protected]>

---

One thing I should have mentioned...without this patch on the host 64-bit guest kernels are currently broken when using -smp. Not sure how far back things are broken, the oldest kernel I had a chance to try was like 3.8-rc3.

Stuart

#2 lore raw
Quoted 10 lines · On 04/09/2013 10:20:41 PM, Yoder Stuart-B08248 wrote:
Quoted 5 lines

-----Original Message-----
From: Yoder Stuart-B08248
Sent: Tuesday, April 09, 2013 3:36 PM
To: [email protected]
Cc: [email protected]; [email protected]; Yoder

Stuart-B08248

Quoted 4 lines

Subject: [PATCH] KVM: PPC: emulate dcbst

From: Stuart Yoder <[email protected]>

Quoted 7 lines
Quoted 2 lines
Signed-off-by Stuart Yoder <[email protected]>

---

One thing I should have mentioned...without this patch on the host 64-bit guest kernels are currently broken when using -smp. Not sure how far back things are broken, the oldest kernel I had a chance to try was like 3.8-rc3.

It's due to dcbst being used on the spin table, which is treated as emulated MMIO under QEMU.

-Scott