drm: cleanup: use drm_framebuffer_reference instead of a kref_get
Subsystems (2)
PATCH 1/1 drm: cleanup: use drm_framebuffer_reference instead of a kref_get
drm_framebuffer_lookup() does a kref_get() for the framebuffer if it finds one corresponding to the fb id passed to it. Use drm_framebuffer_reference() instead for clarity since it's the function used in other places to take a reference.
Signed-off-by Archit Taneja <[email protected]>
--- drivers/gpu/drm/drm_crtc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/gpu/drm/drm_crtc.c +1 -1
@@ -412,7 +412,7 @@ struct drm_framebuffer *drm_framebuffer_lookup(struct drm_device *dev,mutex_lock (&dev->mode_config.fb_lock); fb =__drm_framebuffer_lookup (dev, id);if (fb) -kref_get (&fb->refcount); +drm_framebuffer_reference (fb);mutex_unlock (&dev->mode_config.fb_lock);return fb;
Signature · 1 line
1.7.10.4
Quoted 5 lines · Archit Taneja
drm_framebuffer_lookup()does akref_get()for the framebuffer if it finds one corresponding to the fb id passed to it. Usedrm_framebuffer_reference()instead for clarity since it's the function used in other places to take a reference.Signed-off-by Archit Taneja <[email protected]>
Reviewed-by Daniel Vetter <[email protected]>
Quoted 20 lines
--- drivers/gpu/drm/drm_crtc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)drivers/gpu/drm/drm_crtc.c +1
-1@@ -412,7 +412,7 @@ struct drm_framebuffer *drm_framebuffer_lookup(struct drm_device *dev,mutex_lock (&dev->mode_config.fb_lock); fb =__drm_framebuffer_lookup (dev, id);if (fb) -kref_get (&fb->refcount); +drm_framebuffer_reference (fb);mutex_unlock (&dev->mode_config.fb_lock);return fb;Signature · 1 line
1.7.10.4
Signature · 3 lines
Daniel Vetter Software Engineer, Intel Corporation +41 (0) 79 365 57 48 - http://blog.ffwll.ch