ARM: tegra: Add charger subnode to tps65090 node
Subsystems (2)
PATCH 1/1 ARM: tegra: Add charger subnode to tps65090 node
The charger is now represented by a distinct subnode of the tps65090 device. Add this node and enable low current charging with it.
---
- This patch is dependent upon the following fixup-patch.
http://patchwork.ozlabs.org/patch/235434/
arch/arm/boot/dts/tegra114-dalmore.dts | 5 +++++ 1 file changed, 5 insertions(+)
arch/arm/boot/dts/tegra114-dalmore.dts +5 -0
@@ -763,6 +763,11 @@ vsys-l1-supply = <&vdd_ac_bat_reg>; vsys-l2-supply = <&vdd_ac_bat_reg>; + charger { + compatible = "ti,tps65090-charger"; + ti,enable-low-current-chrg; + }; + regulators { tps65090_dcdc1_reg: dcdc1 { regulator-name = "vdd-sys-5v0";
Signature · 1 line
1.7.9.5
PATCH 1/1 ARM: tegra: Add charger subnode to tps65090 node
arch/arm/boot/dts/tegra114-dalmore.dts line 768
Quoted 8 lines · Rhyland Klein
The charger is now represented by a distinct subnode of the tps65090 device. Add this node and enable low current charging with it.
arch/arm/boot/dts/tegra114-dalmore.dts +3
-0+ charger { + compatible = "ti,tps65090-charger"; + ti,enable-low-current-chrg;
So does the TPS65090 driver scan all its sub-nodes like a bus an instantiate anything? That's a little odd since the regulators node is at the same level, yet doesn't represent a device on that same internal bus...
PATCH 1/1 ARM: tegra: Add charger subnode to tps65090 node
Quoted 6 lines · Stephen Warren
Quoted 4 lines · Rhyland Klein
The charger is now represented by a distinct subnode of the tps65090 device. Add this node and enable low current charging with it.
arch/arm/boot/dts/tegra114-dalmore.dts +0
-0
Quoted 9 lines
arch/arm/boot/dts/tegra114-dalmore.dts line 768
Quoted 3 lines
arch/arm/boot/dts/tegra114-dalmore.dts +3
-0+ charger { + compatible = "ti,tps65090-charger"; + ti,enable-low-current-chrg;So does the TPS65090 driver scan all its sub-nodes like a bus an instantiate anything? That's a little odd since the regulators node is at the same level, yet doesn't represent a device on that same internal bus...
It doesn't scan so much as have a list of subdev's it tries to register. The charger node uses the of_compatible string defined (in the tps65090 driver and the charger driver) to match the subnode to the mfd_cell device for the charger. The regulators are currently under a different subdevice which is not using the of_compatible string. I was planning on a follow up patch series to update the tps65090-regulator driver to use the dt type approach with a subnode to be consistent.
-rhyland
Signature · 1 line
nvpublic
PATCH 1/1 ARM: tegra: Add charger subnode to tps65090 node
Quoted 17 lines · Rhyland Klein
Quoted 6 lines · Stephen Warren
Quoted 4 lines · Rhyland Klein
The charger is now represented by a distinct subnode of the tps65090 device. Add this node and enable low current charging with it.
arch/arm/boot/dts/tegra114-dalmore.dts +0
-0Quoted 9 lines
arch/arm/boot/dts/tegra114-dalmore.dts line 768
Quoted 3 lines
arch/arm/boot/dts/tegra114-dalmore.dts +3
-0+ charger { + compatible = "ti,tps65090-charger"; + ti,enable-low-current-chrg;So does the TPS65090 driver scan all its sub-nodes like a bus an instantiate anything? That's a little odd since the regulators node is at the same level, yet doesn't represent a device on that same internal bus...
Quoted 4 lines
It doesn't scan so much as have a list of subdev's it tries to register. The charger node uses the
of_compatiblestring defined (in the tps65090 driver and the charger driver) to match the subnode to themfd_celldevice for the charger.
That sounds very odd. If the main driver hard-codes the list of children it expects, there's no point using compatible for the children. Using a bus-structure and compatible values would only be appropriate when the top-level driver is generic, and simply scans all its children as a generic bus, without having any idea what's there.
Quoted 4 lines
The regulators are currently under a different
subdevice which is not using theof_compatiblestring. I was planning on a follow up patch series to update the tps65090-regulator driver to use the dt type approach with a subnode to be consistent.
But that's changing the DT bindings. That shouldn't be done.
PATCH 1/1 ARM: tegra: Add charger subnode to tps65090 node
Quoted 23 lines · Stephen Warren
Quoted 17 lines · Rhyland Klein
Quoted 6 lines · Stephen Warren
Quoted 4 lines · Rhyland Klein
The charger is now represented by a distinct subnode of the tps65090 device. Add this node and enable low current charging with it.
arch/arm/boot/dts/tegra114-dalmore.dts +0
-0Quoted 9 lines
arch/arm/boot/dts/tegra114-dalmore.dts line 768
Quoted 3 lines
arch/arm/boot/dts/tegra114-dalmore.dts +3
-0+ charger { + compatible = "ti,tps65090-charger"; + ti,enable-low-current-chrg;So does the TPS65090 driver scan all its sub-nodes like a bus an instantiate anything? That's a little odd since the regulators node is at the same level, yet doesn't represent a device on that same internal bus...
Quoted 4 lines
It doesn't scan so much as have a list of subdev's it tries to register. The charger node uses the
of_compatiblestring defined (in the tps65090 driver and the charger driver) to match the subnode to themfd_celldevice for the charger.
Quoted 5 lines
That sounds very odd. If the main driver hard-codes the list of children it expects, there's no point using compatible for the children. Using a bus-structure and compatible values would only be appropriate when the top-level driver is generic, and simply scans all its children as a generic bus, without having any idea what's there.
Agreed, but this seems to mfd children are handled right now, perhaps a rework can be done for dt, but for non-dt routes, there is no bus to scan for children.
Quoted 8 lines
Quoted 5 lines
The regulators are currently under a different
subdevice which is not using theof_compatiblestring. I was planning on a follow up patch series to update the tps65090-regulator driver to use the dt type approach with a subnode to be consistent.But that's changing the DT bindings. That shouldn't be done.
We chose to the do the subnode structure partly to make the Documentation layout more logical. This follows the design of the palmas mfd and its sub-components. I can leave the regulators as is, but to me the inconsistency between the two is more of a concern.
-rhyland
Signature · 1 line
nvpublic
PATCH 1/1 ARM: tegra: Add charger subnode to tps65090 node
In reply to Rhyland KleinQuoted 2 lines · Rhyland Klein
The charger is now represented by a distinct subnode of the tps65090 device. Add this node and enable low current charging with it.
What's the status of the TPS60590 bindings; are they agreed upon by NVIDIA, TI, and SlimLogic yet? In other words, is this patch still something I should apply for 3.11, or does it need to be reworked?
PATCH 1/1 ARM: tegra: Add charger subnode to tps65090 node
Quoted 7 lines · Stephen Warren
Quoted 2 lines · Rhyland Klein
The charger is now represented by a distinct subnode of the tps65090 device. Add this node and enable low current charging with it.
What's the status of the TPS60590 bindings; are they agreed upon by NVIDIA, TI, and SlimLogic yet? In other words, is this patch still something I should apply for 3.11, or does it need to be reworked?
I haven't seen any discussion with slimlogic or TI about the tps65090. As far as I know the bindings for this driver haven't changed.
Laxman, do you think the work on the palmas driver will impact the design of the bindings for the tps65090?
-rhyland
Quoted 5 lines
--
To unsubscribe from this list: send the line "unsubscribe linux-tegra" in the body of a message to majordomo at vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Signature · 1 line
nvpublic
PATCH 1/1 ARM: tegra: Add charger subnode to tps65090 node
Quoted 9 lines · Rhyland Klein
Quoted 7 lines · Stephen Warren
Quoted 2 lines · Rhyland Klein
The charger is now represented by a distinct subnode of the tps65090 device. Add this node and enable low current charging with it.
What's the status of the TPS60590 bindings; are they agreed upon by NVIDIA, TI, and SlimLogic yet? In other words, is this patch still something I should apply for 3.11, or does it need to be reworked?
Quoted 5 lines
I haven't seen any discussion with slimlogic or TI about the tps65090. As far as I know the bindings for this driver haven't changed.
Laxman, do you think the work on the palmas driver will impact the design of the bindings for the tps65090?
Sorry, perhaps I'm confusing two different chips. If TPS65090 isn't Palmas, then ignore my question. In which case, I suppose I should just apply your patch then?
PATCH 1/1 ARM: tegra: Add charger subnode to tps65090 node
Quoted 13 lines · Stephen Warren
Quoted 12 lines · Rhyland Klein
Quoted 7 lines · Stephen Warren
Quoted 2 lines · Rhyland Klein
The charger is now represented by a distinct subnode of the tps65090 device. Add this node and enable low current charging with it.
What's the status of the TPS60590 bindings; are they agreed upon by NVIDIA, TI, and SlimLogic yet? In other words, is this patch still something I should apply for 3.11, or does it need to be reworked?
I haven't seen any discussion with slimlogic or TI about the tps65090. As far as I know the bindings for this driver haven't changed.
Quoted 7 lines
Quoted 2 lines
Laxman, do you think the work on the palmas driver will impact the design of the bindings for the tps65090?
Sorry, perhaps I'm confusing two different chips. If TPS65090 isn't Palmas, then ignore my question. In which case, I suppose I should just apply your patch then?
I would say yes. The design of having the child node this way was how we had agreed worked best. The only reason I would see a significant reason to change this, is if something was decided that all mfd devices should start to follow some pattern which differed, which would mean changing existing bindings and therefore is unlikely.
-rhyland
Signature · 1 line
nvpublic
PATCH 1/1 ARM: tegra: Add charger subnode to tps65090 node
Quoted 22 lines · Rhyland Klein
Quoted 13 lines · Stephen Warren
Quoted 12 lines · Rhyland Klein
Quoted 7 lines · Stephen Warren
Quoted 2 lines · Rhyland Klein
The charger is now represented by a distinct subnode of the tps65090 device. Add this node and enable low current charging with it.
What's the status of the TPS60590 bindings; are they agreed upon by NVIDIA, TI, and SlimLogic yet? In other words, is this patch still something I should apply for 3.11, or does it need to be reworked?
I haven't seen any discussion with slimlogic or TI about the tps65090. As far as I know the bindings for this driver haven't changed.
Quoted 7 lines
Quoted 2 lines
Laxman, do you think the work on the palmas driver will impact the design of the bindings for the tps65090?
Sorry, perhaps I'm confusing two different chips. If TPS65090 isn't Palmas, then ignore my question. In which case, I suppose I should just apply your patch then?
Quoted 5 lines
I would say yes. The design of having the child node this way was how we had agreed worked best. The only reason I would see a significant reason to change this, is if something was decided that all mfd devices should start to follow some pattern which differed, which would mean changing existing bindings and therefore is unlikely.
OK, I have applied this patch to Tegra's for-3.11/dt branch. I also sent a patch to actually enable the new driver in tegra_defconfig.
PATCH 1/1 ARM: tegra: Add charger subnode to tps65090 node
Quoted 23 lines · Stephen Warren
Quoted 22 lines · Rhyland Klein
Quoted 20 lines · Stephen Warren
Quoted 9 lines · Rhyland Klein
Quoted 7 lines · Stephen Warren
Quoted 2 lines · Rhyland Klein
The charger is now represented by a distinct subnode of the tps65090 device. Add this node and enable low current charging with it.
What's the status of the TPS60590 bindings; are they agreed upon by NVIDIA, TI, and SlimLogic yet? In other words, is this patch still something I should apply for 3.11, or does it need to be reworked?
Quoted 5 lines
I haven't seen any discussion with slimlogic or TI about the tps65090. As far as I know the bindings for this driver haven't changed.
Laxman, do you think the work on the palmas driver will impact the design of the bindings for the tps65090?
Sorry, perhaps I'm confusing two different chips. If TPS65090 isn't Palmas, then ignore my question. In which case, I suppose I should just apply your patch then?
Quoted 9 lines
Quoted 5 lines
I would say yes. The design of having the child node this way was how we had agreed worked best. The only reason I would see a significant reason to change this, is if something was decided that all mfd devices should start to follow some pattern which differed, which would mean changing existing bindings and therefore is unlikely.
OK, I have applied this patch to Tegra's for-3.11/dt branch. I also sent a patch to actually enable the new driver in
tegra_defconfig.
thanks, that was the next patch I was going to send :) Beat me to it.
-rhyland
Signature · 1 line
nvpublic