Skip to contentSkip to conversation

target: Fix incorrect fallthrough of ALUA Standby/Offline/Transition CDBs

PATCH New Nicholas A. Bellinger 1 participant 1 message Apr 10, 2013

Subsystems (2)
SCSI SCSI target
lore
Share & tools
lore

Nicholas A. Bellinger

author
#0 lore raw

PATCH 1/1 target: Fix incorrect fallthrough of ALUA Standby/Offline/Transition CDBs

From: Nicholas Bellinger <[email protected]>

This patch fixes a bug where a handful of informational / control CDBs that should be allowed during ALUA access state Standby/Offline/Transition where incorrectly returning CHECK_CONDITION + ASCQ_04H_ALUA_TG_PT_*.

This includes INQUIRY + REPORT_LUNS, which would end up preventing LUN registration when LUN scanning occured during these ALUA access states.

Cc Hannes Reinecke <[email protected]>
Signed-off-by Nicholas Bellinger <[email protected]>
---
 drivers/target/target_core_alua.c |    3 +++
 1 files changed, 3 insertions(+), 0 deletions(-)
drivers/target/target_core_alua.c +3 -0
index ff1c5ee..cbe48ab 100644
@@ -409,6 +409,7 @@ static inline int core_alua_state_standby(
 	case REPORT_LUNS:
 	case RECEIVE_DIAGNOSTIC:
 	case SEND_DIAGNOSTIC:
+		return 0;
 	case MAINTENANCE_IN:
 		switch (cdb[1] & 0x1f) {
 		case MI_REPORT_TARGET_PGS:

@@ -451,6 +452,7 @@ static inline int core_alua_state_unavailable(
 	switch (cdb[0]) {
 	case INQUIRY:
 	case REPORT_LUNS:
+		return 0;
 	case MAINTENANCE_IN:
 		switch (cdb[1] & 0x1f) {
 		case MI_REPORT_TARGET_PGS:

@@ -491,6 +493,7 @@ static inline int core_alua_state_transition(
 	switch (cdb[0]) {
 	case INQUIRY:
 	case REPORT_LUNS:
+		return 0;
 	case MAINTENANCE_IN:
 		switch (cdb[1] & 0x1f) {
 		case MI_REPORT_TARGET_PGS:
Signature · 1 line
1.7.2.5