Skip to contentSkip to conversation

ARM: Add support for Seagate GoFlexHome

PATCH New Suriyan Ramasami 3 participants 3 messages Apr 11, 2013

lore
Share & tools
lore
#0 lore raw

PATCH v3 1/1 ARM: Add support for Seagate GoFlexHome

This is yet another attempt with patch v3.
Thanks to Wolfgang, Prafulla and Albert for comments, corrections, and suggestions.

Comments on the files:
MAINTAINERS:
Add maintainer entry for the Seagate GoFlexHome

board/Seagate/goflexhome/Makefile:
Start with the Dockstar Makefile
The object file is goflexhome.o

board/Seagate/goflexhome/goflexhome.c:
Start with dockstar.c and rename it to goflexhome.c Include goflexhome.h instead of dockstar.h
Change #define DOCKSTAR_* to #define GOFLEXHOME_* Change the MACH_TYPE_DOCKSTAR to MACH_TYPE_GOFLEXHOME to reflect that its a GoFlexHome.

board/Seagate/goflexhome/goflexhome.h:
Start with dockstar.h and rename it to goflexhome.h In all the #defines cosmetically change DOCKSTAR to GOFLEXHOME

board/Seagate/goflexhome/kwbimage.cfg:
Copy the dockstar/kwbimage.cfg to goflexhome/kwbimage.cfg

boards.cfg:
Copy the dockstar line and rename dockstar to goflexhome

include/configs/goflexhome.h:
Start with dockstar.h and rename it to goflexhome.h Change CONFIG_IDENT_STRING to be GoFlex specific
Add #define CONFIG_CMD_IDE, CONFIG_MVSATA_IDE for IDE support Add #define CONFIG_CMD_DATE, CONFIG_RTC_MV for RTC support Add #define CONFIG_CMD_EXT4 for supporting ext4 FS Change CONFIG_SYS_PROMPT to be GoFlex specific
Change CONFIG_ENV_ADDR and CONFIG_ENV_OFFSET to the default address present in ArchLinuxArm install (/etc/fw_env.config)

---
Changes in v3:
Squash the board support in one file
Remove goflexhomemenu.c from this patch as its not board related

Changes in v2:
Coding style changes

 MAINTAINERS                           |    4 +
 board/Seagate/goflexhome/Makefile     |   51 +++++++++
 board/Seagate/goflexhome/goflexhome.c |  187 +++++++++++++++++++++++++++++++++
 board/Seagate/goflexhome/goflexhome.h |   47 ++++++++
 board/Seagate/goflexhome/kwbimage.cfg |  168 +++++++++++++++++++++++++++++
 boards.cfg                            |    1 +
 include/configs/goflexhome.h          |  135 ++++++++++++++++++++++++
 7 files changed, 593 insertions(+), 0 deletions(-)
 create mode 100644 board/Seagate/goflexhome/Makefile
 create mode 100644 board/Seagate/goflexhome/goflexhome.c
 create mode 100644 board/Seagate/goflexhome/goflexhome.h
 create mode 100644 board/Seagate/goflexhome/kwbimage.cfg
 create mode 100644 include/configs/goflexhome.h
MAINTAINERS +4 -0
index 1614b91..6292a58 100644
@@ -847,6 +847,10 @@ Sricharan R <[email protected]>
 	omap4_sdp4430	ARM ARMV7 (OMAP4xx SoC)
 	omap5_evm	ARM ARMV7 (OMAP5xx Soc)
 
+Suriyan Ramasami <[email protected]>
+
+	goflexhome	ARM926EJS (Kirkwood SoC)
+
 Thierry Reding <[email protected]>
 
 	plutux		Tegra20 (ARM7 & A9 Dual Core)
board/Seagate/goflexhome/Makefile new file +51 -0

51 lines not on this page · raw message

board/Seagate/goflexhome/goflexhome.c new file +187 -0

187 lines not on this page · raw message

board/Seagate/goflexhome/goflexhome.h new file +47 -0

47 lines not on this page · raw message

board/Seagate/goflexhome/kwbimage.cfg new file +168 -0

168 lines not on this page · raw message

boards.cfg +1 -0
index 5fc70be..d6f8593 100644
@@ -184,6 +184,7 @@ rd6281a                      arm         arm926ejs   -                   Marvell
 sheevaplug                   arm         arm926ejs   -                   Marvell        kirkwood
 ib62x0                       arm         arm926ejs   ib62x0              raidsonic      kirkwood
 dockstar                     arm         arm926ejs   -                   Seagate        kirkwood
+goflexhome                   arm         arm926ejs   -                   Seagate        kirkwood
 tk71                         arm         arm926ejs   tk71                karo           kirkwood
 devkit3250                   arm         arm926ejs   devkit3250          timll          lpc32xx
 jadecpu                      arm         arm926ejs   jadecpu             syteco         mb86r0x
include/configs/goflexhome.h new file +135 -0

135 lines not on this page · raw message

Signature · 1 line
1.7.1
#1 lore raw

PATCH v3 1/1 ARM: Add support for Seagate GoFlexHome

Hi Suriyan,

Quoted 39 lines · Suriyan Ramasami

This is yet another attempt with patch v3.
Thanks to Wolfgang, Prafulla and Albert for comments, corrections, and suggestions.

Comments on the files:
MAINTAINERS:
Add maintainer entry for the Seagate GoFlexHome

board/Seagate/goflexhome/Makefile:
Start with the Dockstar Makefile
The object file is goflexhome.o

board/Seagate/goflexhome/goflexhome.c:
Start with dockstar.c and rename it to goflexhome.c Include goflexhome.h instead of dockstar.h
Change #define DOCKSTAR_* to #define GOFLEXHOME_* Change the MACH_TYPE_DOCKSTAR to MACH_TYPE_GOFLEXHOME to reflect that its a GoFlexHome.

board/Seagate/goflexhome/goflexhome.h:
Start with dockstar.h and rename it to goflexhome.h In all the #defines cosmetically change DOCKSTAR to GOFLEXHOME

board/Seagate/goflexhome/kwbimage.cfg:
Copy the dockstar/kwbimage.cfg to goflexhome/kwbimage.cfg

boards.cfg:
Copy the dockstar line and rename dockstar to goflexhome

include/configs/goflexhome.h:
Start with dockstar.h and rename it to goflexhome.h Change CONFIG_IDENT_STRING to be GoFlex specific
Add #define CONFIG_CMD_IDE, CONFIG_MVSATA_IDE for IDE support Add #define CONFIG_CMD_DATE, CONFIG_RTC_MV for RTC support Add #define CONFIG_CMD_EXT4 for supporting ext4 FS Change CONFIG_SYS_PROMPT to be GoFlex specific
Change CONFIG_ENV_ADDR and CONFIG_ENV_OFFSET to the default address present in ArchLinuxArm install (/etc/fw_env.config)

Quoted 1 line

The text above, until the line '---' below, will remain in the commit message. This message should only be a one-line summary and a few lines of general description.

Here, the 'thank you' part (appreciated nonetheless!) should be moved down just below the '---' separator line , and the details on the changes should simply not be given (after all, it all can be seen in the diff).

Quoted 657 lines

---
Changes in v3:
Squash the board support in one file
Remove goflexhomemenu.c from this patch as its not board related

Changes in v2:
Coding style changes

 MAINTAINERS                           |    4 +
 board/Seagate/goflexhome/Makefile     |   51 +++++++++
 board/Seagate/goflexhome/goflexhome.c |  187 +++++++++++++++++++++++++++++++++
 board/Seagate/goflexhome/goflexhome.h |   47 ++++++++
 board/Seagate/goflexhome/kwbimage.cfg |  168 +++++++++++++++++++++++++++++
 boards.cfg                            |    1 +
 include/configs/goflexhome.h          |  135 ++++++++++++++++++++++++
 7 files changed, 593 insertions(+), 0 deletions(-)
 create mode 100644 board/Seagate/goflexhome/Makefile
 create mode 100644 board/Seagate/goflexhome/goflexhome.c
 create mode 100644 board/Seagate/goflexhome/goflexhome.h
 create mode 100644 board/Seagate/goflexhome/kwbimage.cfg
 create mode 100644 include/configs/goflexhome.h
MAINTAINERS +4 -0
index 1614b91..6292a58 100644
@@ -847,6 +847,10 @@ Sricharan R <[email protected]>
 	omap4_sdp4430	ARM ARMV7 (OMAP4xx SoC)
 	omap5_evm	ARM ARMV7 (OMAP5xx Soc)
 
+Suriyan Ramasami <[email protected]>
+
+	goflexhome	ARM926EJS (Kirkwood SoC)
+
 Thierry Reding <[email protected]>
 
 	plutux		Tegra20 (ARM7 & A9 Dual Core)
board/Seagate/goflexhome/Makefile new file +51 -0
new file mode 100644
index 0000000..9948fe2
@@ -0,0 +1,51 @@
+#
+# Copyright (C) 2013 Suriyan Ramasami <[email protected]>
+#
+# Based on dockstar/Makefile originally written by
+# Copyright (C) 2010  Eric C. Cooper <[email protected]>
+#
+# Based on sheevaplug/Makefile originally written by
+# Prafulla Wadaskar <[email protected]>
+# (C) Copyright 2009
+# Marvell Semiconductor <www.marvell.com>
+#
+# See file CREDITS for list of people who contributed to this
+# project.
+#
+# This program is free software; you can redistribute it and/or
+# modify it under the terms of the GNU General Public License as
+# published by the Free Software Foundation; either version 2 of
+# the License, or (at your option) any later version.
+#
+# This program is distributed in the hope that it will be useful,
+# but WITHOUT ANY WARRANTY; without even the implied warranty of
+# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.	 See the
+# GNU General Public License for more details.
+#
+# You should have received a copy of the GNU General Public License
+# along with this program; if not, write to the Free Software
+# Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston,
+# MA 02110-1301 USA
+#
+
+include $(TOPDIR)/config.mk
+
+LIB	= $(obj)lib$(BOARD).o
+
+COBJS	:= goflexhome.o
+
+SRCS	:= $(SOBJS:.o=.S) $(COBJS:.o=.c)
+OBJS	:= $(addprefix $(obj),$(COBJS))
+SOBJS	:= $(addprefix $(obj),$(SOBJS))
+
+$(LIB):	$(obj).depend $(OBJS) $(SOBJS)
+	$(call cmd_link_o_target, $(OBJS) $(SOBJS))
+
+#########################################################################
+
+# defines $(obj).depend target
+include $(SRCTREE)/rules.mk
+
+sinclude $(obj).depend
+
+#########################################################################
board/Seagate/goflexhome/goflexhome.c new file +187 -0
new file mode 100644
index 0000000..c1314fb
@@ -0,0 +1,187 @@
+/*
+ * Copyright (C) 2013 Suriyan Ramasami <[email protected]>
+ *
+ * Based on dockstar.c originally written by
+ * Copyright (C) 2010  Eric C. Cooper <[email protected]>
+ *
+ * Based on sheevaplug.c originally written by
+ * Prafulla Wadaskar <[email protected]>
+ * (C) Copyright 2009
+ * Marvell Semiconductor <www.marvell.com>
+ *
+ * See file CREDITS for list of people who contributed to this
+ * project.
+ *
+ * This program is free software; you can redistribute it and/or
+ * modify it under the terms of the GNU General Public License as
+ * published by the Free Software Foundation; either version 2 of
+ * the License, or (at your option) any later version.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
+ * GNU General Public License for more details.
+ *
+ * You should have received a copy of the GNU General Public License
+ * along with this program; if not, write to the Free Software
+ * Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston,
+ * MA 02110-1301 USA
+ */
+
+#include <common.h>
+#include <miiphy.h>
+#include <asm/arch/kirkwood.h>
+#include <asm/arch/mpp.h>
+#include <asm/arch/cpu.h>
+#include <asm/io.h>
+#include "goflexhome.h"
+
+
+DECLARE_GLOBAL_DATA_PTR;
+
+int board_early_init_f(void)
+{
+	/*
+	 * default gpio configuration
+	 * There are maximum 64 gpios controlled through 2 sets of registers
+	 * the  below configuration configures mainly initial LED status
+	 */
+	kw_config_gpio(GOFLEXHOME_OE_VAL_LOW,
+		       GOFLEXHOME_OE_VAL_HIGH,
+		       GOFLEXHOME_OE_LOW, GOFLEXHOME_OE_HIGH);
+
+	/* Multi-Purpose Pins Functionality configuration */
+	static const u32 kwmpp_config[] = {
+		MPP0_NF_IO2,
+		MPP1_NF_IO3,
+		MPP2_NF_IO4,
+		MPP3_NF_IO5,
+		MPP4_NF_IO6,
+		MPP5_NF_IO7,
+		MPP6_SYSRST_OUTn,
+		MPP7_GPO,
+		MPP8_UART0_RTS,
+		MPP9_UART0_CTS,
+		MPP10_UART0_TXD,
+		MPP11_UART0_RXD,
+		MPP12_SD_CLK,
+		MPP13_SD_CMD,
+		MPP14_SD_D0,
+		MPP15_SD_D1,
+		MPP16_SD_D2,
+		MPP17_SD_D3,
+		MPP18_NF_IO0,
+		MPP19_NF_IO1,
+		MPP20_GPIO,
+		MPP21_GPIO,
+		MPP22_GPIO,
+		MPP23_GPIO,
+		MPP24_GPIO,
+		MPP25_GPIO,
+		MPP26_GPIO,
+		MPP27_GPIO,
+		MPP28_GPIO,
+		MPP29_TSMP9,
+		MPP30_GPIO,
+		MPP31_GPIO,
+		MPP32_GPIO,
+		MPP33_GPIO,
+		MPP34_GPIO,
+		MPP35_GPIO,
+		MPP36_GPIO,
+		MPP37_GPIO,
+		MPP38_GPIO,
+		MPP39_GPIO,
+		MPP40_GPIO,
+		MPP41_GPIO,
+		MPP42_GPIO,
+		MPP43_GPIO,
+		MPP44_GPIO,
+		MPP45_GPIO,
+		MPP46_GPIO,
+		MPP47_GPIO,
+		MPP48_GPIO,
+		MPP49_GPIO,
+		0
+	};
+	kirkwood_mpp_conf(kwmpp_config, NULL);
+	return 0;
+}
+
+int board_init(void)
+{
+	/*
+	 * arch number of board
+	 */
+	gd->bd->bi_arch_number = MACH_TYPE_GOFLEXHOME;
+
+	/* address of boot parameters */
+	gd->bd->bi_boot_params = kw_sdram_bar(0) + 0x100;
+
+	return 0;
+}
+
+#ifdef CONFIG_RESET_PHY_R
+/* Configure and enable MV88E1116 PHY */
+void reset_phy(void)
+{
+	u16 reg;
+	u16 devadr;
+	char *name = "egiga0";
+
+	if (miiphy_set_current_dev(name))
+		return;
+
+	/* command to read PHY dev address */
+	if (miiphy_read(name, 0xEE, 0xEE, (u16 *)&devadr)) {
+		printf("Err..%s could not read PHY dev address\n",
+		       __func__);
+		return;
+	}
+
+	/*
+	 * Enable RGMII delay on Tx and Rx for CPU port
+	 * Ref: sec 4.7.2 of chip datasheet
+	 */
+	miiphy_write(name, devadr, MV88E1116_PGADR_REG, 2);
+	miiphy_read(name, devadr, MV88E1116_MAC_CTRL_REG, &reg);
+	reg |= (MV88E1116_RGMII_RXTM_CTRL | MV88E1116_RGMII_TXTM_CTRL);
+	miiphy_write(name, devadr, MV88E1116_MAC_CTRL_REG, reg);
+	miiphy_write(name, devadr, MV88E1116_PGADR_REG, 0);
+
+	/* reset the phy */
+	miiphy_reset(name, devadr);
+
+	printf("88E1116 Initialized on %s\n", name);
+}
+#endif /* CONFIG_RESET_PHY_R */
+
+#define GREEN_LED	(1 << 14)
+#define ORANGE_LED	(1 << 15)
+#define BOTH_LEDS	(GREEN_LED | ORANGE_LED)
+#define NEITHER_LED	0
+
+static void set_leds(u32 leds, u32 blinking)
+{
+	struct kwgpio_registers *r = (struct kwgpio_registers *)KW_GPIO1_BASE;
+	u32 oe = readl(&r->oe) | BOTH_LEDS;
+	writel(oe & ~leds, &r->oe);	/* active low */
+	u32 bl = readl(&r->blink_en) & ~BOTH_LEDS;
+	writel(bl | blinking, &r->blink_en);
+}
+
+void show_boot_progress(int val)
+{
+	switch (val) {
+	case BOOTSTAGE_ID_RUN_OS:		/* booting Linux */
+		set_leds(BOTH_LEDS, NEITHER_LED);
+		break;
+	case BOOTSTAGE_ID_NET_ETH_START:	/* Ethernet initialization */
+		set_leds(GREEN_LED, GREEN_LED);
+		break;
+	default:
+		if (val < 0)	/* error */
+			set_leds(ORANGE_LED, ORANGE_LED);
+		break;
+	}
+}
board/Seagate/goflexhome/goflexhome.h new file +47 -0
new file mode 100644
index 0000000..2af2596
@@ -0,0 +1,47 @@
+/*
+ * Copyright (C) 2013 Suriyan Ramasami <[email protected]>
+ *
+ * Based on dockstar.h originally written by
+ * Copyright (C) 2010  Eric C. Cooper <[email protected]>
+ *
+ * Based on sheevaplug.h originally written by
+ * Prafulla Wadaskar <[email protected]>
+ * (C) Copyright 2009
+ * Marvell Semiconductor <www.marvell.com>
+ *
+ * See file CREDITS for list of people who contributed to this
+ * project.
+ *
+ * This program is free software; you can redistribute it and/or
+ * modify it under the terms of the GNU General Public License as
+ * published by the Free Software Foundation; either version 2 of
+ * the License, or (at your option) any later version.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
+ * GNU General Public License for more details.
+ *
+ * You should have received a copy of the GNU General Public License
+ * along with this program; if not, write to the Free Software
+ * Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston,
+ * MA 02110-1301 USA
+ */
+
+#ifndef __GOFLEXHOME_H
+#define __GOFLEXHOME_H
+
+#define GOFLEXHOME_OE_LOW		(~(0))
+#define GOFLEXHOME_OE_HIGH		(~(0))
+#define GOFLEXHOME_OE_VAL_LOW		(1 << 29)	/* USB_PWEN low */
+#define GOFLEXHOME_OE_VAL_HIGH		(1 << 17)	/* LED pin high */
+
+/* PHY related */
+#define MV88E1116_LED_FCTRL_REG		10
+#define MV88E1116_CPRSP_CR3_REG		21
+#define MV88E1116_MAC_CTRL_REG		21
+#define MV88E1116_PGADR_REG		22
+#define MV88E1116_RGMII_TXTM_CTRL	(1 << 4)
+#define MV88E1116_RGMII_RXTM_CTRL	(1 << 5)
+
+#endif /* __GOFLEXHOME_H */
board/Seagate/goflexhome/kwbimage.cfg new file +168 -0
new file mode 100644
index 0000000..e984d72
@@ -0,0 +1,168 @@
+#
+# Copyright (C) 2013 Suriyan Ramasami <[email protected]>
+#
+# Based on dockstar/kwbimage.cfg originally written by
+# Copyright (C) 2010  Eric C. Cooper <[email protected]>
+#
+# Based on sheevaplug/kwbimage.cfg originally written by
+# Prafulla Wadaskar <[email protected]>
+# (C) Copyright 2009
+# Marvell Semiconductor <www.marvell.com>
+#
+# See file CREDITS for list of people who contributed to this
+# project.
+#
+# This program is free software; you can redistribute it and/or
+# modify it under the terms of the GNU General Public License as
+# published by the Free Software Foundation; either version 2 of
+# the License, or (at your option) any later version.
+#
+# This program is distributed in the hope that it will be useful,
+# but WITHOUT ANY WARRANTY; without even the implied warranty of
+# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
+# GNU General Public License for more details.
+#
+# You should have received a copy of the GNU General Public License
+# along with this program; if not, write to the Free Software
+# Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston,
+# MA 02110-1301 USA
+#
+# Refer docs/README.kwimage for more details about how-to configure
+# and create kirkwood boot image
+#
+
+# Boot Media configurations
+BOOT_FROM	nand
+NAND_ECC_MODE	default
+NAND_PAGE_SIZE	0x0800
+
+# SOC registers configuration using bootrom header extension
+# Maximum KWBIMAGE_MAX_CONFIG configurations allowed
+
+# Configure RGMII-0 interface pad voltage to 1.8V
+DATA 0xFFD100e0 0x1b1b1b9b
+
+#Dram initalization for SINGLE x16 CL=5 @ 400MHz
+DATA 0xFFD01400 0x43000c30	# DDR Configuration register
+# bit13-0:  0xc30 (3120 DDR2 clks refresh rate)
+# bit23-14: zero
+# bit24: 1= enable exit self refresh mode on DDR access
+# bit25: 1 required
+# bit29-26: zero
+# bit31-30: 01
+
+DATA 0xFFD01404 0x37543000	# DDR Controller Control Low
+# bit 4:    0=addr/cmd in smame cycle
+# bit 5:    0=clk is driven during self refresh, we don't care for APX
+# bit 6:    0=use recommended falling edge of clk for addr/cmd
+# bit14:    0=input buffer always powered up
+# bit18:    1=cpu lock transaction enabled
+# bit23-20: 5=recommended value for CL=5 and STARTBURST_DEL disabled bit31=0
+# bit27-24: 7= CL+2, STARTBURST sample stages, for freqs 400MHz, unbuffered DIMM
+# bit30-28: 3 required
+# bit31:    0=no additional STARTBURST delay
+
+DATA 0xFFD01408 0x22125451	# DDR Timing (Low) (active cycles value +1)
+# bit3-0:   TRAS lsbs
+# bit7-4:   TRCD
+# bit11- 8: TRP
+# bit15-12: TWR
+# bit19-16: TWTR
+# bit20:    TRAS msb
+# bit23-21: 0x0
+# bit27-24: TRRD
+# bit31-28: TRTP
+
+DATA 0xFFD0140C 0x00000a33	#  DDR Timing (High)
+# bit6-0:   TRFC
+# bit8-7:   TR2R
+# bit10-9:  TR2W
+# bit12-11: TW2W
+# bit31-13: zero required
+
+DATA 0xFFD01410 0x0000000d	#  DDR Address Control
+# bit1-0:   00, Cs0width=x8
+# bit3-2:   11, Cs0size=1Gb
+# bit5-4:   00, Cs1width=nonexistent
+# bit7-6:   00, Cs1size =nonexistent
+# bit9-8:   00, Cs2width=nonexistent
+# bit11-10: 00, Cs2size =nonexistent
+# bit13-12: 00, Cs3width=nonexistent
+# bit15-14: 00, Cs3size =nonexistent
+# bit16:    0,  Cs0AddrSel
+# bit17:    0,  Cs1AddrSel
+# bit18:    0,  Cs2AddrSel
+# bit19:    0,  Cs3AddrSel
+# bit31-20: 0 required
+
+DATA 0xFFD01414 0x00000000	#  DDR Open Pages Control
+# bit0:    0,  OpenPage enabled
+# bit31-1: 0 required
+
+DATA 0xFFD01418 0x00000000	#  DDR Operation
+# bit3-0:   0x0, DDR cmd
+# bit31-4:  0 required
+
+DATA 0xFFD0141C 0x00000C52	#  DDR Mode
+# bit2-0:   2, BurstLen=2 required
+# bit3:     0, BurstType=0 required
+# bit6-4:   4, CL=5
+# bit7:     0, TestMode=0 normal
+# bit8:     0, DLL reset=0 normal
+# bit11-9:  6, auto-precharge write recovery ????????????
+# bit12:    0, PD must be zero
+# bit31-13: 0 required
+
+DATA 0xFFD01420 0x00000040	#  DDR Extended Mode
+# bit0:    0,  DDR DLL enabled
+# bit1:    0,  DDR drive strenght normal
+# bit2:    0,  DDR ODT control lsd (disabled)
+# bit5-3:  000, required
+# bit6:    1,  DDR ODT control msb, (disabled)
+# bit9-7:  000, required
+# bit10:   0,  differential DQS enabled
+# bit11:   0, required
+# bit12:   0, DDR output buffer enabled
+# bit31-13: 0 required
+
+DATA 0xFFD01424 0x0000F17F	#  DDR Controller Control High
+# bit2-0:  111, required
+# bit3  :  1  , MBUS Burst Chop disabled
+# bit6-4:  111, required
+# bit7  :  0
+# bit8  :  1  , add writepath sample stage, must be 1 for DDR freq >= 300MHz
+# bit9  :  0  , no half clock cycle addition to dataout
+# bit10 :  0  , 1/4 clock cycle skew enabled for addr/ctl signals
+# bit11 :  0  , 1/4 clock cycle skew disabled for write mesh
+# bit15-12: 1111 required
+# bit31-16: 0    required
+
+DATA 0xFFD01428 0x00085520	# DDR2 ODT Read Timing (default values)
+DATA 0xFFD0147C 0x00008552	# DDR2 ODT Write Timing (default values)
+
+DATA 0xFFD01500 0x00000000	# CS[0]n Base address to 0x0
+DATA 0xFFD01504 0x07FFFFF1	# CS[0]n Size
+# bit0:    1,  Window enabled
+# bit1:    0,  Write Protect disabled
+# bit3-2:  00, CS0 hit selected
+# bit23-4: ones, required
+# bit31-24: 0x07, Size (i.e. 128MB)
+
+DATA 0xFFD01508 0x10000000	# CS[1]n Base address to 256Mb
+DATA 0xFFD0150C 0x00000000	# CS[1]n Size, window disabled
+
+DATA 0xFFD01514 0x00000000	# CS[2]n Size, window disabled
+DATA 0xFFD0151C 0x00000000	# CS[3]n Size, window disabled
+
+DATA 0xFFD01494 0x00030000	#  DDR ODT Control (Low)
+DATA 0xFFD01498 0x00000000	#  DDR ODT Control (High)
+# bit1-0:  00, ODT0 controlled by ODT Control (low) register above
+# bit3-2:  01, ODT1 active NEVER!
+# bit31-4: zero, required
+
+DATA 0xFFD0149C 0x0000E803	# CPU ODT Control
+DATA 0xFFD01480 0x00000001	# DDR Initialization Control
+#bit0=1, enable DDR init upon this register write
+
+# End of Header extension
+DATA 0x0 0x0
boards.cfg +1 -0
index 5fc70be..d6f8593 100644
@@ -184,6 +184,7 @@ rd6281a                      arm         arm926ejs   -                   Marvell
 sheevaplug                   arm         arm926ejs   -                   Marvell        kirkwood
 ib62x0                       arm         arm926ejs   ib62x0              raidsonic      kirkwood
 dockstar                     arm         arm926ejs   -                   Seagate        kirkwood
+goflexhome                   arm         arm926ejs   -                   Seagate        kirkwood
 tk71                         arm         arm926ejs   tk71                karo           kirkwood
 devkit3250                   arm         arm926ejs   devkit3250          timll          lpc32xx
 jadecpu                      arm         arm926ejs   jadecpu             syteco         mb86r0x
include/configs/goflexhome.h new file +125 -0
new file mode 100644
index 0000000..16ad12a
@@ -0,0 +1,135 @@
+/*
+ * Copyright (C) 2013 Suriyan Ramasami <[email protected]>
+ *
+ * Based on dockstar.h originally written by
+ * Copyright (C) 2010  Eric C. Cooper <[email protected]>
+ *
+ * Based on sheevaplug.h originally written by
+ * Prafulla Wadaskar <[email protected]>
+ * (C) Copyright 2009
+ * Marvell Semiconductor <www.marvell.com>
+ *
+ * See file CREDITS for list of people who contributed to this
+ * project.
+ *
+ * This program is free software; you can redistribute it and/or
+ * modify it under the terms of the GNU General Public License as
+ * published by the Free Software Foundation; either version 2 of
+ * the License, or (at your option) any later version.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
+ * GNU General Public License for more details.
+ *
+ * You should have received a copy of the GNU General Public License
+ * along with this program; if not, write to the Free Software
+ * Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston,
+ * MA 02110-1301 USA
+ */
+
+#ifndef _CONFIG_GOFLEXHOME_H
+#define _CONFIG_GOFLEXHOME_H
+
+/*
+ * Version number information
+ */
+#define CONFIG_IDENT_STRING	"\nSeagate GoFlex Home"
+
+/*
+ * High Level Configuration Options (easy to change)
+ */
+#define CONFIG_FEROCEON_88FR131	1	/* CPU Core subversion */
+#define CONFIG_KIRKWOOD		1	/* SOC Family Name */
+#define CONFIG_KW88F6281	1	/* SOC Name */
+#define CONFIG_MACH_GOFLEXHOME		/* Machine type */
+#define CONFIG_SKIP_LOWLEVEL_INIT	/* disable board lowlevel_init */
+
+/*
+ * Commands configuration
+ */
+#define CONFIG_SYS_NO_FLASH		/* Declare no flash (NOR/SPI) */
+#define CONFIG_CONSOLE_MUX
+#define CONFIG_SYS_CONSOLE_IS_IN_ENV
+
+#include <config_cmd_default.h>
+#define CONFIG_CMD_DHCP
+#define CONFIG_CMD_ENV
+#define CONFIG_CMD_MII
+#define CONFIG_CMD_NAND
+#define CONFIG_CMD_PING
+#define CONFIG_CMD_USB
+#define CONFIG_CMD_IDE
+#define CONFIG_CMD_DATE
+#define CONFIG_CMD_EXT4
+#define CONFIG_SYS_MVFS         /* Picks up Filesystem from mv-common.h */
+
+/*
+ * mv-common.h should be defined after CMD configs since it used them
+ * to enable certain macros
+ */
+#include "mv-common.h"
+
+#undef CONFIG_SYS_PROMPT	/* previously defined in mv-common.h */
+#define CONFIG_SYS_PROMPT	"GoFlexHome> "	/* Command Prompt */
+
+/*
+ *  Environment variables configurations
+ */
+#ifdef CONFIG_CMD_NAND
+#define CONFIG_ENV_IS_IN_NAND		1
+#define CONFIG_ENV_SECT_SIZE		0x20000	/* 128K */
+#else
+#define CONFIG_ENV_IS_NOWHERE		1	/* if env in SDRAM */
+#endif
+/*
+ * max 4k env size is enough, but in case of nand
+ * it has to be rounded to sector size
+ */
+#define CONFIG_ENV_SIZE			0x20000	/* 128k */
+#define CONFIG_ENV_ADDR			0xC0000
+#define CONFIG_ENV_OFFSET		0xC0000	/* env starts here */
+
+/*
+ * Default environment variables
+ */
+#define CONFIG_BOOTCOMMAND \
+	"setenv bootargs ${console} ${mtdparts} ${bootargs_root}; " \
+	"ubi part root; " \
+	"ubifsmount ubi:root; " \
+	"ubifsload 0x800000 ${kernel}; " \
+	"bootm 0x800000"
+
+#define CONFIG_MTDPARTS \
+	"mtdparts=orion_nand:1m(uboot),6M(uImage),-(root)\0"
+
+#define CONFIG_EXTRA_ENV_SETTINGS \
+	"console=console=ttyS0,115200\0" \
+	"mtdids=nand0=orion_nand\0" \
+	"mtdparts="CONFIG_MTDPARTS \
+	"kernel=/boot/uImage\0" \
+	"bootargs_root=ubi.mtd=root root=ubi0:root rootfstype=ubifs ro\0"
+
+/*
+ * Ethernet Driver configuration
+ */
+#ifdef CONFIG_CMD_NET
+#define CONFIG_MVGBE_PORTS	{1, 0}	/* enable port 0 only */
+#define CONFIG_PHY_BASE_ADR	0
+#endif /* CONFIG_CMD_NET */
+
+/*
+ *  * SATA Driver configuration
+ *   */
+#ifdef CONFIG_MVSATA_IDE
+#define CONFIG_SYS_ATA_IDE0_OFFSET      MV_SATA_PORT0_OFFSET

include/configs/goflexhome.h line 135

Quoted 10 lines
include/configs/goflexhome.h new file +10 -0
+#endif /*CONFIG_MVSATA_IDE*/
+
+/*
+ *  * RTC driver configuration
+ *   */
+#ifdef CONFIG_CMD_DATE
+#define CONFIG_RTC_MV
+#endif /* CONFIG_CMD_DATE */
+
+#endif /* _CONFIG_GOFLEXHOME_H */

Amicalement,

Signature · 1 line
Albert.
#2 lore raw

PATCH v3 1/1 ARM: Add support for Seagate GoFlexHome

In reply to Suriyan Ramasami

Dear Suriyan Ramasami,

Quoted 3 lines · In message <[email protected]> you wrote:

This is yet another attempt with patch v3.
Thanks to Wolfgang, Prafulla and Albert for comments, corrections, and suggestions.

On addition to the comments already made about how the commit message should be organized and where comments go, here some additional remarks:

Quoted 1 line
board/Seagate/goflexhome/goflexhome.c new file +1 -0
+	static const u32 kwmpp_config[] = {

...

board/Seagate/goflexhome/goflexhome.c line 107

Quoted 2 lines
board/Seagate/goflexhome/goflexhome.c new file +2 -0
+	};
+	kirkwood_mpp_conf(kwmpp_config, NULL);

Please always insert a blank line between declarations and code.

board/Seagate/goflexhome/goflexhome.c line 168

Quoted 5 lines
board/Seagate/goflexhome/goflexhome.c new file +5 -0
+static void set_leds(u32 leds, u32 blinking)
+{
+	struct kwgpio_registers *r = (struct kwgpio_registers *)KW_GPIO1_BASE;
+	u32 oe = readl(&r->oe) | BOTH_LEDS;
+	writel(oe & ~leds, &r->oe);	/* active low */

Ditto. Please fix globally.

board/Seagate/goflexhome/goflexhome.c line 169

Quoted 1 line
board/Seagate/goflexhome/goflexhome.c new file +1 -0
+	u32 bl = readl(&r->blink_en) & ~BOTH_LEDS;

Please never mix declarations and code. Please fix globally.

board/Seagate/goflexhome/goflexhome.h

Quoted 5 lines
board/Seagate/goflexhome/goflexhome.h new file +0 -0
new file mode 100644
index 0000000..2af2596

What is this file needed for? It appears all this could go into include/configs/goflexhome.h instead?

Best regards,

Wolfgang Denk

Signature · 8 lines
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
"Science makes godlike -- it is all over with priests and  gods  when
man becomes scientific. Moral: science is the forbidden as such -- it
alone  is  forbidden. Science is the *first* sin, the *original* sin.
*This alone is  morality.*  ``Thou  shalt  not  know''  --  the  rest
follows."                                       - Friedrich Nietzsche