Skip to contentSkip to conversation

ARM: imx: Select IRAM_ALLOC

PATCH New Fabio Estevam 1 participant 2 messages Apr 11, 2013

Subsystems (3)
lore
Share & tools
lore

Fabio Estevam

author reviewer
#0 lore raw

PATCH 1/1 ARM: imx: Select IRAM_ALLOC

From: Fabio Estevam <[email protected]>

Since commit 391630c5bf11 (media: coda: use genalloc API) the following build error happens with imx_v4_v5_defconfig:

drivers/built-in.o: In function 'coda_remove':
clk-composite.c:(.text+0x112180): undefined reference to 'gen_pool_free' drivers/built-in.o: In function 'coda_probe':
clk-composite.c:(.text+0x112310): undefined reference to 'of_get_named_gen_pool' clk-composite.c:(.text+0x1123f4): undefined reference to 'gen_pool_alloc' clk-composite.c:(.text+0x11240c): undefined reference to 'gen_pool_virt_to_phys' clk-composite.c:(.text+0x112458): undefined reference to 'dev_get_gen_pool'

Select IRAM_ALLOC on all SoCs that are possible users of the coda driver.

---
 arch/arm/mach-imx/Kconfig |    3 +++
 1 file changed, 3 insertions(+)
arch/arm/mach-imx/Kconfig +3 -0
index 78f795d..a025cf8 100644
@@ -124,6 +124,7 @@ config SOC_IMX27
 	select COMMON_CLK
 	select CPU_ARM926T
 	select IMX_HAVE_IOMUX_V1
+	select IRAM_ALLOC
 	select MACH_MX27
 	select MXC_AVIC
 
@@ -152,6 +153,7 @@ config SOC_IMX5
 	select ARCH_MXC_IOMUX_V3
 	select COMMON_CLK
 	select CPU_V7
+	select IRAM_ALLOC
 	select MXC_TZIC
 
 config	SOC_IMX51
@@ -808,6 +810,7 @@ config SOC_IMX6Q
 	select HAVE_IMX_MMDC
 	select HAVE_IMX_SRC
 	select HAVE_SMP
+	select IRAM_ALLOC
 	select MFD_SYSCON
 	select PINCTRL
 	select PINCTRL_IMX6Q
Signature · 1 line
1.7.9.5
author reviewer
#1 lore raw

PATCH 1/1 ARM: imx: Select IRAM_ALLOC

Quoted 25 lines · Fabio Estevam

From: Fabio Estevam <[email protected]>

Since commit 391630c5bf11 (media: coda: use genalloc API) the following build error happens with imx_v4_v5_defconfig:

drivers/built-in.o: In function 'coda_remove':
clk-composite.c:(.text+0x112180): undefined reference to 'gen_pool_free' drivers/built-in.o: In function 'coda_probe':
clk-composite.c:(.text+0x112310): undefined reference to 'of_get_named_gen_pool' clk-composite.c:(.text+0x1123f4): undefined reference to 'gen_pool_alloc' clk-composite.c:(.text+0x11240c): undefined reference to 'gen_pool_virt_to_phys' clk-composite.c:(.text+0x112458): undefined reference to 'dev_get_gen_pool'

Select IRAM_ALLOC on all SoCs that are possible users of the coda driver.

---
 arch/arm/mach-imx/Kconfig |    3 +++
 1 file changed, 3 insertions(+)
arch/arm/mach-imx/Kconfig +0 -0
index 78f795d..a025cf8 100644

arch/arm/mach-imx/Kconfig config SOC_IMX27 · line 127

Quoted 4 lines
arch/arm/mach-imx/Kconfig +1 -0
@@ -124,6 +124,7 @@ config SOC_IMX27
        select COMMON_CLK
        select CPU_ARM926T
        select IMX_HAVE_IOMUX_V1
+       select IRAM_ALLOC

Actually I think we can remove IRAM_ALLOC completely now in favor of GENERIC_ALLOCATOR.

Will send a new version of the patch.