Skip to contentSkip to conversation

ARM: add Freescale Vybrid family platform and development board support

PATCH Superseded Jingchang Lu 4 participants 7 messages Apr 12, 2013 – Apr 21, 2013

Subsystems (4)

v1 of 2 Superseded Latest is v2 →

lore
Share & tools
lore
#0 lore raw

cover ARM: add Freescale Vybrid family platform and development board support

Freescale Vybrid family microprocessors are built on
an asymmetrical-multiprocessing architecture using ARM Cortex-A5 and Cortex-M4. These series contain the support for MVF600 Soc and Vybrid Tower development board.

----------------------------------------------------------------
Jingchang Lu (3):
ARM/MVF600: add Vybrid Family platform support ARM:DTS:MVF600: add basic device tree source
pinctrl: add MVF pinctrl driver

 Documentation/devicetree/bindings/pinctrl/fsl,mvf-pinctrl.txt |  825 ++++++++++++
 arch/arm/boot/dts/imx-mvf600.dtsi                             |  442 +++++++
 arch/arm/boot/dts/imx-mvf600twr.dts                           |   82 ++
 arch/arm/mach-imx/Kconfig                                     |   39 +
 arch/arm/mach-imx/Makefile                                    |    4 +
 arch/arm/mach-imx/Makefile.boot                               |    4 +
 arch/arm/mach-imx/clk-mvf.c                                   |  320 +++++
 arch/arm/mach-imx/common.h                                    |    3 +
 arch/arm/mach-imx/mach-mvf600.c                               |  121 ++
 arch/arm/mach-imx/pit.c                                       |  254 ++++
 drivers/pinctrl/Kconfig                                       |    8 +
 drivers/pinctrl/Makefile                                      |    1 +
 drivers/pinctrl/pinctrl-mvf.c                                 | 2042 +++++++++++++++++++++++++++++
 13 files changed, 4145 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/pinctrl/fsl,mvf-pinctrl.txt
 create mode 100644 arch/arm/boot/dts/imx-mvf600.dtsi
 create mode 100644 arch/arm/boot/dts/imx-mvf600twr.dts
 create mode 100644 arch/arm/mach-imx/clk-mvf.c
 create mode 100644 arch/arm/mach-imx/mach-mvf600.c
 create mode 100644 arch/arm/mach-imx/pit.c
 create mode 100644 drivers/pinctrl/pinctrl-mvf.c
#1 lore raw

PATCH 1/3 ARM/MVF600: add Vybrid Family platform support

This patch adds Freescale Vybrid Family platform core definitions, core drivers including clock, period interrupt timer(PIT), and DTS based machine support with MVF600 Tower development board.

---
 arch/arm/mach-imx/Kconfig       |  39 +++++
 arch/arm/mach-imx/Makefile      |   4 +
 arch/arm/mach-imx/Makefile.boot |   4 +
 arch/arm/mach-imx/clk-mvf.c     | 320 ++++++++++++++++++++++++++++++++++++++++
 arch/arm/mach-imx/common.h      |   3 +
 arch/arm/mach-imx/mach-mvf600.c | 121 +++++++++++++++
 arch/arm/mach-imx/pit.c         | 254 +++++++++++++++++++++++++++++++
 7 files changed, 745 insertions(+)
 create mode 100644 arch/arm/mach-imx/clk-mvf.c
 create mode 100644 arch/arm/mach-imx/mach-mvf600.c
 create mode 100644 arch/arm/mach-imx/pit.c
arch/arm/mach-imx/Kconfig +39 -0
index 4c9c6f9..173258b 100644
@@ -55,6 +55,16 @@ config MXC_USE_EPIT
 	  uses the same clocks as the GPT. Anyway, on some systems the GPT
 	  may be in use for other purposes.
 
+config HAVE_PIT
+	bool
+
+config MXC_USE_PIT
+	bool "Use PIT"
+	depends on HAVE_PIT
+	help
+          Use PIT as the system timer on systems that have it
+	  such as Vybrid platform.
+
 config MXC_ULPI
 	bool
 
@@ -101,6 +111,9 @@ config ARCH_MX51
 config ARCH_MX53
 	bool
 
+config ARCH_MVF
+	bool
+
 config SOC_IMX1
 	bool
 	select ARCH_MX1
@@ -169,6 +182,24 @@ config	SOC_IMX51
 	select PINCTRL_IMX51
 	select SOC_IMX5
 
+config SOC_MVF
+	bool
+
+config SOC_MVF600
+	bool
+	select CPU_V7
+	select ARM_GIC
+	select COMMON_CLK
+	select ARCH_MVF
+	select SOC_MVF
+	select HAVE_PIT
+	select MXC_USE_PIT
+	select PINCTRL
+	select PINCTRL_MVF
+	select PL310_ERRATA_588369 if CACHE_PL310
+	select PL310_ERRATA_727915 if CACHE_PL310
+	select PL310_ERRATA_769419 if CACHE_PL310
+
 if ARCH_MULTI_V4T
 
 comment "MX1 platforms:"
@@ -828,6 +859,14 @@ config SOC_IMX6Q
 	help
 	  This enables support for Freescale i.MX6 Quad processor.
 
+config MACH_MVF600_TWR
+	bool "Vybrid MVF600 Tower support"
+	select SOC_MVF600
+
+	help
+          Include support for Freescale Vybrid Family Tower Board
+	  based on MVF600 SOC.
+
 endif
 
 source "arch/arm/mach-imx/devices/Kconfig"
arch/arm/mach-imx/Makefile +4 -0
index c4ce090..e8502f1 100644
@@ -26,6 +26,7 @@ obj-$(CONFIG_MXC_AVIC) += avic.o
 obj-$(CONFIG_IRAM_ALLOC) += iram_alloc.o
 obj-$(CONFIG_MXC_ULPI) += ulpi.o
 obj-$(CONFIG_MXC_USE_EPIT) += epit.o
+obj-$(CONFIG_MXC_USE_PIT) += pit.o
 obj-$(CONFIG_MXC_DEBUG_BOARD) += 3ds_debugboard.o
 obj-$(CONFIG_CPU_FREQ_IMX)    += cpufreq.o
 
@@ -112,4 +113,7 @@ obj-$(CONFIG_MACH_EUKREA_MBIMXSD51_BASEBOARD) += eukrea_mbimxsd51-baseboard.o
 obj-$(CONFIG_MACH_IMX51_DT) += imx51-dt.o
 obj-$(CONFIG_SOC_IMX53) += mach-imx53.o
 
+# Vybrid based machines
+obj-$(CONFIG_SOC_MVF600) += clk-mvf.o mach-mvf600.o
+
 obj-y += devices/
arch/arm/mach-imx/Makefile.boot +4 -0
index 41ba1bb..5551acf 100644
@@ -33,3 +33,7 @@ initrd_phys-$(CONFIG_SOC_IMX53)	:= 0x70800000
 zreladdr-$(CONFIG_SOC_IMX6Q)	+= 0x10008000
 params_phys-$(CONFIG_SOC_IMX6Q)	:= 0x10000100
 initrd_phys-$(CONFIG_SOC_IMX6Q)	:= 0x10800000
+
+zreladdr-$(CONFIG_SOC_MVF)	:= 0x80008000
+params_phys-$(CONFIG_SOC_MVF)	:= 0x80000100
+initrd_phys-$(CONFIG_SOC_MVF)	:= 0x80800000
arch/arm/mach-imx/clk-mvf.c new file +320 -0

320 lines not on this page · raw message

arch/arm/mach-imx/common.h +3 -0
index 5bf4a97..dba5b10 100644
@@ -41,6 +41,7 @@ extern void mx31_init_irq(void);
 extern void mx35_init_irq(void);
 extern void mx51_init_irq(void);
 extern void mx53_init_irq(void);
+extern void mvf_init_irq(void);
 extern void imx1_soc_init(void);
 extern void imx21_soc_init(void);
 extern void imx25_soc_init(void);
@@ -51,6 +52,7 @@ extern void imx51_soc_init(void);
 extern void imx51_init_late(void);
 extern void imx53_init_late(void);
 extern void epit_timer_init(void __iomem *base, int irq);
+extern void pit_timer_init(void __iomem *base, int irq);
 extern void mxc_timer_init(void __iomem *, int);
 extern int mx1_clocks_init(unsigned long fref);
 extern int mx21_clocks_init(unsigned long lref, unsigned long fref);
@@ -68,6 +70,7 @@ extern int mx31_clocks_init_dt(void);
 extern int mx51_clocks_init_dt(void);
 extern int mx53_clocks_init_dt(void);
 extern int mx6q_clocks_init(void);
+extern int mvf_clocks_init(void);
 extern struct platform_device *mxc_register_gpio(char *name, int id,
 	resource_size_t iobase, resource_size_t iosize, int irq, int irq_high);
 extern void mxc_set_cpu_type(unsigned int type);
arch/arm/mach-imx/mach-mvf600.c new file +121 -0

121 lines not on this page · raw message

arch/arm/mach-imx/pit.c new file +254 -0

254 lines not on this page · raw message

Signature · 1 line
1.8.0
maintainer
#2 lore raw

PATCH 1/3 ARM/MVF600: add Vybrid Family platform support

Hi,

Some comments inline.

Quoted 25 lines · Jingchang Lu

This patch adds Freescale Vybrid Family platform core definitions, core drivers including clock, period interrupt timer(PIT), and DTS based machine support with MVF600 Tower development board.

---
 arch/arm/mach-imx/Kconfig       |  39 +++++
 arch/arm/mach-imx/Makefile      |   4 +
 arch/arm/mach-imx/Makefile.boot |   4 +
 arch/arm/mach-imx/clk-mvf.c     | 320 ++++++++++++++++++++++++++++++++++++++++
 arch/arm/mach-imx/common.h      |   3 +
 arch/arm/mach-imx/mach-mvf600.c | 121 +++++++++++++++
 arch/arm/mach-imx/pit.c         | 254 +++++++++++++++++++++++++++++++
 7 files changed, 745 insertions(+)
 create mode 100644 arch/arm/mach-imx/clk-mvf.c
 create mode 100644 arch/arm/mach-imx/mach-mvf600.c
 create mode 100644 arch/arm/mach-imx/pit.c
arch/arm/mach-imx/Kconfig +0 -0
index 4c9c6f9..173258b 100644
@@ -55,6 +55,16 @@ config MXC_USE_EPIT
 	  uses the same clocks as the GPT. Anyway, on some systems the GPT
 	  may be in use for other purposes.

arch/arm/mach-imx/Kconfig config MXC_USE_EPIT · line 66

Quoted 10 lines
arch/arm/mach-imx/Kconfig +9 -0
 
+config HAVE_PIT
+	bool
+
+config MXC_USE_PIT
+	bool "Use PIT"
+	depends on HAVE_PIT
+	help
+          Use PIT as the system timer on systems that have it
+	  such as Vybrid platform.

Indention broken here.

arch/arm/mach-imx/Kconfig config SOC_IMX6Q · line 868

Quoted 7 lines
arch/arm/mach-imx/Kconfig +7 -0
+config MACH_MVF600_TWR
+	bool "Vybrid MVF600 Tower support"
+	select SOC_MVF600
+
+	help
+          Include support for Freescale Vybrid Family Tower Board
+	  based on MVF600 SOC.

and here.

Quoted 4 lines

+
endif

source "arch/arm/mach-imx/devices/Kconfig"

[...]

Quoted 8 lines

+++ b/arch/arm/mach-imx/clk-mvf.c

arch/arm/mach-imx/Kconfig +6 -0
@@ -0,0 +1,320 @@
+/*
+ * Copyright 2012-2013 Freescale Semiconductor, Inc.
+ *
+ * This program is free software; you can redistribute it and/or modify
+ * it under the terms of the GNU General Public License as published by
+ * the Free Software Foundation; either version 2 of the License, or

arch/arm/mach-imx/Kconfig line 16

Quoted 10 lines
arch/arm/mach-imx/Kconfig +10 -0
+ * (at your option) any later version.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+ * GNU General Public License for more details.
+ *
+ * You should have received a copy of the GNU General Public License along
+ * with this program; if not, write to the Free Software Foundation, Inc.,
+ * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA.

Please remove the FSF address. It's wrong and we don't want to keep it up to date in the kernel.

Quoted 15 lines
arch/arm/mach-imx/Kconfig +15 -0
+int __init mvf_clocks_init(void)
+{
+	struct device_node *np;
+	__iomem void *base;
+	int irq;
+
+	clk[dummy] = imx_clk_fixed("dummy", 0);
+	clk[sirc] = imx_clk_fixed("sirc", 32000); /* slow internal IRC */
+	clk[firc] = imx_clk_fixed("firc", 24000000);/* fast internal IRC */
+
+	for_each_compatible_node(np, NULL, "fixed-clock") {
+		u32 rate;
+
+		if (of_property_read_u32(np, "clock-frequency", &rate))
+			continue;

arch/arm/mach-imx/Kconfig line 41

Quoted 10 lines
arch/arm/mach-imx/Kconfig +10 -0
+		if (of_device_is_compatible(np, "fsl,mvf-ckil"))
+			clk[sxosc] = imx_clk_fixed("sxosc", rate);
+		else if (of_device_is_compatible(np, "fsl,mvf-osc"))
+			clk[fxosc] = imx_clk_fixed("fxosc", rate);
+		else if (of_device_is_compatible(np, "fsl,mvf-audio-ext-clk"))
+			clk[audio_ext_clk] =
+					imx_clk_fixed("audio_ext_clk", rate);
+		else if (of_device_is_compatible(np, "fsl,mvf-enet-ext-clk"))
+			clk[enet_ext_clk] = imx_clk_fixed("enet_ext", rate);
+	}

Rather than doing it this way you should use some variables which you initialize to sane defaults and overwrite them as necessary in the for_each_compatible_node loop. This way you won't end up with unitialized clocks when some clock is missing in the devicetree.

Quoted 25 lines
arch/arm/mach-imx/Kconfig +25 -0
+
+	np = of_find_compatible_node(NULL, NULL, "fsl,mvf-anatop");
+	anatop_base = of_iomap(np, 0);
+	WARN_ON(!anatop_base);
+
+	np = of_find_compatible_node(NULL, NULL, "fsl,mvf-ccm");
+	ccm_base = of_iomap(np, 0);
+	WARN_ON(!ccm_base);
+
+	clk[slow_clk] = imx_clk_mux("slow_clk", CCM_CCSR, 4, 1,
+			slow_clk_sel, ARRAY_SIZE(slow_clk_sel));
+	clk[fast_clk] = imx_clk_mux("fast_clk", CCM_CCSR, 5, 1,
+			fast_clk_sel, ARRAY_SIZE(fast_clk_sel));
+
+	clk[pll1_main_528m] = imx_clk_fixed_factor("pll1_main",
+						"fast_clk", 22, 1);
+	clk[pll1_pfd1_500m] = imx_clk_pfd("pll1_pfd1", "pll1_main",
+						PFD_528SYS_BASE, 0);
+	clk[pll1_pfd2_452m] = imx_clk_pfd("pll1_pfd2", "pll1_main",
+						PFD_528SYS_BASE, 1);
+	clk[pll1_pfd3_396m] = imx_clk_pfd("pll1_pfd3", "pll1_main",
+						PFD_528SYS_BASE, 2);
+	clk[pll1_pfd4_528m] = imx_clk_pfd("pll1_pfd4", "pll1_main",
+						PFD_528SYS_BASE, 3);
+

arch/arm/mach-imx/Kconfig line 76

Quoted 10 lines
arch/arm/mach-imx/Kconfig +10 -0
+	clk[pll2_main_528m] = imx_clk_fixed_factor("pll2_main",
+						"fast_clk", 22, 1);
+	clk[pll2_pfd1_500m] = imx_clk_pfd("pll2_pfd1", "pll2_main",
+						PFD_528_BASE, 0);
+	clk[pll2_pfd2_396m] = imx_clk_pfd("pll2_pfd2", "pll2_main",
+						PFD_528_BASE, 1);
+	clk[pll2_pfd3_339m] = imx_clk_pfd("pll2_pfd3", "pll2_main",
+						PFD_528_BASE, 2);
+	clk[pll2_pfd4_413m] = imx_clk_pfd("pll2_pfd4", "pll2_main",
+						PFD_528_BASE, 3);

I suggest ignoring the 80 character limit for most of this file. It will make for better readability.

Quoted 60 lines
arch/arm/mach-imx/Kconfig +60 -0
+
+	/* USB pll, 480Mhz */
+	clk[pll3_main_480m] = imx_clk_fixed_factor("usb_main",
+						"fast_clk", 20, 1);
+	/* Audio pll */
+	clk[pll4_main] = imx_clk_fixed_factor("audio_main", "fast_clk", 25, 1);
+	/* Enet pll, fixed to 50Mhz on Vybrid */
+	clk[pll5_main] = imx_clk_fixed_factor("pll5_main", "fast_clk", 125, 6);
+	clk[enet_50m] = imx_clk_fixed_factor("enet_50m", "pll5_main", 1, 10);
+	clk[enet_25m] = imx_clk_fixed_factor("enet_25m", "pll5_main", 1, 20);
+	/* Video pll: default 960Mhz */
+	clk[pll6_main] = imx_clk_fixed_factor("video_main", "fast_clk", 40, 1);
+
+	clk[pll1_pfd_sw] = imx_clk_mux("pll1_sw", CCM_CCSR, 16, 3,
+			pll1_pfd_sel, ARRAY_SIZE(pll1_pfd_sel));
+
+	clk[pll2_pfd_sw] = imx_clk_mux("pll2_sw", CCM_CCSR, 19, 3,
+			pll2_pfd_sel, ARRAY_SIZE(pll2_pfd_sel));
+
+	clk[sys_clk_sw] = imx_clk_mux("sys_sw", CCM_CCSR, 0, 3,
+			sys_clk_sel, ARRAY_SIZE(sys_clk_sel));
+
+	clk[ddr_clk_sw] = imx_clk_mux("ddr_sw", CCM_CCSR, 6, 1,
+			ddr_clk_sel, ARRAY_SIZE(ddr_clk_sel));
+
+	clk[sys_bus_clk] = imx_clk_divider("sys_bus", "sys_sw",
+						CCM_CACRR, 0, 3);
+	clk[platform_bus_clk] = imx_clk_divider("platform_bus", "sys_bus",
+						CCM_CACRR, 3, 3);
+	clk[ipg_bus_clk] = imx_clk_divider("ipg_bus", "platform_bus",
+						CCM_CACRR, 11, 2);
+
+	clk[qspi0_clk_sw] = imx_clk_mux("qspi0_sw", CCM_CSCMR1, 22, 2,
+					qspi_clk_sel, ARRAY_SIZE(qspi_clk_sel));
+	clk[qspi0_x4_div] = imx_clk_divider("qspi0_x4", "qspi0_sw",
+						CCM_CSCDR3, 0, 2);
+	clk[qspi0_x2_div] = imx_clk_divider("qspi0_x2", "qspi0_x4",
+						CCM_CSCDR3, 2, 1);
+	clk[qspi0_x1_div] = imx_clk_divider("qspi0_x1", "qspi0_x2",
+					CCM_CSCDR3, 3, 1);
+	clk[qspi0_clk_gate] = imx_clk_gate("qspi0_clk", "qspi0_x1",
+					CCM_CSCDR3, 4);
+
+	clk[enet_clk_sw] = imx_clk_mux("enet_sw", CCM_CSCMR2, 4, 2,
+				rmii_clk_sel, ARRAY_SIZE(rmii_clk_sel));
+	clk[enet_clk_gate] = imx_clk_gate("enet_clk", "enet_sw",
+				CCM_CSCDR1, 24);
+	clk[enet_ts_sw] = imx_clk_mux("enet_ts_sw", CCM_CSCMR2, 0, 3,
+				enet_ts_clk_sel, ARRAY_SIZE(enet_ts_clk_sel));
+	clk[enet_ts_gate] = imx_clk_gate("enet_ts_clk", "enet_ts_sw",
+				CCM_CSCDR1, 23);
+
+	clk[pit_clk_gate] = imx_clk_gate2("pit_clk", "ipg_bus", CCM_CCGR1,
+						CCM_CCGRx_CGn_OFFSET(7));
+	clk[uart0_clk_gate] = imx_clk_gate2("uart0_clk", "ipg_bus", CCM_CCGR0,
+						CCM_CCGRx_CGn_OFFSET(7));
+
+	/* Add the clocks to provider list */
+	clk_data.clks = clk;
+	clk_data.clk_num = ARRAY_SIZE(clk);

arch/arm/mach-imx/Kconfig line 146

Quoted 10 lines
arch/arm/mach-imx/Kconfig +10 -0
+	of_clk_add_provider(np, of_clk_src_onecell_get, &clk_data);
+
+	clk_register_clkdev(clk[pit_clk_gate], "mvf-pit", NULL);
+	clk_register_clkdev(clk[uart0_clk_gate], "mvf-uart", NULL);
+	clk_register_clkdev(clk[uart0_clk_gate], "mvf_uart.0", NULL);
+	clk_register_clkdev(clk[uart0_clk_gate], "mvf_uart.1", NULL);
+	clk_register_clkdev(clk[enet_clk_gate], "fec.0", NULL);
+	clk_register_clkdev(clk[enet_clk_gate], "fec.1", NULL);
+	clk_register_clkdev(clk[enet_clk_gate], "switch.0", NULL);
+	clk_register_clkdev(clk[qspi0_clk_gate], "qspi.0", NULL);

These shouldn't be here. You have the lookups in the devicetree anyway.

arch/arm/mach-imx/Kconfig line 158

Quoted 12 lines
arch/arm/mach-imx/Kconfig +12 -0
+
+	clk_set_parent(clk[qspi0_x4_div], clk[pll1_pfd4_528m]);
+	clk_set_rate(clk[qspi0_x4_div],
+			clk_get_rate(clk[qspi0_x4_div]->parent) / 2);
+	clk_set_rate(clk[qspi0_x2_div],
+			clk_get_rate(clk[qspi0_x2_div]->parent) / 2);
+	clk_set_rate(clk[qspi0_x1_div],
+			clk_get_rate(clk[qspi0_x1_div]->parent) / 2);
+
+
+	clk_prepare(clk[pit_clk_gate]);
+	clk_prepare(clk[uart0_clk_gate]);

No. Do not enable driver clocks here.

arch/arm/mach-imx/Kconfig line 166

Quoted 8 lines
arch/arm/mach-imx/Kconfig +8 -0
+	clk_prepare(clk[enet_clk_gate]);
+
+	/* init system timer */
+	np = of_find_compatible_node(NULL, NULL, "fsl,mvf-pit");
+	base = of_iomap(np, 0);
+	WARN_ON(!base);
+	irq = irq_of_parse_and_map(np, 0);
+	pit_timer_init(base, irq);

This should be switched to CLOCKSOURCE_OF_DECLARE.

Quoted 3 lines
arch/arm/mach-imx/Kconfig +3 -0
+
+	return 0;
+}

[...]

arch/arm/mach-imx/Kconfig

Quoted 4 lines
arch/arm/mach-imx/Kconfig +4 -0
+
+static struct clock_event_device clockevent_pit = {
+	.name		= "pit",
+	.features	= CLOCK_EVT_FEAT_PERIODIC,

Only periodic support? That's really boring. Why isn't oneshot mode supported?

Quoted 21 lines
arch/arm/mach-imx/Kconfig +21 -0
+	.shift		= 32,
+	.set_mode	= pit_set_mode,
+	.set_next_event	= pit_set_next_event,
+	.rating		= 100,
+};
+
+static int __init pit_clockevent_init(struct clk *pit_clk)
+{
+	unsigned int c = clk_get_rate(pit_clk);
+
+	clockevent_pit.mult = div_sc(c, NSEC_PER_SEC,
+					clockevent_pit.shift);
+	clockevent_pit.max_delta_ns =
+			clockevent_delta2ns(0xfffffffe, &clockevent_pit);
+	clockevent_pit.min_delta_ns =
+			clockevent_delta2ns(0x800, &clockevent_pit);
+	clockevent_pit.cpumask = cpumask_of(0);
+	clockevents_register_device(&clockevent_pit);
+
+	return 0;
+}

arch/arm/mach-imx/Kconfig

Quoted 10 lines
arch/arm/mach-imx/Kconfig +10 -0
+
+void __init pit_timer_init(void __iomem *base, int irq)
+{
+	struct clk *pit_clk;
+
+	pit_clk = clk_get_sys(NULL, "mvf-pit");
+	if (IS_ERR(pit_clk)) {
+		pr_err("Vybrid PIT timer: unable to get clk\n");
+		return;
+	}

base, irq and clk should really be taken from the devicetree. We have all necessary stuff in the kernel (only the i.MX template you copied from doesn't use it yet).

Sascha

Signature · 4 lines
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |
#3 lore raw

PATCH 1/3 ARM/MVF600: add Vybrid Family platform support

In reply to Jingchang Lu

Jingchang Lu <b35083 <at> freescale.com> writes:

Hi- I'm new to participating so please be kind if I break protocol.

Quoted 8 lines
arch/arm/mach-imx/mach-mvf600.c +6 -0
+
+static void __init mvf_of_init_irq(void)
+{
+	struct device_node *np;
+	void __iomem *mscm_base;
+	int i;

arch/arm/mach-imx/mach-mvf600.c line 95

Quoted 10 lines
arch/arm/mach-imx/mach-mvf600.c +10 -0
+
+	l2x0_of_init(0, ~0UL);
+
+	np = of_find_compatible_node(NULL, NULL, "fsl,mvf-mscm");
+	mscm_base = of_iomap(np, 0);
+	if (!mscm_base)
+		return;
+
+	for (i = 0; i < 128; i++)
+		__raw_writew(1, mscm_base + 0x880 + 2 * i);

This is a problem if the M4 core program boots first and routes any interrupts to itself. This should be an OR function with the existing bits so as not to reset M4 bits.

#4 lore raw

PATCH 2/3 ARM:DTS:MVF600: add basic device tree source

In reply to Jingchang Lu

This patch adds basic device tree source for Freescale Vybrid Family platform and Tower development board.

---
 arch/arm/boot/dts/imx-mvf600.dtsi   | 442 ++++++++++++++++++++++++++++++++++++
 arch/arm/boot/dts/imx-mvf600twr.dts |  82 +++++++
 2 files changed, 524 insertions(+)
 create mode 100644 arch/arm/boot/dts/imx-mvf600.dtsi
 create mode 100644 arch/arm/boot/dts/imx-mvf600twr.dts
arch/arm/boot/dts/imx-mvf600.dtsi new file +442 -0
new file mode 100644
index 0000000..3a534c6
@@ -0,0 +1,442 @@
+/*
+ * Copyright 2013 Freescale Semiconductor, Inc.
+ *
+ * This program is free software; you can redistribute it and/or modify
+ * it under the terms of the GNU General Public License as published by
+ * the Free Software Foundation; either version 2 of the License, or
+ * (at your option) any later version.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+ * GNU General Public License for more details.
+ *
+ * You should have received a copy of the GNU General Public License along
+ * with this program; if not, write to the Free Software Foundation, Inc.,
+ * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA.
+ */
+
+/include/ "skeleton.dtsi"
+
+/ {
+	aliases {
+		serial0 = &uart1;
+		serial1 = &uart2;
+		serial2 = &uart3;
+		serial3 = &uart4;
+		serial4 = &uart5;
+		serial5 = &uart6;
+		gpio0 = &gpio1;
+		gpio1 = &gpio2;
+		gpio2 = &gpio3;
+		gpio3 = &gpio4;
+		gpio4 = &gpio5;
+	};
+
+
+	clocks {
+		#address-cells = <1>;
+		#size-cells = <0>;
+
+		ckil {
+			compatible = "fsl,mvf-ckil", "fixed-clock";
+			clock-frequency = <32768>;
+		};
+
+		ckih1 {
+			compatible = "fsl,mvf-ckih1", "fixed-clock";
+			clock-frequency = <0>;
+		};
+
+		osc {
+			compatible = "fsl,mvf-osc", "fixed-clock";
+			clock-frequency = <24000000>;
+		};
+	};
+
+
+	soc {
+		#address-cells = <1>;
+		#size-cells = <1>;
+		compatible = "simple-bus";
+		interrupt-parent = <&intc>;
+		ranges;
+
+		aips0: aips-bus at 40000000 { /* AIPS0 */
+			compatible = "fsl,aips-bus", "simple-bus";
+			#address-cells = <1>;
+			#size-cells = <1>;
+			interrupt-parent = <&intc>;
+			reg = <0x40000000 0x70000>;
+			ranges;
+
+			mscm: mscm at 40001000 {
+				compatible = "fsl,mvf-mscm";
+				reg = <0x40001000 0x1000>;
+			};
+
+			intc: interrupt-controller at 40002000 {
+				compatible = "arm,cortex-a9-gic";
+				#interrupt-cells = <3>;
+				#address-cells = <1>;
+				#size-cells = <1>;
+				interrupt-controller;
+				reg = <0x40003000 0x1000>,
+				      <0x40002100 0x100>;
+			};
+
+			L2: l2-cache at 40006000 {
+				compatible = "arm,pl310-cache";
+				reg = <0x40006000 0x1000>;
+				interrupts = <0 6 0x04>;
+				cache-unified;
+				cache-level = <2>;
+			};
+
+			uart1: serial at 40027000 { /* UART0 */
+				compatible = "fsl,mvf-uart";
+				reg = <0x40027000 0x1000>;
+				interrupts = <0 61 0x00>;
+				clocks = <&clks 34>;
+				clock-names = "ipg";
+				status = "disabled";
+			};
+
+			uart2: serial at 40028000 { /* UART1 */
+				compatible = "fsl,mvf-uart";
+				reg = <0x40028000 0x1000>;
+				interrupts = <0 62 0x04>;
+				clocks = <&clks 34>;
+				clock-names = "ipg";
+				status = "disabled";
+			};
+
+			uart3: serial at 40029000 { /* UART2 */
+				compatible = "fsl,mvf-uart";
+				reg = <0x40029000 0x1000>;
+				interrupts = <0 63 0x04>;
+				clocks = <&clks 34>;
+				clock-names = "ipg";
+				status = "disabled";
+			};
+
+			uart4: serial at 4002a000 { /* UART3 */
+				compatible = "fsl,mvf-uart";
+				reg = <0x4002a000 0x1000>;
+				interrupts = <0 64 0x04>;
+				clocks = <&clks 34>;
+				clock-names = "ipg";
+				status = "disabled";
+			};
+
+			pit:pit at 40037000 {
+				compatible = "fsl,mvf-pit";
+				reg = <0x40037000 0x1000>;
+				interrupts = <0 39 0x04>;
+			};
+
+			wdog at 4003e000 {
+				compatible = "fsl,mvf-wdt";
+				reg = <0x4003e000 0x1000>;
+			};
+
+			qspi0: quadspi at 40044000 {
+				#address-cells = <1>;
+				#size-cells = <0>;
+				compatible = "fsl,mvf-qspi";
+				reg = <0x40044000 0x1000>;
+				interrupts = <0 24 0x04>;
+				status = "disabled";
+			};
+
+			pinctrl1: iomuxc at 40047000 {
+				compatible = "fsl,mvf-iomuxc";
+				reg = <0x40047000 0x2000>;
+				#gpio-range-cells = <2>;
+
+				/* iomux setting */
+				esdhc1 {
+					pinctrl_esdhc1_1: esdhc1grp_1 {
+						fsl,pins = <
+						85 0x5031ef /* PTA24__SDHC1_CLK */
+						91 0x5031ef /* PTA25__SDHC1_CMD */
+						96 0x5031ef /* PTA26__SDHC1_DAT0 */
+						101 0x5031ef /* PTA27__SDHC1_DAT1 */
+						108 0x5031ef /* PTA28__SDHC1_DAT2 */
+						115 0x5031ef /* PTA29__SDHC1_DAT3 */
+						776 0x219d /* PTA7__SDHC1_SW_CD */
+					>;
+					};
+				};
+				i2c0 {
+					pinctrl_i2c0_1: i2c0grp_1 {
+						fsl,pins = <
+						226 0x2030d3 /* PTB14__I2C0_SCL */
+						231 0x2030d3 /* PTB15__I2C0_SDA */
+						>;
+					};
+				};
+				dspi0 {
+					pinctrl_dspi0_1: dspi0grp_1 {
+						fsl,pins = <
+						247 0x101182 /* PTB19__DSPI0_PCS0 */
+						250 0x101181 /* PTB20__DSPI0_SIN */
+						254 0x101182 /* PTB21__DSPI0_SOUT */
+						259 0x101182 /* PTB22__DSPI0_SCK */
+						>;
+					};
+				};
+				fec0 {
+					pinctrl_fec0_1: fec0grp_1 {
+						fsl,pins = <
+						2 0x2030d1 /* PTA6__RMII_CLKIN */
+						262 0x1030d2 /* PTC0__RMII0_MDC */
+						270 0x1030d3 /* PTC1__RMII0_MDIO */
+						278 0x1030d1 /* PTC2__RMII0_CRS_DV */
+						285 0x1030d1 /* PTC3__RMII0_RXD1 */
+						292 0x1030d1 /* PTC4__RMII0_RXD0 */
+						300 0x1030d1 /* PTC5__RMII0_RXER */
+						308 0x1030d2 /* PTC6__RMII0_TXD1 */
+						315 0x1030d2 /* PTC7__RMII0_TXD0 */
+						321 0x1030d2 /* PTC8__RMII0_TXEN */
+						>;
+					};
+				};
+				fec1 {
+					pinctrl_fec1_1: fec1grp_1 {
+						fsl,pins = <
+						326 0x1030d2 /* PTC9__RMII1_MDC */
+						331 0x1030d3 /* PTC10__RMII1_MDIO */
+						336 0x1030d1 /* PTC11__RMII1_CRS_DV */
+						341 0x1030d1 /* PTC12__RMII1_RXD1 */
+						346 0x1030d1 /* PTC13__RMII1_RXD0 */
+						351 0x1030d1 /* PTC14__RMII1_RXER */
+						358 0x1030d2 /* PTC15__RMII1_TXD1 */
+						365 0x1030d2/* PTC16__RMII1_TXD0 */
+						372 0x1030d2/* PTC17__RMII1_TXEN */
+						>;
+					};
+				};
+				sai2 {
+					pinctrl_sai2_1: sai2grp_1 {
+						fsl,pins = <
+						35 0x5002ed /* PTA16_SAI2_TX_BCLK */
+						51 0x5002ee /* PTA18_SAI2_TX_DATA */
+						59 0x5002ed /* PTA19_SAI2_TX_SYNC */
+						69 0x5002ed /* PTA21_SAI2_RX_BCLK */
+						74 0x5002ed /* PTA22_SAI2_RX_DATA */
+						79 0x5002ed /* PTA23_SAI2_RX_SYNC */
+						244 0x2002ed /* PTB18_EXT_AUDIO_MCLK */
+						>;
+					};
+				};
+				dcu0 {
+					pinctrl_dcu0_1: dcu0grp_1 {
+						fsl,pins = <
+						191 0x42 /* PTB8_LCD_ENABLE */
+						647 0x100042 /* PTE0_DCU0_HSYNC */
+						652 0x100042 /* PTE1_DCU0_VSYNC */
+						657 0x100042 /* PTE2_DCU0_PCLK */
+						665 0x100042 /* PTE4_DCU0_DE */
+						669 0x100042 /* PTE5_DCU0_R0 */
+						673 0x100042 /* PTE6_DCU0_R1 */
+						677 0x100042 /* PTE7_DCU0_R2 */
+						682 0x100042 /* PTE8_DCU0_R3 */
+						687 0x100042 /* PTE9_DCU0_R4 */
+						692 0x100042 /* PTE10_DCU0_R5 */
+						697 0x100042 /* PTE11_DCU0_R6 */
+						702 0x100042 /* PTE12_DCU0_R7 */
+						708 0x100042 /* PTE13_DCU0_G0 */
+						712 0x100042 /* PTE14_DCU0_G1 */
+						716 0x100042 /* PTE15_DCU0_G2 */
+						721 0x100042 /* PTE16_DCU0_G3 */
+						725 0x100042 /* PTE17_DCU0_G4 */
+						729 0x100042 /* PTE18_DCU0_G5 */
+						733 0x100042 /* PTE19_DCU0_G6 */
+						738 0x100042 /* PTE20_DCU0_G7 */
+						744 0x100042 /* PTE21_DCU0_B0 */
+						747 0x100042 /* PTE22_DCU0_B1 */
+						750 0x100042 /* PTE23_DCU0_B2 */
+						754 0x100042 /* PTE24_DCU0_B3 */
+						758 0x100042 /* PTE25_DCU0_B4 */
+						762 0x100042 /* PTE26_DCU0_B5 */
+						766 0x100042 /* PTE27_DCU0_B6 */
+						771 0x100042 /* PTE28_DCU0_B7 */
+						>;
+					};
+				};
+				uart1 {
+					pinctrl_uart1_1: uart1grp_1 {
+						fsl,pins = <
+						163 0x2021a2 /* PTB4_UART1_TX */
+						171 0x2021a1 /* PTB5_UART1_RX */
+						>;
+					};
+				};
+				usbvbus {
+					pinctrl_usbvbus_1: usbvbusgrp_1 {
+						fsl,pins = <
+						32 0x20219c /* PTA24__USB0_VBUS_EN */
+						84 0x20219c /* PTA17__USB1_VBUS_EN */
+						>;
+					};
+				};
+				pwm0 {
+					pinctrl_pwm0_1: pwm0grp_1 {
+						fsl,pins = <
+						131 0x101582 /* PTB0_FTM0CH0 */
+						139 0x101582 /* PTB1_FTM0CH1 */
+						147 0x101582 /* PTB2_FTM0CH2 */
+						155 0x101582 /* PTB3_FTM0CH3 */
+						177 0x101582 /* PTB6_FTM0CH6 */
+						185 0x101582 /* PTB7_FTM0CH7 */
+						>;
+					};
+				};
+				pwm1 {
+					pinctrl_pwm1_1: pwm1grp_1 {
+						fsl,pins = <
+						197 0x101182 /* PTB9_FTM1CH1 */
+						>;
+					};
+				};
+				touchscreen0 {
+					pinctrl_ts0_1: ts0grp_1 {
+						fsl,pins = <
+						124 0x219d /* PTA31_TS_IRQ */
+						>;
+					};
+				};
+				qspi0 {
+					pinctrl_qspi0_1: qspi0grp_1 {
+						fsl,pins = <
+						483 0x10307b /* PTD0_QSPI0_A_SCK */
+						489 0x10307f /* PTD1_QSPI0_A_CS0 */
+						495 0x103073 /* PTD2_QSPI0_A_D3 */
+						502 0x103073 /* PTD3_QSPI0_A_D2 */
+						509 0x103073 /* PTD4_QSPI0_A_D1 */
+						515 0x10307b /* PTD5_QSPI0_A_D0 */
+						525 0x10307b /* PTD7_QSPI0_B_SCK */
+						530 0x10307f /* PTD8_QSPI0_B_CS0 */
+						536 0x103073 /* PTD9_QSPI0_B_D3 */
+						542 0x103073 /* PTD10_QSPI0_B_D2 */
+						547 0x103073 /* PTD11_QSPI0_B_D1 */
+						552 0x10307b /* PTD12_QSPI0_B_D0 */
+						>;
+					};
+				};
+
+			};
+
+			gpio1: gpio at 40049000 {
+				compatible = "fsl,mvf-gpio";
+				reg = <0x40049000 0x1000 0x400ff000 0x40>;
+				interrupts = <0 107 0x04>;
+				gpio-controller;
+				#gpio-cells = <2>;
+				interrupt-controller;
+				#interrupt-cells = <2>;
+				gpio-ranges = <&pinctrl1 0 32>;
+			};
+
+			gpio2: gpio at 4004a000 {
+				compatible = "fsl,mvf-gpio";
+				reg = <0x4004a000 0x1000 0x400ff040 0x40>;
+				interrupts = <0 108 0x04>;
+				gpio-controller;
+				#gpio-cells = <2>;
+				interrupt-controller;
+				#interrupt-cells = <2>;
+				gpio-ranges = <&pinctrl1 32 32>;
+			};
+
+			gpio3: gpio at 4004b000 {
+				compatible = "fsl,mvf-gpio";
+				reg = <0x4004b000 0x1000 0x400ff080 0x40>;
+				interrupts = <0 109 0x04>;
+				gpio-controller;
+				#gpio-cells = <2>;
+				interrupt-controller;
+				#interrupt-cells = <2>;
+				gpio-ranges = <&pinctrl1 64 32>;
+			};
+
+			gpio4: gpio at 4004c000 {
+				compatible = "fsl,mvf-gpio";
+				reg = <0x4004c000 0x1000 0x400ff0c0 0x40>;
+				interrupts = <0 110 0x04>;
+				gpio-controller;
+				#gpio-cells = <2>;
+				interrupt-controller;
+				#interrupt-cells = <2>;
+				gpio-ranges = <&pinctrl1 96 32>;
+			};
+
+			gpio5: gpio at 4004d000 {
+				compatible = "fsl,mvf-gpio";
+				reg = <0x4004d000 0x1000 0x400ff100 0x40>;
+				interrupts = <0 111 0x04>;
+				gpio-controller;
+				#gpio-cells = <2>;
+				interrupt-controller;
+				#interrupt-cells = <2>;
+				gpio-ranges = <&pinctrl1 128 7>;
+			};
+
+			anatop at 40050000 {
+				compatible = "fsl,mvf-anatop";
+				reg = <0x40050000 0x1000>;
+			};
+
+			clks: ccm at 4006b000 {
+				compatible = "fsl,mvf-ccm";
+				reg = <0x4006b000 0x1000>;
+				#clock-cells = <1>;
+			};
+
+		};
+
+		aips1: aips-bus at 40080000 { /* AIPS1 */
+			compatible = "fsl,aips-bus", "simple-bus";
+			#address-cells = <1>;
+			#size-cells = <1>;
+			reg = <0x40080000 0x80000>;
+			ranges;
+
+			uart5: serial at 400a9000 { /* UART4 */
+				compatible = "fsl,mvf-uart";
+				reg = <0x400a9000 0x1000>;
+				interrupts = <0 65 0x04>;
+				clocks = <&clks 34>;
+				clock-names = "ipg";
+				status = "disabled";
+			};
+
+			uart6: serial at 400aa000 { /* UART5 */
+				compatible = "fsl,mvf-uart";
+				reg = <0x400aa000 0x1000>;
+				interrupts = <0 66 0x04>;
+				clocks = <&clks 34>;
+				clock-names = "ipg";
+				status = "disabled";
+			};
+
+			fec0: ethernet at 400d0000 {
+				compatible = "fsl,mvf-fec";
+				reg = <0x400d0000 0x1000>;
+				interrupts = <0 78 0x04>;
+				clocks = <&clks 52>, <&clks 52>, <&clks 52>;
+				clock-names = "ipg", "ahb", "ptp";
+			};
+
+			fec1: ethernet at 400d1000 {
+				compatible = "fsl,mvf-fec";
+				reg = <0x400d1000 0x1000>;
+				interrupts = <0 79 0x04>;
+				clocks = <&clks 52>, <&clks 52>, <&clks 52>;
+				clock-names = "ipg", "ahb", "ptp";
+			};
+
+		};
+	};
+};
arch/arm/boot/dts/imx-mvf600twr.dts new file +82 -0

82 lines not on this page · raw message

Signature · 1 line
1.8.0
maintainer
#5 lore raw

PATCH 2/3 ARM:DTS:MVF600: add basic device tree source

Quoted 104 lines · Jingchang Lu

This patch adds basic device tree source for Freescale Vybrid Family platform and Tower development board.

---
 arch/arm/boot/dts/imx-mvf600.dtsi   | 442 ++++++++++++++++++++++++++++++++++++
 arch/arm/boot/dts/imx-mvf600twr.dts |  82 +++++++
 2 files changed, 524 insertions(+)
 create mode 100644 arch/arm/boot/dts/imx-mvf600.dtsi
 create mode 100644 arch/arm/boot/dts/imx-mvf600twr.dts
arch/arm/boot/dts/imx-mvf600.dtsi new file +86 -0
new file mode 100644
index 0000000..3a534c6
@@ -0,0 +1,442 @@
+/*
+ * Copyright 2013 Freescale Semiconductor, Inc.
+ *
+ * This program is free software; you can redistribute it and/or modify
+ * it under the terms of the GNU General Public License as published by
+ * the Free Software Foundation; either version 2 of the License, or
+ * (at your option) any later version.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+ * GNU General Public License for more details.
+ *
+ * You should have received a copy of the GNU General Public License along
+ * with this program; if not, write to the Free Software Foundation, Inc.,
+ * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA.
+ */
+
+/include/ "skeleton.dtsi"
+
+/ {
+	aliases {
+		serial0 = &uart1;
+		serial1 = &uart2;
+		serial2 = &uart3;
+		serial3 = &uart4;
+		serial4 = &uart5;
+		serial5 = &uart6;
+		gpio0 = &gpio1;
+		gpio1 = &gpio2;
+		gpio2 = &gpio3;
+		gpio3 = &gpio4;
+		gpio4 = &gpio5;
+	};
+
+
+	clocks {
+		#address-cells = <1>;
+		#size-cells = <0>;
+
+		ckil {
+			compatible = "fsl,mvf-ckil", "fixed-clock";
+			clock-frequency = <32768>;
+		};
+
+		ckih1 {
+			compatible = "fsl,mvf-ckih1", "fixed-clock";
+			clock-frequency = <0>;
+		};
+
+		osc {
+			compatible = "fsl,mvf-osc", "fixed-clock";
+			clock-frequency = <24000000>;
+		};
+	};
+
+
+	soc {
+		#address-cells = <1>;
+		#size-cells = <1>;
+		compatible = "simple-bus";
+		interrupt-parent = <&intc>;
+		ranges;
+
+		aips0: aips-bus at 40000000 { /* AIPS0 */
+			compatible = "fsl,aips-bus", "simple-bus";
+			#address-cells = <1>;
+			#size-cells = <1>;
+			interrupt-parent = <&intc>;
+			reg = <0x40000000 0x70000>;
+			ranges;
+
+			mscm: mscm at 40001000 {
+				compatible = "fsl,mvf-mscm";
+				reg = <0x40001000 0x1000>;
+			};
+
+			intc: interrupt-controller at 40002000 {
+				compatible = "arm,cortex-a9-gic";
+				#interrupt-cells = <3>;
+				#address-cells = <1>;
+				#size-cells = <1>;
+				interrupt-controller;
+				reg = <0x40003000 0x1000>,
+				      <0x40002100 0x100>;
+			};

arch/arm/boot/dts/imx-mvf600.dtsi line 96

Quoted 10 lines
arch/arm/boot/dts/imx-mvf600.dtsi new file +10 -0
+
+			L2: l2-cache at 40006000 {
+				compatible = "arm,pl310-cache";
+				reg = <0x40006000 0x1000>;
+				interrupts = <0 6 0x04>;
+				cache-unified;
+				cache-level = <2>;
+			};
+
+			uart1: serial at 40027000 { /* UART0 */

That's the first time Freescale actually starts counting at zero. Let's be grateful for that and just use it instead of renumbering it.

Quoted 9 lines
arch/arm/boot/dts/imx-mvf600.dtsi new file +9 -0
+
+			pinctrl1: iomuxc at 40047000 {
+				compatible = "fsl,mvf-iomuxc";
+				reg = <0x40047000 0x2000>;
+				#gpio-range-cells = <2>;
+
+				/* iomux setting */
+				esdhc1 {
+					pinctrl_esdhc1_1: esdhc1grp_1 {

arch/arm/boot/dts/imx-mvf600.dtsi line 169

Quoted 10 lines
arch/arm/boot/dts/imx-mvf600.dtsi new file +10 -0
+						fsl,pins = <
+						85 0x5031ef /* PTA24__SDHC1_CLK */
+						91 0x5031ef /* PTA25__SDHC1_CMD */
+						96 0x5031ef /* PTA26__SDHC1_DAT0 */
+						101 0x5031ef /* PTA27__SDHC1_DAT1 */
+						108 0x5031ef /* PTA28__SDHC1_DAT2 */
+						115 0x5031ef /* PTA29__SDHC1_DAT3 */
+						776 0x219d /* PTA7__SDHC1_SW_CD */
+					>;
+					};

I have no idea how the iomux works on vybrid, but Shawn just eliminated the magic numbers for the pins. Let's not reintroduce them for vybrid if possible.

Signature · 4 lines
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |
reviewer
#6 lore raw

PATCH 2/3 ARM:DTS:MVF600: add basic device tree source

In reply to Jingchang Lu
Quoted 11 lines · Jingchang Lu

This patch adds basic device tree source for Freescale Vybrid Family platform and Tower development board.

---
 arch/arm/boot/dts/imx-mvf600.dtsi   | 442 ++++++++++++++++++++++++++++++++++++
 arch/arm/boot/dts/imx-mvf600twr.dts |  82 +++++++
 2 files changed, 524 insertions(+)
 create mode 100644 arch/arm/boot/dts/imx-mvf600.dtsi
 create mode 100644 arch/arm/boot/dts/imx-mvf600twr.dts

Why add the 'imx' prefix here?

Wouldn't 'vybrid' makes more sense?