Skip to contentSkip to conversation

regulator: ab8500: Fix voltage_mask for AB8505_LDO_AUDIO

PATCH In review Axel Lin 2 participants 2 messages Apr 12, 2013 Voltage and current regulator framework

lore
Share & tools
lore

Axel Lin

author
#0 lore raw

PATCH 1/1 regulator: ab8500: Fix voltage_mask for AB8505_LDO_AUDIO

The voltage_mask and voltage_shift settings of AB8505_LDO_AUDIO are not matched. It looks like a typo in the voltage_mask settings.

---
Hi Lee and Bengt,
I don't have the datasheet. Can you confirm if this fix is correct?

Thanks,
Axel

 drivers/regulator/ab8500.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/regulator/ab8500.c +1 -1
index ea182d3..b81ff04 100644
@@ -1130,7 +1130,7 @@ static struct ab8500_regulator_info
 		.update_val		= 0x02,
 		.voltage_bank		= 0x01,
 		.voltage_reg		= 0x57,
-		.voltage_mask		= 0x7,
+		.voltage_mask		= 0x70,
 		.voltage_shift		= 4,
 	},
 	[AB8505_LDO_ANAMIC1] = {
Signature · 1 line
1.7.10.4
Acked-by on v1 1/1
#1 lore raw
Quoted 10 lines · Axel Lin

The voltage_mask and voltage_shift settings of AB8505_LDO_AUDIO are not matched. It looks like a typo in the voltage_mask settings.

---
Hi Lee and Bengt,
I don't have the datasheet. Can you confirm if this fix is correct?

Thanks,
Axel

Yes it is correct. The voltage bits are in 0x70. Thank you!

Quoted 16 lines
  drivers/regulator/ab8500.c |    2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)
drivers/regulator/ab8500.c +1 -1
index ea182d3..b81ff04 100644
@@ -1130,7 +1130,7 @@ static struct ab8500_regulator_info
  		.update_val		= 0x02,
  		.voltage_bank		= 0x01,
  		.voltage_reg		= 0x57,
-		.voltage_mask		= 0x7,
+		.voltage_mask		= 0x70,
  		.voltage_shift		= 4,
  	},
  	[AB8505_LDO_ANAMIC1] = {