Skip to contentSkip to conversation

udev-extraconf: Add -o silent to auto mount for mount.util-linux

PATCH In review Saul Wold 3 participants 4 messages Apr 13, 2013

lore
Share & tools
lore

Saul Wold

author
#0 lore raw

PATCH 1/2 udev-extraconf: Add -o silent to auto mount for mount.util-linux

This will silence some of the noisy output from mount.util-linux and the kernel when trying to automount filesystems or devices. Busybox does not accept the silent option, it uses a "loud" option instead.

[YOCTO #3935]

---
 meta/recipes-core/udev/udev-extraconf/mount.sh | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
meta/recipes-core/udev/udev-extraconf/mount.sh +1 -1
index 99c76b2..7b58361 100644
@@ -22,7 +22,7 @@ automount() {
 
 	! test -d "/media/$name" && mkdir -p "/media/$name"
 	
-	if ! $MOUNT -t auto $DEVNAME "/media/$name"
+	if ! $MOUNT -o silent -t auto $DEVNAME "/media/$name"
 	then
 		#logger "mount.sh/automount" "$MOUNT -t auto $DEVNAME \"/media/$name\" failed!"
 		rm_dir "/media/$name"
Signature · 1 line
1.8.0.2
#1 lore raw
Quoted 10 lines · Saul Wold

This will silence some of the noisy output from mount.util-linux and the kernel when trying to automount filesystems or devices. Busybox does not accept the silent option, it uses a "loud" option instead.

[YOCTO #3935]

---
 meta/recipes-core/udev/udev-extraconf/mount.sh | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

As far as I can see this will break with busybox mount. Is there a 2/2 missing?

Quoted 13 lines
meta/recipes-core/udev/udev-extraconf/mount.sh +1 -1
index 99c76b2..7b58361 100644
@@ -22,7 +22,7 @@ automount() {
 
 	! test -d "/media/$name" && mkdir -p "/media/$name"
 
-	if ! $MOUNT -t auto $DEVNAME "/media/$name"
+	if ! $MOUNT -o silent -t auto $DEVNAME "/media/$name"
 	then
 		#logger "mount.sh/automount" "$MOUNT -t auto $DEVNAME \"/media/$name\" failed!"
 		rm_dir "/media/$name"
#2 lore raw
Quoted 12 lines · On 13 April 2013 12:26:38 Richard Purdie <[email protected]>…
Quoted 1 line · Saul Wold

This will silence some of the noisy output from mount.util-linux and the

kernel

Quoted 1 line

when trying to automount filesystems or devices. Busybox does not accept

the silent

Quoted 6 lines

option, it uses a "loud" option instead.

[YOCTO #3935]
---
 meta/recipes-core/udev/udev-extraconf/mount.sh | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Quoted 2 lines

As far as I can see this will break with busybox mount. Is there a 2/2 missing?

IIRC Busybox defaults to be silent (right?), I will thus add (and ignore) silent. I will have a look in the evening.

Thanks for the heads up!
Cheers,

Quoted 14 lines

Review

Quoted 2 lines
(quoted diff) +0 -0

b/meta/recipes-core/udev/udev-extraconf/mount.sh

meta/recipes-core/udev/udev-extraconf/mount.sh automount() { · line 26

Quoted 10 lines

index 99c76b2..7b58361 100644

meta/recipes-core/udev/udev-extraconf/mount.sh +1 -1
@@ -22,7 +22,7 @@ automount() {
 	! test -d "/media/$name" && mkdir -p "/media/$name"
 
-	if ! $MOUNT -t auto $DEVNAME "/media/$name"
+	if ! $MOUNT -o silent -t auto $DEVNAME "/media/$name"
 	then
 		#logger "mount.sh/automount" "$MOUNT -t auto $DEVNAME \"/media/$name\" 

failed!"

Quoted 8 lines

meta/recipes-core/udev/udev-extraconf/mount.sh automount() { · line 28

Quoted 1 line
meta/recipes-core/udev/udev-extraconf/mount.sh +0 -0
 		rm_dir "/media/$name"

_______________________________________________
Openembedded-core mailing list
[email protected]
http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core

Sent with AquaMail for Android
http://www.aqua-mail.com

author
#3 lore raw
Quoted 14 lines · Bernhard Reutner-Fischer
Quoted 12 lines · On 13 April 2013 12:26:38 Richard Purdie <[email protected]>…
Quoted 1 line · Saul Wold

This will silence some of the noisy output from mount.util-linux and

the kernel

Quoted 1 line

when trying to automount filesystems or devices. Busybox does not

accept the silent

Quoted 6 lines

option, it uses a "loud" option instead.

[YOCTO #3935]
---
 meta/recipes-core/udev/udev-extraconf/mount.sh | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Quoted 6 lines
Quoted 2 lines

As far as I can see this will break with busybox mount. Is there a 2/2 missing?

IIRC Busybox defaults to be silent (right?), I will thus add (and ignore) silent. I will have a look in the evening.

Dangit, I sent the wrong patch, I have the correct one, will resend.

Sau!

Quoted 32 lines

Thanks for the heads up!
Cheers,

Quoted 14 lines

Review

Quoted 2 lines
(quoted diff) +0 -0

b/meta/recipes-core/udev/udev-extraconf/mount.sh

meta/recipes-core/udev/udev-extraconf/mount.sh automount() { · line 26

Quoted 10 lines

index 99c76b2..7b58361 100644

meta/recipes-core/udev/udev-extraconf/mount.sh +1 -1
@@ -22,7 +22,7 @@ automount() {
     ! test -d "/media/$name" && mkdir -p "/media/$name"
 
-    if ! $MOUNT -t auto $DEVNAME "/media/$name"
+    if ! $MOUNT -o silent -t auto $DEVNAME "/media/$name"
     then
         #logger "mount.sh/automount" "$MOUNT -t auto $DEVNAME

\"/media/$name\" failed!"

Quoted 8 lines

meta/recipes-core/udev/udev-extraconf/mount.sh automount() { · line 28

Quoted 1 line
meta/recipes-core/udev/udev-extraconf/mount.sh +0 -0
         rm_dir "/media/$name"

_______________________________________________
Openembedded-core mailing list
[email protected]
http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core

Sent with AquaMail for Android
http://www.aqua-mail.com