Skip to contentSkip to conversation

fec: Fix PHC device log

PATCH Applied Fabio Estevam 2 participants 2 messages Apr 13, 2013

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH v2 1/1 fec: Fix PHC device log

From: Fabio Estevam <[email protected]>

Currently when booting a mx6 device we get the following on boot:

registered PHC device on eth%d

Fix it by printing the network device name only after it gets registered, so that the following can be read now:

fec 2188000.ethernet eth0: registered PHC device 0

---
Changes since v1:
- Use netdev_info
- Only print the interface name after it gets registered.

 drivers/net/ethernet/freescale/fec_main.c |    3 +++
 drivers/net/ethernet/freescale/fec_ptp.c  |    2 --
 2 files changed, 3 insertions(+), 2 deletions(-)
drivers/net/ethernet/freescale/fec_main.c +3 -0
index 806a56d..e8858a6 100644
@@ -1858,6 +1858,9 @@ fec_probe(struct platform_device *pdev)
 	if (ret)
 		goto failed_register;
 
+	if (fep->bufdesc_ex && fep->ptp_clock)
+		netdev_info(ndev, "registered PHC device %d\n", fep->dev_id);
+
 	return 0;
 
 failed_register:
drivers/net/ethernet/freescale/fec_ptp.c +0 -2
index 1f17ca0..e040c8b 100644
@@ -379,7 +379,5 @@ void fec_ptp_init(struct net_device *ndev, struct platform_device *pdev)
 	if (IS_ERR(fep->ptp_clock)) {
 		fep->ptp_clock = NULL;
 		pr_err("ptp_clock_register failed\n");
-	} else {
-		pr_info("registered PHC device on %s\n", ndev->name);
 	}
 }
Signature · 1 line
1.7.9.5
maintainer Applied
#1 lore raw

From: Fabio Estevam <[email protected]>
Date: Sat, 13 Apr 2013 14:25:36 -0300

Quoted 4 lines

From: Fabio Estevam <[email protected]>

Currently when booting a mx6 device we get the following on boot:

Quoted 8 lines

registered PHC device on eth%d

Fix it by printing the network device name only after it gets registered, so that the following can be read now:

fec 2188000.ethernet eth0: registered PHC device 0

Applied.