regulator: ab8500: Fix voltage_shift setting for AB8540_LDO_DMIC
PATCH 1/1 regulator: ab8500: Fix voltage_shift setting for AB8540_LDO_DMIC
The voltage_mask is 0xc0, thus we need to set voltage_shift = 6 to get correct selector in get_voltage_sel and set_voltage_sel.
---
Hi Bengt,
I don't have the datasheet. Can you confirm if this fix is correct?
BTW, can you also review a couple patches for ab8500 and ab8500-ext I sent a few days ago? I ask this because now I have more patches that may depend on previous patches.
Thanks,
Axel
drivers/regulator/ab8500.c | 1 + 1 file changed, 1 insertion(+)
drivers/regulator/ab8500.c +1 -0
@@ -1729,6 +1729,7 @@ static struct ab8500_regulator_info .voltage_bank = 0x03, .voltage_reg = 0x83, .voltage_mask = 0xc0, + .voltage_shift = 6, },/*
Signature · 1 line
1.7.10.4
Quoted 4 lines · Axel Lin
The
voltage_maskis0xc0, thus we need to setvoltage_shift= 6 to get correct selector inget_voltage_selandset_voltage_sel.Signed-off-by Axel Lin <[email protected]>
The patch is correct. Voltage selection is done with 0xc0.
Quoted 26 lines
---
Hi Bengt,
I don't have the datasheet. Can you confirm if this fix is correct?BTW, can you also review a couple patches for ab8500 and ab8500-ext I sent a few days ago? I ask this because now I have more patches that may depend on previous patches.
Thanks,
Axeldrivers/regulator/ab8500.c | 1 + 1 file changed, 1 insertion(+)drivers/regulator/ab8500.c +1
-0@@ -1729,6 +1729,7 @@ static struct ab8500_regulator_info .voltage_bank = 0x03, .voltage_reg = 0x83, .voltage_mask = 0xc0, + .voltage_shift = 6, },/*
Quoted 2 lines · Axel Lin
The
voltage_maskis0xc0, thus we need to setvoltage_shift= 6 to get correct selector inget_voltage_selandset_voltage_sel.
Applied, thanks.