Skip to contentSkip to conversation

sparc/kernel/vio.c: add put_device() after device_find_child()

RFC PATCH Applied Federico Vaga 2 participants 2 messages Apr 15, 2013 – May 5, 2013 SPARC + UltraSPARC (sparc/sparc64)

lore
Share & tools
lore
#0 lore raw

RFC PATCH 1/1 sparc/kernel/vio.c: add put_device() after device_find_child()

The vio_remove() function uses device_find_child() but it does not drop the reference of the retrieved child.

---

I do not have a SPARC system (and I do not know it), so I cannot test this patch. Please test it.
If I'm right, the device_unregister() does not work properly because, device_find_child() did get_device() on dev. In essence, the release method associated to the device will never be invoked because there is a reference to the device that is not dropped.

 arch/sparc/kernel/vio.c | 1 +
 1 file changed, 1 insertion(+)
arch/sparc/kernel/vio.c +1 -0
index 3e244f3..8647fcc 100644
@@ -342,6 +342,7 @@ static void vio_remove(struct mdesc_handle *hp, u64 node)
 		printk(KERN_INFO "VIO: Removing device %s\n", dev_name(dev));
 
 		device_unregister(dev);
+		put_device(dev);
 	}
 }
 
Signature · 1 line
1.8.1.4