Skip to contentSkip to conversation

tlan: cancel work at remove path

PATCH Applied Devendra Naga 2 participants 2 messages Apr 16, 2013

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 tlan: cancel work at remove path

the work has been scheduled from interrupt, and not been cancelled when the driver is unloaded, which doesn't remove the work item from the global workqueue. call the cancel_work_sync when the driver is removed (rmmod'ed).

Cc Sriram <[email protected]>
Cc Cyril Chemparathy <[email protected]>
Cc Vinay Hegde <[email protected]>

---

Hi,
This is only compile tested and not tested on the the NIC which i dont have.

thanks

 drivers/net/ethernet/ti/tlan.c | 1 +
 1 file changed, 1 insertion(+)
drivers/net/ethernet/ti/tlan.c +1 -0
index bdda36f..60c400f 100644
@@ -320,6 +320,7 @@ static void tlan_remove_one(struct pci_dev *pdev)
 	free_netdev(dev);
 
 	pci_set_drvdata(pdev, NULL);
+	cancel_work_sync(&priv->tlan_tqueue);
 }
 
 static void tlan_start(struct net_device *dev)
Signature · 1 line
1.8.1.4
maintainer Applied
#1 lore raw

From: Devendra Naga <[email protected]>
Date: Tue, 16 Apr 2013 17:00:38 +0530

Quoted 9 lines

the work has been scheduled from interrupt, and not been cancelled when the driver is unloaded, which doesn't remove the work item from the global workqueue. call the cancel_work_sync when the driver is removed (rmmod'ed).

Cc Sriram <[email protected]>
Cc Cyril Chemparathy <[email protected]>
Cc Vinay Hegde <[email protected]>

Applied.