fec: Remove unneeded asm header files
Subsystems (3)
PATCH 1/1 fec: Remove unneeded asm header files
From: Fabio Estevam <[email protected]>
There is nothing in the driver that requires asm header files.
---
Greg,
I built this for ARM and x86 (tweaking Kconfig), but I don't have a m68k toolchain installed here to test it.
Please build it for m68k if you have a chance. Thanks
drivers/net/ethernet/freescale/fec_main.c | 7 ------- 1 file changed, 7 deletions(-)
drivers/net/ethernet/freescale/fec_main.c +0 -7
@@ -50,13 +50,6 @@#include <linux/pinctrl/consumer.h> #include <linux/regulator/consumer.h> -#include <asm/cacheflush.h> - -#ifndef CONFIG_ARM -#include <asm/coldfire.h> -#include <asm/mcfsim.h> -#endif -#include "fec.h" #if defined(CONFIG_ARM )
Signature · 1 line
1.7.9.5
Hi Fabio,
Quoted 8 lines · Fabio Estevam
From: Fabio Estevam <[email protected]>
There is nothing in the driver that requires asm header files.
Signed-off-by Fabio Estevam <[email protected]>---
Greg,
Quoted 6 lines
I built this for ARM and x86 (tweaking
Kconfig), but I don't have a m68k toolchain installed here to test it.Please build it for m68k if you have a chance. Thanks
drivers/net/ethernet/freescale/fec_main.c | 7 -------
fec_main.c? It doesn't exist in 3.9-rc7. Comments and tests below based on fec.c in 3.9-rc7.
drivers/net/ethernet/freescale/fec_main.c line 53
Quoted 11 lines
1 file changed, 7 deletions(-)drivers/net/ethernet/freescale/fec_main.c +0
-1@@ -50,13 +50,6 @@#include <linux/pinctrl/consumer.h> #include <linux/regulator/consumer.h> -#include <asm/cacheflush.h>
There is a very bogus looking call to flush_cache_all() conditional on CONFIG_M532x, and I suspect this won't compile if you take this out.
drivers/net/ethernet/freescale/fec_main.c line 58
Quoted 5 lines
drivers/net/ethernet/freescale/fec_main.c +0
-5- -#ifndef CONFIG_ARM -#include <asm/coldfire.h> -#include <asm/mcfsim.h> -#endif
No problem with this part. I tested on a couple of ColdFire targets with this and they still compile ok.
Regards
Greg
David Miller
maintainerFrom: Greg Ungerer <[email protected]>
Date: Thu, 18 Apr 2013 21:56:43 +1000
Quoted 14 lines
Hi Fabio,
Quoted 11 lines · Fabio Estevam
From: Fabio Estevam <[email protected]>
There is nothing in the driver that requires asm header files.
Signed-off-by Fabio Estevam <[email protected]>---
Greg,I built this for ARM and x86 (tweaking
Kconfig), but I don't have a m68k toolchain installed here to test it.
Quoted 6 lines
Quoted 3 lines
Please build it for m68k if you have a chance. Thanks
drivers/net/ethernet/freescale/fec_main.c | 7 -------
fec_main.c? It doesn't exist in 3.9-rc7. Comments and tests below based onfec.cin 3.9-rc7.
That's where the driver is in net-next, which cleanups such as this should be targetted.
Hi Fabio,
Quoted 8 lines · Fabio Estevam
From: Fabio Estevam <[email protected]>
There is nothing in the driver that requires asm header files.
Signed-off-by Fabio Estevam <[email protected]>---
Greg,
Quoted 6 lines
I built this for ARM and x86 (tweaking
Kconfig), but I don't have a m68k toolchain installed here to test it.Please build it for m68k if you have a chance. Thanks
drivers/net/ethernet/freescale/fec_main.c | 7 -------
fec_main.c? That doesn't exist in linux-3.9-rc7. Comments and tests below based on fec.c in linux-3.9-rc7.
drivers/net/ethernet/freescale/fec_main.c line 53
Quoted 11 lines
1 file changed, 7 deletions(-)drivers/net/ethernet/freescale/fec_main.c +0
-1@@ -50,13 +50,6 @@#include <linux/pinctrl/consumer.h> #include <linux/regulator/consumer.h> -#include <asm/cacheflush.h>
There is a rather bogus looking call to flush_cache_all() conditional on CONFIG_M532x, and I suspect removing this include will break that.
drivers/net/ethernet/freescale/fec_main.c line 58
Quoted 5 lines
drivers/net/ethernet/freescale/fec_main.c +0
-5- -#ifndef CONFIG_ARM -#include <asm/coldfire.h> -#include <asm/mcfsim.h> -#endif
No problem with this part. I compiled for a couple of ColdFire targets and this is ok.
Regards
Greg
Hi Greg,
Quoted 2 lines · Greg Ungerer
fec_main.c? That doesn't exist in linux-3.9-rc7. Comments and tests below based onfec.cin linux-3.9-rc7.
Yes, fec.c got was renamed to fec_main.c in net-next:
https://git.kernel.org/cgit/linux/kernel/git/davem/net-next.git/tree/drivers/net/ethernet/freescale/fec_main.c
Quoted 4 lines
Quoted 1 line
-#include <
asm/cacheflush.h>There is a rather bogus looking call to
flush_cache_all()conditional onCONFIG_M532x, and I suspect removing this include will break that.
Ok, will keep <asm/cacheflush.h> in v2 then.
Quoted 7 lines
drivers/net/ethernet/freescale/fec_main.c line 58
Quoted 4 lines
drivers/net/ethernet/freescale/fec_main.c +0
-4-#ifndef CONFIG_ARM -#include <asm/coldfire.h> -#include <asm/mcfsim.h> -#endif No problem with this part. I compiled for a couple of ColdFire targets and this is ok.
Thanks for testing, Greg.
Regards,
Fabio Estevam