regulator: core: Add regulator_map_voltage_ascend() API
RFC PATCH v2 1/1 regulator: core: Add regulator_map_voltage_ascend() API
A lot of regulator hardware has ascendant voltage list. This patch adds regulator_map_voltage_ascend() and export it.
Drivers that have ascendant voltage list can use this as their map_voltage() operation, this is more efficient than default regulator_map_voltage_iterate() function.
---
v2:
Since the voltage list is in ascendant order, and we iterate the list from the smallest voltage. So it is safe to break out if the voltage is greater than max_uV.
drivers/regulator/core.c | 31 +++++++++++++++++++++++++++++++ include/linux/regulator/driver.h | 2 ++ 2 files changed, 33 insertions(+)
drivers/regulator/core.c +31 -0
@@ -2265,6 +2265,37 @@ int regulator_map_voltage_iterate(struct regulator_dev *rdev,EXPORT_SYMBOL_GPL (regulator_map_voltage_iterate);/** +* regulator_map_voltage_ascend - map_voltage() for ascendant voltage list +* +* @rdev: Regulator to operate on +* @min_uV: Lower bound for voltage +* @max_uV: Upper bound for voltage +* +* Drivers that have ascendant voltage list can use this as their +* map_voltage() operation. +*/ +int regulator_map_voltage_ascend (struct regulator_dev *rdev, +int min_uV,int max_uV) +{ +int i, ret; + +for (i =0 ; i < rdev->desc->n_voltages; i++) { + ret = rdev->desc->ops->list_voltage (rdev, i); +if (ret <0 ) +continue ; + +if (ret > max_uV) +break ; + +if (ret >= min_uV && ret <= max_uV) +return i; + } + +return -EINVAL ; +} +EXPORT_SYMBOL_GPL (regulator_map_voltage_ascend); + +/** * regulator_map_voltage_linear - map_voltage() for simple linear mappings * * @rdev: Regulator to operate on
include/linux/regulator/driver.h +2 -0
@@ -332,6 +332,8 @@ int regulator_map_voltage_linear(struct regulator_dev *rdev, int min_uV, int max_uV);int regulator_map_voltage_iterate (struct regulator_dev *rdev,int min_uV,int max_uV); +int regulator_map_voltage_ascend (struct regulator_dev *rdev, +int min_uV,int max_uV);int regulator_get_voltage_sel_regmap (struct regulator_dev *rdev);int regulator_set_voltage_sel_regmap (struct regulator_dev *rdev,unsigned sel);int regulator_is_enabled_regmap (struct regulator_dev *rdev);
Signature · 1 line
1.7.10.4
Mark Brown
maintainerQuoted 6 lines · Axel Lin
A lot of regulator hardware has ascendant voltage list. This patch adds
regulator_map_voltage_ascend()and export it.Drivers that have ascendant voltage list can use this as their
map_voltage()operation, this is more efficient than defaultregulator_map_voltage_iterate()function.
I've applied this since it's a good API to have and it'll let people build drivers on it. It does seem like if we know the list is sorted we ought to be able to take advantage of that to do better than a linear scan. Not sure it's worth bothering though as these tend not to have that many values to map.