Skip to contentSkip to conversation

config_cmd_default.h: Remove CONFIG_CMD_MEMTEST

PATCH New Tom Rini 1 participant 3 messages Apr 19, 2013 – Apr 22, 2013

lore
Share & tools
lore

Tom Rini

author
#0 lore raw

PATCH 1/2 config_cmd_default.h: Remove CONFIG_CMD_MEMTEST

As per doc/feature-removal-schedule.txt, remove CONFIG_CMD_MEMTEST from default list of commands.

---
 doc/feature-removal-schedule.txt |   17 -----------------
 include/config_cmd_default.h     |    1 -
 2 files changed, 18 deletions(-)
doc/feature-removal-schedule.txt +0 -17
index ce72861..b4899c4 100644
@@ -7,23 +7,6 @@ file.
 
 ---------------------------
 
-What:	Remove CONFIG_CMD_MEMTEST from default list
-When:	Release v2013.07
-
-Why:	The "mtest" command is of little practical use (if any), and
-	experience has shown that a large number of board configu-
-	rations define useless or even dangerous start and end
-	addresses.  If not even the board maintainers are able to
-	figure out which memory range can be reliably tested, how can
-	we expect such from the end users?  As this problem comes up
-	repeatedly, we rather do not enable this command by default,
-	so only people who know what they are doing will be confronted
-	with it.
-
-Who:	Wolfgang Denk <[email protected]>
-
----------------------------
-
 What:	Remove CONFIG_SYS_ENABLE_PADS_ALL and CONFIG_SYS_CLOCKS_ENABLE_ALL
 When:	Release v2013.07
 
include/config_cmd_default.h +0 -1
index a521103..73c9544 100644
@@ -31,7 +31,6 @@
 #define CONFIG_CMD_LOADB	/* loadb			*/
 #define CONFIG_CMD_LOADS	/* loads			*/
 #define CONFIG_CMD_MEMORY	/* md mm nm mw cp cmp crc base loop */
-#define CONFIG_CMD_MEMTEST	/* mtest			*/
 #define CONFIG_CMD_MISC		/* Misc functions like sleep etc*/
 #define CONFIG_CMD_NET		/* bootp, tftpboot, rarpboot	*/
 #define CONFIG_CMD_NFS		/* NFS support			*/
Signature · 1 line
1.7.9.5
author
#1 lore raw

PATCH 1/2 config_cmd_default.h: Remove CONFIG_CMD_MEMTEST

Quoted 7 lines · Tom Rini

As per doc/feature-removal-schedule.txt, remove CONFIG_CMD_MEMTEST from default list of commands.

---
 doc/feature-removal-schedule.txt |   17 -----------------
 include/config_cmd_default.h     |    1 -

Along with 2/2, appliedt to u-boot/master.

Signature · 8 lines
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20130422/8a28bf40/attachment.pgp>
author
#2 lore raw

PATCH 2/2 feature-removal-schedule.txt: Add CONFIG_SYS_MTEST_START/END

In reply to Tom Rini

With 'mtest' no longer a default command, we will have unused defines which should be removed for the v2013.10 release.

---
 doc/feature-removal-schedule.txt |   12 ++++++++++++
 1 file changed, 12 insertions(+)
doc/feature-removal-schedule.txt +12 -0
index b4899c4..1c79c14 100644
@@ -7,6 +7,18 @@ file.
 
 ---------------------------
 
+What:	Remove unused CONFIG_SYS_MEMTEST_START/END
+When:	Release v2013.10
+
+Why:	As the 'mtest' command is no longer default, a number of platforms
+	have not opted to turn the command back on and thus provide unused
+	defines (which are likely to be propogated to new platforms from
+	copy/paste).  Remove these defines when unused.
+
+Who:	Tom Rini <[email protected]>
+
+---------------------------
+
 What:	Remove CONFIG_SYS_ENABLE_PADS_ALL and CONFIG_SYS_CLOCKS_ENABLE_ALL
 When:	Release v2013.07
 
Signature · 1 line
1.7.9.5