Skip to contentSkip to conversation

Yamaha THR10 and related USB quirks

PATCH In review Trulan Martin 2 participants 5 messages Apr 20, 2013 – Apr 24, 2013 Sound

lore
Share & tools
lore
#0 lore raw

cover Yamaha THR10 and related USB quirks

The following patches add USB quirks for several Yamaha amps. Please CC me as I am not subscribed to the mailing list.

#1 lore raw

PATCH 1/3 Yamaha THR10 USB quirk

This patch adds a USB quirk for the Yamaha THR10 amp.

sound/usb/quirks-table.h +26 -0
index 64d25a7..741680a 100644
@@ -353,6 +353,32 @@ YAMAHA_DEVICE(0x105d, NULL),
 		}
 	}
 },
+{
+    USB_DEVICE(0x0499, 0x1507),
+    .driver_info = (unsigned long) & (const struct snd_usb_audio_quirk) {
+        /* .vendor_name = "Yamaha", */
+        /* .product_name = "THR10", */
+        .ifnum = QUIRK_ANY_INTERFACE,
+        .type = QUIRK_COMPOSITE,
+        .data = (const struct snd_usb_audio_quirk[]) {
+            {
+                .ifnum = 1,
+                .type = QUIRK_AUDIO_STANDARD_INTERFACE
+            },
+            {
+                .ifnum = 2,
+                .type = QUIRK_AUDIO_STANDARD_INTERFACE
+            },
+            {
+                .ifnum = 3,
+                .type = QUIRK_MIDI_YAMAHA
+            },
+            {
+                .ifnum = -1
+            }
+        }
+    }
+},
 YAMAHA_DEVICE(0x2000, "DGP-7"),
 YAMAHA_DEVICE(0x2001, "DGP-5"),
 YAMAHA_DEVICE(0x2002, NULL),
Signature · 1 line
1.7.10.4
#2 lore raw

PATCH 2/3 Yamaha THR5a USB quirk

In reply to Trulan Martin

This patch adds a USB quirk for the Yamaha THR5a amp.

sound/usb/quirks-table.h +29 -0
index 741680a..a16cb45 100644
@@ -379,6 +379,35 @@ YAMAHA_DEVICE(0x105d, NULL),
         }
     }
 },
+/*
+ * Yamaha THR5a
+ */
+{
+   USB_DEVICE(0x0499, 0x150a),
+   .driver_info = (unsigned long) & (const struct snd_usb_audio_quirk) {
+      /* .vendor_name = "Yamaha", */
+      /* .product_name = "THR5a", */
+      .ifnum = QUIRK_ANY_INTERFACE,
+      .type = QUIRK_COMPOSITE,
+      .data = (const struct snd_usb_audio_quirk[]) {
+         {
+            .ifnum = 1,
+            .type = QUIRK_AUDIO_STANDARD_INTERFACE
+         },
+         {
+            .ifnum = 2,
+            .type = QUIRK_AUDIO_STANDARD_INTERFACE
+         },
+         {
+            .ifnum = 3,
+            .type = QUIRK_MIDI_YAMAHA
+         },
+         {
+            .ifnum = -1
+         }
+      }
+   }
+},
 YAMAHA_DEVICE(0x2000, "DGP-7"),
 YAMAHA_DEVICE(0x2001, "DGP-5"),
 YAMAHA_DEVICE(0x2002, NULL),
Signature · 1 line
1.7.10.4
#3 lore raw

PATCH 3/3 Yamaha THR10c USB quirk

In reply to Trulan Martin

This patch adds a USB quirk for the Yamaha THR10c amp.

sound/usb/quirks-table.h +29 -0
index a16cb45..ca50477 100644
@@ -408,6 +408,35 @@ YAMAHA_DEVICE(0x105d, NULL),
       }
    }
 },
+/*
+ * Yamaha THR10c
+ */
+{
+   USB_DEVICE(0x0499, 0x150c),
+   .driver_info = (unsigned long) & (const struct snd_usb_audio_quirk) {
+      /* .vendor_name = "Yamaha", */
+      /* .product_name = "THR10c", */
+      .ifnum = QUIRK_ANY_INTERFACE,
+      .type = QUIRK_COMPOSITE,
+      .data = (const struct snd_usb_audio_quirk[]) {
+         {
+            .ifnum = 1,
+            .type = QUIRK_AUDIO_STANDARD_INTERFACE
+         },
+         {
+            .ifnum = 2,
+            .type = QUIRK_AUDIO_STANDARD_INTERFACE
+         },
+         {
+            .ifnum = 3,
+            .type = QUIRK_MIDI_YAMAHA
+         },
+         {
+            .ifnum = -1
+         }
+      }
+   }
+},
 YAMAHA_DEVICE(0x2000, "DGP-7"),
 YAMAHA_DEVICE(0x2001, "DGP-5"),
 YAMAHA_DEVICE(0x2002, NULL),
Signature · 1 line
1.7.10.4
#4 lore raw
In reply to Trulan Martin

At Sat, 20 Apr 2013 11:31:44 -0400,

Quoted 2 lines · Trulan Martin

The following patches add USB quirks for several Yamaha amps. Please CC me as I am not subscribed to the mailing list.

The patches look OK but could you fix trivial coding style issues (use tabs, etc) scripts/checkpatch.pl complains, and resubmit the patches? Some warnings around the cast may remain, but space issues can be fixed trivially.

thanks,

Takashi