Skip to contentSkip to conversation

avoid calling mount during configure

PATCH In review Martin von Gagern 3 participants 4 messages Apr 21, 2013 – Apr 22, 2013 Kernel automounter

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 avoid calling mount during configure

Hi!

The configure script unconditionally calls "mount -s" in an attempt to figure out whether the command supports that option or not. This can cause trouble in cases where the configure script is executed in some kind of restricted environment, e.g. a sandbox or small chroot. For these cases, it would be nice to have a way to avoid that auto-detection, and instead specify explicitely whether or not the mount command can be expected to support the -s option.

The attached patch does just that. I wrote it for Gentoo, but in such a way that it should maintain current behaviour as the default, and allow overriding in both directions. I would welcome inclusion of this option into future builds of autofs.

Greetings,
Martin von Gagern

Add an option --enable-sloppy-mount or --disable-sloppy-mount to force or prevent the use of the -s option to mount, thus avoiding the autodetection. This can be useful in setups where executing mount might be undesirable, particularly in packaging environments.

2013-04-04 Martin von Gagern

References:
* https://bugs.gentoo.org/453778

aclocal.m4 +1 -1
Index: autofs-5.0.7/aclocal.m4
===================================================================
@@ -66,7 +66,7 @@ AC_DEFUN(AF_SLOPPY_MOUNT,
 [if test -n "$MOUNT" ; then
   AC_MSG_CHECKING([if mount accepts the -s option])
   if "$MOUNT" -s > /dev/null 2>&1 ; then
-    AC_DEFINE(HAVE_SLOPPY_MOUNT, 1, [define if the mount command supports the -s option])
+    enable_sloppy_mount=yes
     AC_MSG_RESULT(yes)
   else
     AC_MSG_RESULT(no)
configure.in +9 -1
Index: autofs-5.0.7/configure.in
===================================================================
@@ -157,7 +157,15 @@ AC_SUBST(sssldir)
 # Newer mounts have the -s (sloppy) option to ignore unknown options,
 # good for portability
 #
-AF_SLOPPY_MOUNT()
+AC_ARG_ENABLE(sloppy-mount,
+[  --enable-sloppy-mount   enable the use of the -s option to mount],,
+	enable_sloppy_mount=auto)
+if test x$enable_sloppy_mount = xauto; then
+	AF_SLOPPY_MOUNT()
+fi
+if test x$enable_sloppy_mount = xyes; then
+	AC_DEFINE(HAVE_SLOPPY_MOUNT, 1, [define if the mount command supports the -s option])
+fi
 
 # LDAP SASL auth needs libxml and Kerberos
 AF_CHECK_LIBXML()
#1 lore raw
Quoted 4 lines · Martin von Gagern

Hi!

The configure script unconditionally calls "mount -s" in an attempt to figure out whether the command supports that option or not. This can

The support for old mount command, together with pre-2.2-something kernel, should be just dropped from automount, together with all these configure checks, instead of inventing even more workarounds. In my opinion anyway.

/mjt

#2 lore raw
Quoted 7 lines · Michael Tokarev
Quoted 2 lines · Martin von Gagern

The configure script unconditionally calls "mount -s" in an attempt to figure out whether the command supports that option or not. This can

The support for old mount command, together with pre-2.2-something kernel, should be just dropped from automount, together with all these configure checks, instead of inventing even more workarounds. In my opinion anyway.

I hadn't been aware that the -s option has been around for as long as it apparently has. Dropping old legacy is fine by me, as long as there is a way to avoid running mount. Do you need a patch for that approach as well, or can I leave that to the maintainers?

Greetings,
Martin

maintainer
#3 lore raw
In reply to Michael Tokarev
Quoted 9 lines · Michael Tokarev
Quoted 4 lines · Martin von Gagern

Hi!

The configure script unconditionally calls "mount -s" in an attempt to figure out whether the command supports that option or not. This can

The support for old mount command, together with pre-2.2-something kernel, should be just dropped from automount, together with all these configure checks, instead of inventing even more workarounds. In my opinion anyway.

That may be old but every time the sloppy option hasn't worked properly in mount(8) I get hit with problems.

So I'm not going to drop it.

Ian