Skip to contentSkip to conversation

meta-jasperforest: Fix BBFILES

PATCH In review Richard Purdie 2 participants 2 messages Apr 23, 2013

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 meta-jasperforest: Fix BBFILES

BBFILES is whitespace delimited. If .= used, no whitespace padding is added around the addition and this can lead to it being combined with some other part of the field, leading to parts of BBFILES mysteriously not being seen.

For example, I have in my bblayers.conf:

  /media/build1/poky/meta-intel/meta-emenlow \
  /media/build1/poky/meta-intel/meta-fri2 \
  /media/build1/poky/meta-intel/meta-jasperforest \
  /media/build1/poky/meta-intel/meta-n450 \
  /media/build1/poky/meta-intel/meta-romley \

and this results in the warning:

WARNING: No bb files matched BBFILE_PATTERN_fri2 '^/media/build1/poky/meta-intel/meta-fri2/'

and if I try to build MACHINE=fri2, I get strange errors due to the .bb files not being parsed.

The fix is simply to use +=, just like every other layer.conf file.

---
 meta-jasperforest/conf/layer.conf |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
meta-jasperforest/conf/layer.conf +1 -1
index b539733..6d096e7 100644
@@ -2,7 +2,7 @@
 BBPATH .= ":${LAYERDIR}"
 
 # We have a recipes directory, add to BBFILES
-BBFILES .= "${LAYERDIR}/recipes-*/*/*.bb \
+BBFILES += "${LAYERDIR}/recipes-*/*/*.bb \
 	${LAYERDIR}/recipes-*/*/*.bbappend"
 
 BBFILE_COLLECTIONS += "jasperforest"
#1 lore raw
Quoted 12 lines · Richard Purdie

BBFILES is whitespace delimited. If .= used, no whitespace padding is added around the addition and this can lead to it being combined with some other part of the field, leading to parts of BBFILES mysteriously not being seen.

For example, I have in my bblayers.conf:

  /media/build1/poky/meta-intel/meta-emenlow \
  /media/build1/poky/meta-intel/meta-fri2 \
  /media/build1/poky/meta-intel/meta-jasperforest \
  /media/build1/poky/meta-intel/meta-n450 \
  /media/build1/poky/meta-intel/meta-romley \
Quoted 9 lines

and this results in the warning:

WARNING: No bb files matched BBFILE_PATTERN_fri2 '^/media/build1/poky/meta-intel/meta-fri2/'

and if I try to build MACHINE=fri2, I get strange errors due to the .bb files not being parsed.

The fix is simply to use +=, just like every other layer.conf file.

Good catch, thanks!

Pulled into meta-intel/master and meta-intel/dylan.

Tom

Quoted 20 lines
---
 meta-jasperforest/conf/layer.conf |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
meta-jasperforest/conf/layer.conf +1 -1
index b539733..6d096e7 100644
@@ -2,7 +2,7 @@
 BBPATH .= ":${LAYERDIR}"
 
 # We have a recipes directory, add to BBFILES
-BBFILES .= "${LAYERDIR}/recipes-*/*/*.bb \
+BBFILES += "${LAYERDIR}/recipes-*/*/*.bb \
 	${LAYERDIR}/recipes-*/*/*.bbappend"
 
 BBFILE_COLLECTIONS += "jasperforest"