Skip to contentSkip to conversation

rt, lockdep: double MAX_LOCKDEP_ENTRIES/MAX_LOCKDEP_CHAINS_BITS

RFC PATCH In review Mike Galbraith 2 participants 3 messages Apr 24, 2013 – May 4, 2013

lore
Share & tools
lore
#0 lore raw

RFC PATCH 1/1 rt, lockdep: double MAX_LOCKDEP_ENTRIES/MAX_LOCKDEP_CHAINS_BITS

Test driving v3.6-rt, lockdep shuts itself off soon after boot.

[  117.940497] BUG: MAX_LOCKDEP_ENTRIES too low!
[  117.940498] turning off the locking correctness validator.
[  117.940502] Pid: 5242, comm: kio_trash Not tainted 3.6.11.1-rt32-smp #51

Doubling MAX_LOCKDEP_ENTRIES/MAX_LOCKDEP_CHAINS_BITS appeased it. Box has been up for an hour without lockdep taking it's toys and going home.

---
 kernel/lockdep_internals.h |    4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
kernel/lockdep_internals.h +2 -2
@@ -54,9 +54,9 @@ enum {
  * table (if it's not there yet), and we check it for lock order
  * conflicts and deadlocks.
  */
-#define MAX_LOCKDEP_ENTRIES	16384UL
+#define MAX_LOCKDEP_ENTRIES	32768UL
 
-#define MAX_LOCKDEP_CHAINS_BITS	15
+#define MAX_LOCKDEP_CHAINS_BITS	16
 #define MAX_LOCKDEP_CHAINS	(1UL << MAX_LOCKDEP_CHAINS_BITS)
 
 #define MAX_LOCKDEP_CHAIN_HLOCKS (MAX_LOCKDEP_CHAINS*5)
#1 lore raw
Quoted 8 lines · * Mike Galbraith | 2013-04-24 09:11:15 [+0200]:

Test driving v3.6-rt, lockdep shuts itself off soon after boot.

[  117.940497] BUG: MAX_LOCKDEP_ENTRIES too low!
[  117.940498] turning off the locking correctness validator.
[  117.940502] Pid: 5242, comm: kio_trash Not tainted 3.6.11.1-rt32-smp #51

Doubling MAX_LOCKDEP_ENTRIES/MAX_LOCKDEP_CHAINS_BITS appeased it. Box has been up for an hour without lockdep taking it's toys and going home.

Can you send me your .config offlist please? I haven't seen this yet.

Sebastian

#2 lore raw
Quoted 4 lines · Sebastian Andrzej Siewior
Quoted 2 lines · * Mike Galbraith | 2013-04-24 09:11:15 [+0200]:

Test driving v3.6-rt, lockdep shuts itself off soon after boot.

Quoted 8 lines
Quoted 6 lines
[  117.940497] BUG: MAX_LOCKDEP_ENTRIES too low!
[  117.940498] turning off the locking correctness validator.
[  117.940502] Pid: 5242, comm: kio_trash Not tainted 3.6.11.1-rt32-smp #51

Doubling MAX_LOCKDEP_ENTRIES/MAX_LOCKDEP_CHAINS_BITS appeased it. Box has been up for an hour without lockdep taking it's toys and going home.

Can you send me your .config offlist please? I haven't seen this yet.

Done.

-Mike