kvm:book3e: Fix a build error
Subsystems (3)
PATCH 1/1 kvm:book3e: Fix a build error
Commit cd66cc2e, "powerpc/85xx: Add AltiVec support for e6500", adds support for AltiVec on a Book-E class processor, but while compiling in the CONFIG_PPC_BOOK3E_64 and CONFIG_VIRTUALIZATION case, this introduce the following error:
arch/powerpc/kernel/exceptions-64e.S:402: undefined reference to kvmppc_handler_42_0x01B' arch/powerpc/kernel/built-in.o: In function exc_altivec_assist_book3e':arch/powerpc/kernel/exceptions-64e.S:424: undefined reference to `kvmppc_handler_43_0x01B'
make: *** [vmlinux] Error 1
Looks we should add these altivec kvm handlers.
--- arch/powerpc/kvm/bookehv_interrupts.S | 5 +++++ 1 file changed, 5 insertions(+)
arch/powerpc/kvm/bookehv_interrupts.S +5 -0
@@ -319,6 +319,11 @@ kvm_handler BOOKE_INTERRUPT_DEBUG, EX_PARAMS(DBG), \ SPRN_DSRR0, SPRN_DSRR1, 0 kvm_handler BOOKE_INTERRUPT_DEBUG, EX_PARAMS(CRIT), \ SPRN_CSRR0, SPRN_CSRR1, 0 +/* altivec */ +kvm_handler BOOKE_INTERRUPT_ALTIVEC_UNAVAIL, EX_PARAMS(GEN), \ + SPRN_SRR0, SPRN_SRR1, 0 +kvm_handler BOOKE_INTERRUPT_ALTIVEC_ASSIST, EX_PARAMS(GEN), \ + SPRN_SRR0, SPRN_SRR1, 0 #else /* * For input register values, see arch/powerpc/include/asm/kvm_booke_hv_asm.h
Signature · 1 line
1.7.9.5
Quoted 45 lines
-----Original Message-----
From: [email protected] [mailto:kvm-ppc- [email protected]] On Behalf Of Tiejun Chen
Sent: Thursday, April 25, 2013 2:46 PM
To: [email protected]
Cc: [email protected]; [email protected]; [email protected]
Subject: [PATCH 1/1] kvm:book3e: Fix a build errorCommit
cd66cc2e, "powerpc/85xx: Add AltiVec support for e6500", adds support for AltiVec on a Book-E class processor, but while compiling in theCONFIG_PPC_BOOK3E_64andCONFIG_VIRTUALIZATIONcase, this introduce the following error:
arch/powerpc/kernel/exceptions-64e.S:402: undefined reference to `kvmppc_handler_42_0x01B'arch/powerpc/kernel/built-in.o: In function `exc_altivec_assist_book3e':arch/powerpc/kernel/exceptions-64e.S:424: undefined reference to `kvmppc_handler_43_0x01B'
make: *** [vmlinux] Error 1Looks we should add these altivec kvm handlers.
Signed-off-by Tiejun Chen <[email protected]>--- arch/powerpc/kvm/bookehv_interrupts.S | 5 +++++ 1 file changed, 5 insertions(+)arch/powerpc/kvm/bookehv_interrupts.S +5
-0@@ -319,6 +319,11 @@ kvm_handler BOOKE_INTERRUPT_DEBUG, EX_PARAMS(DBG), \ SPRN_DSRR0, SPRN_DSRR1, 0 kvm_handler BOOKE_INTERRUPT_DEBUG, EX_PARAMS(CRIT), \ SPRN_CSRR0, SPRN_CSRR1, 0 +/* altivec */ +kvm_handler BOOKE_INTERRUPT_ALTIVEC_UNAVAIL, EX_PARAMS(GEN), \ + SPRN_SRR0, SPRN_SRR1, 0 +kvm_handler BOOKE_INTERRUPT_ALTIVEC_ASSIST, EX_PARAMS(GEN), \ + SPRN_SRR0, SPRN_SRR1, 0 #else /* * For input register values, see
Quoted 2 lines
arch/powerpc/include/asm/kvm_booke_hv_asm.h
--
It seems that you are not using kvm-ppc-queue branch.
I already have a patch ready for this (and AltiVec support is work in progress) but we need first to pull e6500 kernel patches from Linux tree into agraf.git.
-Mike
Quoted 41 lines · On 04/25/2013 08:11 PM, Caraman Mihai Claudiu-B02008 wrote:
Quoted 41 lines
-----Original Message-----
From: [email protected] [mailto:kvm-ppc- [email protected]] On Behalf Of Tiejun Chen
Sent: Thursday, April 25, 2013 2:46 PM
To: [email protected]
Cc: [email protected]; [email protected]; [email protected]
Subject: [PATCH 1/1] kvm:book3e: Fix a build errorCommit
cd66cc2e, "powerpc/85xx: Add AltiVec support for e6500", adds support for AltiVec on a Book-E class processor, but while compiling in theCONFIG_PPC_BOOK3E_64andCONFIG_VIRTUALIZATIONcase, this introduce the following error:
arch/powerpc/kernel/exceptions-64e.S:402: undefined reference to `kvmppc_handler_42_0x01B'arch/powerpc/kernel/built-in.o: In function `exc_altivec_assist_book3e':arch/powerpc/kernel/exceptions-64e.S:424: undefined reference to `kvmppc_handler_43_0x01B'
make: *** [vmlinux] Error 1Looks we should add these altivec kvm handlers.
Signed-off-by Tiejun Chen <[email protected]>--- arch/powerpc/kvm/bookehv_interrupts.S | 5 +++++ 1 file changed, 5 insertions(+)arch/powerpc/kvm/bookehv_interrupts.S +4
-0@@ -319,6 +319,11 @@ kvm_handler BOOKE_INTERRUPT_DEBUG, EX_PARAMS(DBG), \ SPRN_DSRR0, SPRN_DSRR1, 0 kvm_handler BOOKE_INTERRUPT_DEBUG, EX_PARAMS(CRIT), \ SPRN_CSRR0, SPRN_CSRR1, 0 +/* altivec */ +kvm_handler BOOKE_INTERRUPT_ALTIVEC_UNAVAIL, EX_PARAMS(GEN), \ + SPRN_SRR0, SPRN_SRR1, 0 +kvm_handler BOOKE_INTERRUPT_ALTIVEC_ASSIST, EX_PARAMS(GEN), \
Quoted 8 lines
Quoted 6 lines
arch/powerpc/kvm/bookehv_interrupts.S +1
-0+ SPRN_SRR0, SPRN_SRR1, 0 #else /* * For input register values, see
arch/powerpc/include/asm/kvm_booke_hv_asm.h
--It seems that you are not using kvm-ppc-queue branch.
This is just used to fix a build error in powerpc.git when introduce commit cd66cc2e, "powerpc/85xx: Add AltiVec support for e6500", in *powerpc.git* as I mentioned in this patch head.
Quoted 2 lines
I already have a patch ready for this (and AltiVec support is work
This change don't block your AltiVec support for kvm unless you think this change is wrong. And especially, we always can reproduce this error with/without enabling AltiVec, so I also don't think this should be suspended until support e6500 in kvm since kvm based on e5500 should work.
Tiejun
Quoted 12 lines
in progress) but we need first to pull e6500 kernel patches from Linux tree into agraf.git.
-Mike