Skip to contentSkip to conversation

xfs: enhance warning on xfs_imap() failure in xfs_iunlink_remove()

PATCH In review Brian Foster 2 participants 2 messages Apr 26, 2013 XFS filesystem

lore
Share & tools
lore
#0 lore raw

PATCH v2 2/2 xfs: enhance warning on xfs_imap() failure in xfs_iunlink_remove()

From: Eric Sandeen <[email protected]>

Include the global ino, ag number and agino in the warning message emitted should xfs_imap() fail in the xfs_iunlink_remove() code path.

---
v2: Fix up indendation such that the string is on a single line.

 fs/xfs/xfs_inode.c |    6 ++++--
 1 files changed, 4 insertions(+), 2 deletions(-)
fs/xfs/xfs_inode.c +4 -2
index c22f980..f00c6d1 100644
@@ -1678,8 +1678,10 @@ xfs_iunlink_remove(
 			error = xfs_imap(mp, tp, next_ino, &imap, 0);
 			if (error) {
 				xfs_warn(mp,
-	"%s: xfs_imap returned error %d.",
-					 __func__, error);
+	"%s: xfs_imap() returned error %d for inode 0x%llx ag %d agino 0x%x",
+					 __func__, error, ip->i_ino,
+					 agno, agino);
+
 				return error;
 			}
 
Signature · 6 lines
1.7.7.6

_______________________________________________
xfs mailing list
[email protected]
http://oss.sgi.com/mailman/listinfo/xfs
Reviewed-by on v2 2/2
#1 lore raw
Quoted 7 lines · Brian Foster

From: Eric Sandeen <[email protected]>

Include the global ino, ag number and agino in the warning message emitted should xfs_imap() fail in the xfs_iunlink_remove() code path.

Looks good now.

Signature · 7 lines
Dave Chinner
[email protected]

_______________________________________________
xfs mailing list
[email protected]
http://oss.sgi.com/mailman/listinfo/xfs