ARM: dts: OMAP36xx/OMAP4460 Fix CPU OPP voltages
cover ARM: dts: OMAP36xx/OMAP4460 Fix CPU OPP voltages
Hi,
It seems that I have not been paying close attention to
actual voltage value seen on scope to map it back to verify the validity of the voltage value. Even though I did verify[1] that voltage did scale to values in DT entries, the values in the case of 3630 and 4460 were lower than what the spec voltage was as per opp_data files.
This series is based off Benoit's tree here:
http://git.kernel.org/cgit/linux/kernel/git/bcousson/linux-omap-dt.git/log/?h=for_3.10/dts
Commit ID's in the patches to indicate regressions are from there as well. Would be good to have this fix merged to 3.10 dts entries.
I have cross verified that OMAP3430,3630,4430 and 4460 entries now match that of corresponding opp*_data.c
My sincere apologies on the oversight.
Nishanth Menon (2):
ARM: dts: OMAP36xx: Fix CPU OPP voltages
ARM: dts: OMAP4460: Fix CPU OPP voltages
arch/arm/boot/dts/omap36xx.dtsi | 6 +++--- arch/arm/boot/dts/omap4460.dtsi | 6 +++--- 2 files changed, 6 insertions(+), 6 deletions(-)
[1] http://marc.info/?l=linux-arm-kernel&m=136580742724210&w=2
Regards,
Nishanth Menon
Signature · 1 line
1.7.9.5
PATCH 1/2 ARM: dts: OMAP36xx: Fix CPU OPP voltages
commit 3027e26 (ARM: dts: OMAP36xx: Add CPU OPP table) introduced wrong OPP voltages per OPP by mistake. Sync the OPP tables with existing OMAP36xx OPP data in arch/arm/mach-omap2/opp3xxx_data.c
--- arch/arm/boot/dts/omap36xx.dtsi | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)
arch/arm/boot/dts/omap36xx.dtsi +3 -3
@@ -20,9 +20,9 @@ cpu at 0 { operating-points = < /* kHz uV */ - 300000 975000 - 600000 1075000 - 800000 1200000 + 300000 1012500 + 600000 1200000 + 800000 1325000 >; clock-latency = <300000>; /* From legacy driver */ };
Signature · 1 line
1.7.9.5
PATCH 2/2 ARM: dts: OMAP4460: Fix CPU OPP voltages
In reply to Nishanth Menoncommit d16fb25 (ARM: dts: OMAP4460: Add CPU OPP table) introduced wrong OPP voltages per OPP by mistake. Sync the OPP tables with existing OMAP4460 OPP data in arch/arm/mach-omap2/opp4xxx_data.c
--- arch/arm/boot/dts/omap4460.dtsi | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)
arch/arm/boot/dts/omap4460.dtsi +3 -3
@@ -15,9 +15,9 @@ cpu at 0 { operating-points = < /* kHz uV */ - 350000 975000 - 700000 1075000 - 920000 1200000 + 350000 1025000 + 700000 1200000 + 920000 1313000 >; clock-latency = <300000>; /* From legacy driver */ };
Signature · 1 line
1.7.9.5
cover ARM: dts: OMAP36xx/OMAP4460 Fix CPU OPP voltages
In reply to Nishanth MenonTony/Benoit,
gentle offline ping for this series?
https://patchwork.kernel.org/patch/2494481/
https://patchwork.kernel.org/patch/2494491/
Regards,
Nishanth Menon
Quoted 29 lines · Nishanth Menon
Hi,
It seems that I have not been paying close attention to
actual voltage value seen on scope to map it back to verify the validity of the voltage value. Even though I did verify[1] that voltage did scale to values in DT entries, the values in the case of 3630 and 4460 were lower than what the spec voltage was as peropp_datafiles.This series is based off Benoit's tree here:
http://git.kernel.org/cgit/linux/kernel/git/bcousson/linux-omap-dt.git/log/?h=for_3.10/dtsCommit ID's in the patches to indicate regressions are from there as well. Would be good to have this fix merged to 3.10 dts entries.
I have cross verified that OMAP3430,3630,4430 and 4460 entries now match that of corresponding opp*_data.cMy sincere apologies on the oversight.
Nishanth Menon (2):
ARM: dts: OMAP36xx: Fix CPU OPP voltages
ARM: dts: OMAP4460: Fix CPU OPP voltagesarch/arm/boot/dts/omap36xx.dtsi | 6 +++--- arch/arm/boot/dts/omap4460.dtsi | 6 +++--- 2 files changed, 6 insertions(+), 6 deletions(-)[1] http://marc.info/?l=linux-arm-kernel&m=136580742724210&w=2
Regards,
Nishanth Menon
cover ARM: dts: OMAP36xx/OMAP4460 Fix CPU OPP voltages
In reply to Nishanth MenonQuoted 21 lines · Nishanth Menon
Hi,
It seems that I have not been paying close attention to
actual voltage value seen on scope to map it back to verify the validity of the voltage value. Even though I did verify[1] that voltage did scale to values in DT entries, the values in the case of 3630 and 4460 were lower than what the spec voltage was as peropp_datafiles.This series is based off Benoit's tree here:
http://git.kernel.org/cgit/linux/kernel/git/bcousson/linux-omap-dt.git/log/?h=for_3.10/dtsCommit ID's in the patches to indicate regressions are from there as well. Would be good to have this fix merged to 3.10 dts entries.
I have cross verified that OMAP3430,3630,4430 and 4460 entries now match that of corresponding opp*_data.cMy sincere apologies on the oversight.
Nishanth Menon (2):
ARM: dts: OMAP36xx: Fix CPU OPP voltages
ARM: dts: OMAP4460: Fix CPU OPP voltages
Quoted 5 lines
arch/arm/boot/dts/omap36xx.dtsi | 6 +++--- arch/arm/boot/dts/omap4460.dtsi | 6 +++--- 2 files changed, 6 insertions(+), 6 deletions(-)[1] http://marc.info/?l=linux-arm-kernel&m=136580742724210&w=2
Thanks applying both into omap-for-v3.10/dt-fixes.
Regards,
Tony