Skip to contentSkip to conversation

media: coda: Fix compile breakage

PATCH New Alexander Shiyan 3 participants 4 messages Apr 27, 2013 Media (V4L/DVB)

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 media: coda: Fix compile breakage

Patch adds GENERIC_ALLOCATOR, if "coda" is selected.

drivers/built-in.o: In function `coda_remove':
:(.text+0x110634): undefined reference to gen_pool_free' drivers/built-in.o: In function coda_probe':
:(.text+0x1107d4): undefined reference to of_get_named_gen_pool' :(.text+0x1108b8): undefined reference to gen_pool_alloc' :(.text+0x1108d0): undefined reference to gen_pool_virt_to_phys' :(.text+0x110918): undefined reference to dev_get_gen_pool'

---
 drivers/media/platform/Kconfig | 1 +
 1 file changed, 1 insertion(+)
drivers/media/platform/Kconfig +1 -0
index 0cbe1ff..414a769 100644
@@ -145,6 +145,7 @@ config VIDEO_CODA
 	depends on VIDEO_DEV && VIDEO_V4L2 && ARCH_MXC
 	select VIDEOBUF2_DMA_CONTIG
 	select V4L2_MEM2MEM_DEV
+	select GENERIC_ALLOCATOR
 	---help---
 	   Coda is a range of video codec IPs that supports
 	   H.264, MPEG-4, and other video formats.
Signature · 1 line
1.8.1.5
#1 lore raw

PATCH 1/1 media: coda: Fix compile breakage

Quoted 11 lines · Alexander Shiyan

Patch adds GENERIC_ALLOCATOR, if "coda" is selected.

drivers/built-in.o: In function `coda_remove':
:(.text+0x110634): undefined reference to gen_pool_free' drivers/built-in.o: In function coda_probe':
:(.text+0x1107d4): undefined reference to of_get_named_gen_pool' :(.text+0x1108b8): undefined reference to gen_pool_alloc' :(.text+0x1108d0): undefined reference to gen_pool_virt_to_phys' :(.text+0x110918): undefined reference to dev_get_gen_pool'

I noticed the problem as well, but haven't gotten around to create a patch. Thanks for taking care of this!

Arnd

#2 lore raw

PATCH 1/1 media: coda: Fix compile breakage

Alexander/Arnd,

Quoted 11 lines · Arnd Bergmann
Quoted 10 lines · Alexander Shiyan

Patch adds GENERIC_ALLOCATOR, if "coda" is selected.

drivers/built-in.o: In function `coda_remove':
:(.text+0x110634): undefined reference to gen_pool_free' drivers/built-in.o: In function coda_probe':
:(.text+0x1107d4): undefined reference to of_get_named_gen_pool' :(.text+0x1108b8): undefined reference to gen_pool_alloc' :(.text+0x1108d0): undefined reference to gen_pool_virt_to_phys' :(.text+0x110918): undefined reference to dev_get_gen_pool'

Quoted 6 lines
Quoted 1 line

I noticed the problem as well, but haven't gotten around to create a patch. Thanks for taking care of this!

I fixed this issue in a different way:
https://patchwork.kernel.org/patch/2432841/

And Shawn has already queued it.