Skip to contentSkip to conversation

perf: report loops endlessly if record was killed via SIGTERM

DISCUSSION Mike Galbraith 2 participants 3 messages Apr 29, 2013

lore
Share & tools
lore
#0 lore raw

Boring notabug report, but..

(Dr. Dr., perf acts all dainbramaged when you shoot it in the head)

reproducer: perf record -a -g& sleep 1;whatever;killall perf

Discovered because AIM7 needs input, and does not run properly when profiled via the more conventional perf record -a -g -- ./multitask -nl -f. Ergo, start perf record, run AIM7, kill perf. Say SIGINT instead, and it works as expected. SIGTERM leaves perf.data in a bad state that report can't deal with, but it'll happily keep trying forever.

Only mentioned because some other user might try to workaround input nogo thingy and meet the same.

-Mike

#1 lore raw
Quoted 3 lines · Mike Galbraith

Say SIGINT instead,
and it works as expected. SIGTERM leaves perf.data in a bad state that report can't deal with, but it'll happily keep trying forever.

header is usually updated on_exit which requires a clean exit. perhaps we should add SIGTERM to the signal list.

David

#2 lore raw
Quoted 7 lines · David Ahern
Quoted 3 lines · Mike Galbraith

Say SIGINT instead,
and it works as expected. SIGTERM leaves perf.data in a bad state that report can't deal with, but it'll happily keep trying forever.

header is usually updated on_exit which requires a clean exit. perhaps we should add SIGTERM to the signal list.

Yeah. Graceful exit, and idiot proofing for free :)

-Mike