tcp: reset timer after any SYNACK retransmit
Subsystems (3)
PATCH 1/1 tcp: reset timer after any SYNACK retransmit
Linux immediately returns SYNACK on (spurious) SYN retransmits, but keeps the SYNACK timer running independently. Thus the timer may fire right after the SYNACK retransmit and causes a SYN-SYNACK cross-fire burst.
Adopt the fast retransmit/recovery idea in established state by re-arming the SYNACK timer after the fast (SYNACK) retransmit. The timer may fire late up to 500ms due to the current SYNACK timer wheel, but it's OK to be conservative when network is congested. Eric's new listener design should address this issue.
--- net/ipv4/tcp_minisocks.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-)
net/ipv4/tcp_minisocks.c +6 -1
@@ -551,8 +551,13 @@ struct sock *tcp_check_req(struct sock *sk, struct sk_buff *skb,* * Note that even if there is new data in the SYN packet * they will be thrown away too. +* +* Reset timer after retransmitting SYNACK, similar to +* the idea of fast retransmit in recovery. */ -inet_rtx_syn_ack (sk, req); +if (!inet_rtx_syn_ack (sk, req)) + req->expires =min (TCP_TIMEOUT_INIT << req->num_timeout, +TCP_RTO_MAX ) + jiffies;return NULL ; }
Signature · 1 line
1.8.2.1
Quoted 5 lines · Yuchung Cheng
Linux immediately returns SYNACK on (spurious) SYN retransmits, but keeps the SYNACK timer running independently. Thus the timer may fire right after the SYNACK retransmit and causes a SYN-SYNACK cross-fire burst.
Quoted 8 lines
Adopt the fast retransmit/recovery idea in established state by re-arming the SYNACK timer after the fast (SYNACK) retransmit. The timer may fire late up to 500ms due to the current SYNACK timer wheel, but it's OK to be conservative when network is congested. Eric's new listener design should address this issue.
Signed-off-by Yuchung Cheng <[email protected]>---
Quoted 5 lines · Yuchung Cheng
Linux immediately returns SYNACK on (spurious) SYN retransmits, but keeps the SYNACK timer running independently. Thus the timer may fire right after the SYNACK retransmit and causes a SYN-SYNACK cross-fire burst.
Quoted 7 lines
Adopt the fast retransmit/recovery idea in established state by re-arming the SYNACK timer after the fast (SYNACK) retransmit. The timer may fire late up to 500ms due to the current SYNACK timer wheel, but it's OK to be conservative when network is congested. Eric's new listener design should address this issue.
Signed-off-by Yuchung Cheng <[email protected]>
neal
From: Yuchung Cheng <[email protected]>
Date: Mon, 29 Apr 2013 11:44:51 -0700
Quoted 5 lines
Linux immediately returns SYNACK on (spurious) SYN retransmits, but keeps the SYNACK timer running independently. Thus the timer may fire right after the SYNACK retransmit and causes a SYN-SYNACK cross-fire burst.
Quoted 7 lines
Adopt the fast retransmit/recovery idea in established state by re-arming the SYNACK timer after the fast (SYNACK) retransmit. The timer may fire late up to 500ms due to the current SYNACK timer wheel, but it's OK to be conservative when network is congested. Eric's new listener design should address this issue.
Signed-off-by Yuchung Cheng <[email protected]>
Applied.
Maybe -stable material?
Quoted 14 lines · David Miller
From: Yuchung Cheng <[email protected]>
Date: Mon, 29 Apr 2013 11:44:51 -0700Quoted 11 lines
Linux immediately returns SYNACK on (spurious) SYN retransmits, but keeps the SYNACK timer running independently. Thus the timer may fire right after the SYNACK retransmit and causes a SYN-SYNACK cross-fire burst.
Adopt the fast retransmit/recovery idea in established state by re-arming the SYNACK timer after the fast (SYNACK) retransmit. The timer may fire late up to 500ms due to the current SYNACK timer wheel, but it's OK to be conservative when network is congested. Eric's new listener design should address this issue.
Quoted 5 lines
Quoted 1 line
Signed-off-by Yuchung Cheng <[email protected]>Applied.
Maybe -stable material?
Should be fine for -stable too. Thanks.