3c509.c: call SET_NETDEV_DEV for all device types (ISA/ISAPnP/EISA)
Subsystems (3)
PATCH 1/1 3c509.c: call SET_NETDEV_DEV for all device types (ISA/ISAPnP/EISA)
The venerable 3c509 driver only sets its device parent in one case, the ISAPnP one. It does this with the SET_NETDEV_DEV function. It should register with the device hierarchy in two additional cases: standard (non-PnP) ISA and EISA.
- Currently they appear here:/sys/devices/virtual/net/eth0 (standard ISA)/sys/devices/virtual/net/eth1 (EISA)
- Rather, they should instead be here:/sys/devices/isa/3c509.0/net/eth0 (standard ISA) /sys/devices/pci0000:00/0000:00:07.0/00:04/net/eth1 (EISA)
Tested on ISA and EISA boards.
--- drivers/net/ethernet/3com/3c509.c | 2 ++ 1 files changed, 2 insertions(+), 0 deletions(-)
drivers/net/ethernet/3com/3c509.c +2 -0
@@ -306,6 +306,7 @@ static int el3_isa_match(struct device *pdev, unsigned int ndev)if (!dev)return -ENOMEM ; +SET_NETDEV_DEV (dev, pdev);netdev_boot_setup_check (dev);if (!request_region (ioaddr,EL3_IO_EXTENT ,"3c509-isa" )) {
@@ -595,6 +596,7 @@ static int __init el3_eisa_probe (struct device *device)return -ENOMEM ; } +SET_NETDEV_DEV (dev, device);netdev_boot_setup_check (dev);el3_dev_fill (dev, phys_addr, ioaddr, irq, if_port,EL3_EISA );
Signature · 1 line
1.7.2.5
David Miller
maintainerFrom: Matthew Whitehead <[email protected]>
Date: Mon, 29 Apr 2013 17:46:53 -0400
Quoted 8 lines
The venerable 3c509 driver only sets its device parent in one case, the ISAPnP one. It does this with the
SET_NETDEV_DEVfunction. It should register with the device hierarchy in two additional cases: standard (non-PnP) ISA and EISA.- Currently they appear here:
/sys/devices/virtual/net/eth0(standard ISA)/sys/devices/virtual/net/eth1(EISA)
Quoted 7 lines
- Rather, they should instead be here:
/sys/devices/isa/3c509.0/net/eth0(standard ISA) /sys/devices/pci0000:00/0000:00:07.0/00:04/net/eth1 (EISA)Tested on ISA and EISA boards.
Signed-off-by Matthew Whitehead <[email protected]>
Applied and queued up for -stable, thanks for being so persistent about this fix :-)