Skip to contentSkip to conversation

ISCI: add more PCI IDs

PATCH In review Evgeni Golov 2 participants 4 messages Apr 30, 2013

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 ISCI: add more PCI IDs

These are found in e.g. the R2000GZ/GL machines.

---
 drivers/scsi/isci/init.c |    4 ++++
 1 files changed, 4 insertions(+), 0 deletions(-)
drivers/scsi/isci/init.c +4 -0
index 2839baa..d1ec2bd 100644
@@ -82,12 +82,16 @@ static DEFINE_PCI_DEVICE_TABLE(isci_id_table) = {
 	{ PCI_VDEVICE(INTEL, 0x1D67),},
 	{ PCI_VDEVICE(INTEL, 0x1D69),},
 	{ PCI_VDEVICE(INTEL, 0x1D6B),},
+	{ PCI_VDEVICE(INTEL, 0x1D6D),},
+	{ PCI_VDEVICE(INTEL, 0x1D6F),},
 	{ PCI_VDEVICE(INTEL, 0x1D60),},
 	{ PCI_VDEVICE(INTEL, 0x1D62),},
 	{ PCI_VDEVICE(INTEL, 0x1D64),},
 	{ PCI_VDEVICE(INTEL, 0x1D66),},
 	{ PCI_VDEVICE(INTEL, 0x1D68),},
 	{ PCI_VDEVICE(INTEL, 0x1D6A),},
+	{ PCI_VDEVICE(INTEL, 0x1D6C),},
+	{ PCI_VDEVICE(INTEL, 0x1D6E),},
 	{}
 };
 
Signature · 1 line
1.7.2.5
#1 lore raw
Quoted 1 line · Evgeni Golov

These are found in e.g. the R2000GZ/GL machines.

Nack. These PCI device IDs are reserved for third party device drivers. Most likely that machine has a third party OROM as well.

Quoted 25 lines
---
  drivers/scsi/isci/init.c |    4 ++++
  1 files changed, 4 insertions(+), 0 deletions(-)
drivers/scsi/isci/init.c +4 -0
index 2839baa..d1ec2bd 100644
@@ -82,12 +82,16 @@ static DEFINE_PCI_DEVICE_TABLE(isci_id_table) = {
  	{ PCI_VDEVICE(INTEL, 0x1D67),},
  	{ PCI_VDEVICE(INTEL, 0x1D69),},
  	{ PCI_VDEVICE(INTEL, 0x1D6B),},
+	{ PCI_VDEVICE(INTEL, 0x1D6D),},
+	{ PCI_VDEVICE(INTEL, 0x1D6F),},
  	{ PCI_VDEVICE(INTEL, 0x1D60),},
  	{ PCI_VDEVICE(INTEL, 0x1D62),},
  	{ PCI_VDEVICE(INTEL, 0x1D64),},
  	{ PCI_VDEVICE(INTEL, 0x1D66),},
  	{ PCI_VDEVICE(INTEL, 0x1D68),},
  	{ PCI_VDEVICE(INTEL, 0x1D6A),},
+	{ PCI_VDEVICE(INTEL, 0x1D6C),},
+	{ PCI_VDEVICE(INTEL, 0x1D6E),},
  	{}
  };
 
Signature · 4 lines
Dave Jiang
Application Engineer, Storage Divsion
Intel Corp.
[email protected]
#2 lore raw
Quoted 4 lines · Dave Jiang
Quoted 1 line

These are found in e.g. the R2000GZ/GL machines.

Nack. These PCI device IDs are reserved for third party device drivers. Most likely that machine has a third party OROM as well.

OROM = option ROM? Yes, it has the "white" C600 expansion pack, so we can use all 8 ports of the SAS controller. But we do not want (and actually cannot) use the Intel-provided megasr driver (the machines run Debian Wheezy with the 3.2 kernel).

Can we get the controller to use the "regular" PCI ID instead?

Regards
Evgeni

#3 lore raw
Quoted 10 lines · Evgeni Golov
Quoted 3 lines · Dave Jiang
Quoted 1 line

These are found in e.g. the R2000GZ/GL machines.

Nack. These PCI device IDs are reserved for third party device drivers. Most likely that machine has a third party OROM as well.

OROM = option ROM? Yes, it has the "white" C600 expansion pack, so we can use all 8 ports of the SAS controller. But we do not want (and actually cannot) use the Intel-provided megasr driver (the machines run Debian Wheezy with the 3.2 kernel).

Can we get the controller to use the "regular" PCI ID instead?

Yes. You need an Intel Option ROM instead of the LSI. You need to talk to whomever sold you the system and get the Intel OROM. Also just an FYI, the isci driver didn't get a lot of the issues sorted out until kernel 3.7. The 3.2 driver is quite old and you may run into issues. Obviously you already know you can patch the driver to pick up those device IDs, but I don't know what the LSI OROM does with the OEM parameters and if will provide it to the isci driver properly.

Quoted 2 lines

Regards
Evgeni

Signature · 4 lines
Dave Jiang
Application Engineer, Storage Divsion
Intel Corp.
[email protected]